| Message ID | 20220204125543.1189151-1-angelogioacchino.delregno@collabora.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | memory: mtk-smi: Enable sleep ctrl safety function for MT8195 | expand |
On 07/02/2022 04:12, Macpaul Lin wrote: > On 2/4/22 8:55 PM, AngeloGioacchino Del Regno wrote: >> Enable the sleep ctrl function to wait until all the queued commands >> are executed before suspending the LARBs, like done for MT8186. >> >> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> >> --- >> drivers/memory/mtk-smi.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/memory/mtk-smi.c b/drivers/memory/mtk-smi.c >> index c22acd3ddd10..86a3d34f418e 100644 >> --- a/drivers/memory/mtk-smi.c >> +++ b/drivers/memory/mtk-smi.c >> @@ -351,7 +351,8 @@ static const struct mtk_smi_larb_gen mtk_smi_larb_mt8192 = { >> >> static const struct mtk_smi_larb_gen mtk_smi_larb_mt8195 = { >> .config_port = mtk_smi_larb_config_port_gen2_general, >> -.flags_general = MTK_SMI_FLAG_THRT_UPDATE | MTK_SMI_FLAG_SW_FLAG, >> +.flags_general = MTK_SMI_FLAG_THRT_UPDATE | MTK_SMI_FLAG_SW_FLAG | >> + MTK_SMI_FLAG_SLEEP_CTL, >> .ostd = mtk_smi_larb_mt8195_ostd, >> }; >> >> > > Reviewed-by: Macpaul Lin <macpaul.lin@mediatek.com> Thanks for the review, appreciated! > ************* MEDIATEK Confidentiality Notice > ******************** > The information contained in this e-mail message (including any > attachments) may be confidential, proprietary, privileged, or otherwise > exempt from disclosure under applicable laws. It is intended to be > conveyed only to the designated recipient(s). Any use, dissemination, > distribution, printing, retaining or copying of this e-mail (including its > attachments) by unintended recipient(s) is strictly prohibited and may > be unlawful. If you are not an intended recipient of this e-mail, or believe > > that you have received this e-mail in error, please notify the sender > immediately (by replying to this e-mail), delete any and all copies of > this e-mail (including any attachments) from your system, and do not > disclose the content of this e-mail to any other person. Thank you! Please work on your email setup, so we won't see such stuff. I know it is autogenerated by company systems, yet still it should not be put in public discussion. Best regards, Krzysztof
On Fri, 4 Feb 2022 13:55:43 +0100, AngeloGioacchino Del Regno wrote: > Enable the sleep ctrl function to wait until all the queued commands > are executed before suspending the LARBs, like done for MT8186. > > Applied, thanks! [1/1] memory: mtk-smi: Enable sleep ctrl safety function for MT8195 commit: 12fbfd665fc473800d25d0f3ca4617c82cff42dd Best regards,
diff --git a/drivers/memory/mtk-smi.c b/drivers/memory/mtk-smi.c index c22acd3ddd10..86a3d34f418e 100644 --- a/drivers/memory/mtk-smi.c +++ b/drivers/memory/mtk-smi.c @@ -351,7 +351,8 @@ static const struct mtk_smi_larb_gen mtk_smi_larb_mt8192 = { static const struct mtk_smi_larb_gen mtk_smi_larb_mt8195 = { .config_port = mtk_smi_larb_config_port_gen2_general, - .flags_general = MTK_SMI_FLAG_THRT_UPDATE | MTK_SMI_FLAG_SW_FLAG, + .flags_general = MTK_SMI_FLAG_THRT_UPDATE | MTK_SMI_FLAG_SW_FLAG | + MTK_SMI_FLAG_SLEEP_CTL, .ostd = mtk_smi_larb_mt8195_ostd, };
Enable the sleep ctrl function to wait until all the queued commands are executed before suspending the LARBs, like done for MT8186. Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> --- drivers/memory/mtk-smi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)