diff mbox series

[1/6] dt-bindings: spi: Add compatible for Mediatek IPM IP with single mode

Message ID 20220209111938.16137-2-leilk.liu@mediatek.com (mailing list archive)
State New, archived
Headers show
Series [1/6] dt-bindings: spi: Add compatible for Mediatek IPM IP with single mode | expand

Commit Message

Leilk Liu Feb. 9, 2022, 11:19 a.m. UTC
This commit adds dt-binding documentation for
Mediatek SPI IPM IP with single mode.

Signed-off-by: Leilk Liu <leilk.liu@mediatek.com>
---
 Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml | 1 +
 1 file changed, 1 insertion(+)

Comments

Krzysztof Kozlowski Feb. 11, 2022, 11:44 a.m. UTC | #1
On 09/02/2022 12:19, Leilk Liu wrote:
> This commit adds dt-binding documentation for
> Mediatek SPI IPM IP with single mode.

Please do not use "This commit":
https://elixir.bootlin.com/linux/v5.13/source/Documentation/process/submitting-patches.rst#L89

Wrap around 75-chars, just like our guidelines are saying.

> 
> Signed-off-by: Leilk Liu <leilk.liu@mediatek.com>
> ---
>  Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml b/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml
> index bfa44acb1bdd..0a2fc0404cb3 100644
> --- a/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml
> +++ b/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml
> @@ -41,6 +41,7 @@ properties:
>                - mediatek,mt8135-spi
>                - mediatek,mt8173-spi
>                - mediatek,mt8183-spi
> +              - mediatek,ipm-spi-single
>  
>    reg:
>      maxItems: 1


Best regards,
Krzysztof
Rob Herring (Arm) Feb. 11, 2022, 4:55 p.m. UTC | #2
On Wed, Feb 09, 2022 at 07:19:33PM +0800, Leilk Liu wrote:
> This commit adds dt-binding documentation for
> Mediatek SPI IPM IP with single mode.
> 
> Signed-off-by: Leilk Liu <leilk.liu@mediatek.com>
> ---
>  Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml b/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml
> index bfa44acb1bdd..0a2fc0404cb3 100644
> --- a/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml
> +++ b/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml
> @@ -41,6 +41,7 @@ properties:
>                - mediatek,mt8135-spi
>                - mediatek,mt8173-spi
>                - mediatek,mt8183-spi
> +              - mediatek,ipm-spi-single

Is IPM an SoC? Compatible strings should be SoC specific or whatever 
granularity could have a unique errata.

Rob
Leilk Liu Feb. 14, 2022, 1:41 a.m. UTC | #3
On Fri, 2022-02-11 at 12:44 +0100, Krzysztof Kozlowski wrote:
> On 09/02/2022 12:19, Leilk Liu wrote:
> > This commit adds dt-binding documentation for
> > Mediatek SPI IPM IP with single mode.
> 
> Please do not use "This commit":
> 
https://elixir.bootlin.com/linux/v5.13/source/Documentation/process/submitting-patches.rst#L89
> 
> Wrap around 75-chars, just like our guidelines are saying.
> 
OK, I'll fix them,thanks

> > 
> > Signed-off-by: Leilk Liu <leilk.liu@mediatek.com>
> > ---
> >  Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml | 1
> > +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/spi/mediatek,spi-
> > mt65xx.yaml b/Documentation/devicetree/bindings/spi/mediatek,spi-
> > mt65xx.yaml
> > index bfa44acb1bdd..0a2fc0404cb3 100644
> > --- a/Documentation/devicetree/bindings/spi/mediatek,spi-
> > mt65xx.yaml
> > +++ b/Documentation/devicetree/bindings/spi/mediatek,spi-
> > mt65xx.yaml
> > @@ -41,6 +41,7 @@ properties:
> >                - mediatek,mt8135-spi
> >                - mediatek,mt8173-spi
> >                - mediatek,mt8183-spi
> > +              - mediatek,ipm-spi-single
> >  
> >    reg:
> >      maxItems: 1
> 
> 
> Best regards,
> Krzysztof
Leilk Liu Feb. 14, 2022, 1:49 a.m. UTC | #4
On Fri, 2022-02-11 at 10:55 -0600, Rob Herring wrote:
> On Wed, Feb 09, 2022 at 07:19:33PM +0800, Leilk Liu wrote:
> > This commit adds dt-binding documentation for
> > Mediatek SPI IPM IP with single mode.
> > 
> > Signed-off-by: Leilk Liu <leilk.liu@mediatek.com>
> > ---
> >  Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml | 1
> > +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/spi/mediatek,spi-
> > mt65xx.yaml b/Documentation/devicetree/bindings/spi/mediatek,spi-
> > mt65xx.yaml
> > index bfa44acb1bdd..0a2fc0404cb3 100644
> > --- a/Documentation/devicetree/bindings/spi/mediatek,spi-
> > mt65xx.yaml
> > +++ b/Documentation/devicetree/bindings/spi/mediatek,spi-
> > mt65xx.yaml
> > @@ -41,6 +41,7 @@ properties:
> >                - mediatek,mt8135-spi
> >                - mediatek,mt8173-spi
> >                - mediatek,mt8183-spi
> > +              - mediatek,ipm-spi-single
> 
> Is IPM an SoC? Compatible strings should be SoC specific or whatever 
> granularity could have a unique errata.
> 
IPM is an version of SPI ip, we use this IP with ICs now. So I define a
compatible strings "mediatek,ipm-spi-single", then I can reuse this
compatible strings with many ICs.

> Rob
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml b/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml
index bfa44acb1bdd..0a2fc0404cb3 100644
--- a/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml
+++ b/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml
@@ -41,6 +41,7 @@  properties:
               - mediatek,mt8135-spi
               - mediatek,mt8173-spi
               - mediatek,mt8183-spi
+              - mediatek,ipm-spi-single
 
   reg:
     maxItems: 1