| Message ID | 20220327223927.20848-5-granquet@baylibre.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/mediatek: Add mt8195 DisplayPort driver | expand |
Il 28/03/22 00:39, Guillaume Ranquet ha scritto: > Signed-off-by: Guillaume Ranquet <granquet@baylibre.com> > --- > include/drm/drm_edid.h | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git a/include/drm/drm_edid.h b/include/drm/drm_edid.h > index 144c495b99c4..5d4d840b9904 100644 > --- a/include/drm/drm_edid.h > +++ b/include/drm/drm_edid.h > @@ -359,12 +359,17 @@ struct edid { > > #define EDID_PRODUCT_ID(e) ((e)->prod_code[0] | ((e)->prod_code[1] << 8)) > > -/* Short Audio Descriptor */ Hello Guillaume, > +/* struct cea_sad - Short Audio Descriptor. > + @format: See HDMI_AUDIO_CODING_TYPE_*. > + @channels: max number of channels - 1. > + @freq: See CEA_SAD_FREQ_*. > + @byte2: meaning depends on format. > +*/ I appreciate the effort, but this is not valid kerneldoc. Please refer to https://docs.kernel.org/doc-guide/kernel-doc.html Regards, Angelo
On Mon, 28 Mar 2022 10:04, AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> wrote: >Il 28/03/22 00:39, Guillaume Ranquet ha scritto: >> Signed-off-by: Guillaume Ranquet <granquet@baylibre.com> >> --- >> include/drm/drm_edid.h | 11 ++++++++--- >> 1 file changed, 8 insertions(+), 3 deletions(-) >> >> diff --git a/include/drm/drm_edid.h b/include/drm/drm_edid.h >> index 144c495b99c4..5d4d840b9904 100644 >> --- a/include/drm/drm_edid.h >> +++ b/include/drm/drm_edid.h >> @@ -359,12 +359,17 @@ struct edid { >> >> #define EDID_PRODUCT_ID(e) ((e)->prod_code[0] | ((e)->prod_code[1] << 8)) >> >> -/* Short Audio Descriptor */ > >Hello Guillaume, > >> +/* struct cea_sad - Short Audio Descriptor. >> + @format: See HDMI_AUDIO_CODING_TYPE_*. >> + @channels: max number of channels - 1. >> + @freq: See CEA_SAD_FREQ_*. >> + @byte2: meaning depends on format. >> +*/ > >I appreciate the effort, but this is not valid kerneldoc. > >Please refer to https://docs.kernel.org/doc-guide/kernel-doc.html > >Regards, >Angelo Hello Angelo, Thx for your review. I'm sorry I posted this v9 in a bit of a rush... but I promise we will get there... eventually :D Thx, Guillaume.
diff --git a/include/drm/drm_edid.h b/include/drm/drm_edid.h index 144c495b99c4..5d4d840b9904 100644 --- a/include/drm/drm_edid.h +++ b/include/drm/drm_edid.h @@ -359,12 +359,17 @@ struct edid { #define EDID_PRODUCT_ID(e) ((e)->prod_code[0] | ((e)->prod_code[1] << 8)) -/* Short Audio Descriptor */ +/* struct cea_sad - Short Audio Descriptor. + @format: See HDMI_AUDIO_CODING_TYPE_*. + @channels: max number of channels - 1. + @freq: See CEA_SAD_FREQ_*. + @byte2: meaning depends on format. +*/ struct cea_sad { u8 format; - u8 channels; /* max number of channels - 1 */ + u8 channels; u8 freq; - u8 byte2; /* meaning depends on format */ + u8 byte2; }; struct drm_encoder;
Signed-off-by: Guillaume Ranquet <granquet@baylibre.com> --- include/drm/drm_edid.h | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-)