| Message ID | 20220415153629.1817202-8-fparent@baylibre.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Input: mtk-pmic-keys: Add support for MT6359 PMIC | expand |
Il 15/04/22 17:36, Fabien Parent ha scritto: > Add node for the MT6359 PMIC keyboard in mt6359.dtsi. > > Signed-off-by: Fabien Parent <fparent@baylibre.com> Hello Fabien, I agree that all MT6359 PMICs do support pmic-keys, but not all devices using this PMIC have physical keys connected to that. Besides, even if all of them did, it wouldn't be guaranteed that key-0 would be always KEY_POWER, as much as it wouldn't be guaranteed that key-1 would be always KEY_HOME. In my opinion, it *is* correct to add mediatek,mt6359-keys to the PMIC dtsi, but you should do that without declaring any key, hence it's enough to do: mt6359_keys: mtk-pmic-keys { compatible = "mediatek,mt6359-keys"; }; ... then, any machine that *actually does* have these keys connected and manageable in Linux should declare its own keys in its own dts/dtsi. Of course, this means that you'll have to remove your input.h inclusion as well. Regards, Angelo
diff --git a/arch/arm64/boot/dts/mediatek/mt6359.dtsi b/arch/arm64/boot/dts/mediatek/mt6359.dtsi index 18c0d5325c22..dcafe1ff23ae 100644 --- a/arch/arm64/boot/dts/mediatek/mt6359.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt6359.dtsi @@ -3,6 +3,8 @@ * Copyright (c) 2021 MediaTek Inc. */ +#include <dt-bindings/input/input.h> + &pwrap { pmic: pmic { compatible = "mediatek,mt6359"; @@ -294,5 +296,18 @@ mt6359_vsram_others_sshub_ldo: ldo_vsram_others_sshub { mt6359rtc: mt6359rtc { compatible = "mediatek,mt6358-rtc"; }; + + mt6359keys: keyboard { + compatible = "mediatek,mt6359-keys"; + + key-0 { + linux,keycodes = <KEY_POWER>; + wakeup-source; + }; + + key-1 { + linux,keycodes = <KEY_HOME>; + }; + }; }; };
Add node for the MT6359 PMIC keyboard in mt6359.dtsi. Signed-off-by: Fabien Parent <fparent@baylibre.com> --- Dependency on: https://patchwork.kernel.org/project/linux-mediatek/patch/1622011927-359-9-git-send-email-hsin-hsiung.wang@mediatek.com/ arch/arm64/boot/dts/mediatek/mt6359.dtsi | 15 +++++++++++++++ 1 file changed, 15 insertions(+)