diff mbox series

dt-bindings: rtc: mediatek: add mt6358 and mt6366 compatible

Message ID 20220428064637.28288-1-allen-kh.cheng@mediatek.com (mailing list archive)
State New, archived
Headers show
Series dt-bindings: rtc: mediatek: add mt6358 and mt6366 compatible | expand

Commit Message

Allen-KH Cheng April 28, 2022, 6:46 a.m. UTC
Add mt6358 and mt6366 compatible in devicetree-binding document for
MediaTek PMIC based RTC. mt6358 and mt6366 use same compatible data
to store RTC_WRTGR address offset.

mt6366-rtc will use mt6358-rts as fallback.

Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
---
 Documentation/devicetree/bindings/rtc/rtc-mt6397.txt | 2 ++
 1 file changed, 2 insertions(+)

Comments

Krzysztof Kozlowski April 28, 2022, 7:20 a.m. UTC | #1
On 28/04/2022 08:46, Allen-KH Cheng wrote:
> Add mt6358 and mt6366 compatible in devicetree-binding document for
> MediaTek PMIC based RTC. mt6358 and mt6366 use same compatible data
> to store RTC_WRTGR address offset.
> 
> mt6366-rtc will use mt6358-rts as fallback.
> 
> Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
> ---
>  Documentation/devicetree/bindings/rtc/rtc-mt6397.txt | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/rtc/rtc-mt6397.txt b/Documentation/devicetree/bindings/rtc/rtc-mt6397.txt
> index 55a0c8874c03..5b012d222f5b 100644
> --- a/Documentation/devicetree/bindings/rtc/rtc-mt6397.txt
> +++ b/Documentation/devicetree/bindings/rtc/rtc-mt6397.txt
> @@ -14,6 +14,8 @@ For MediaTek PMIC wrapper bus bindings, see:
>  Required properties:
>  - compatible: Should be one of follows
>         "mediatek,mt6323-rtc": for MT6323 PMIC
> +       "mediatek,mt6358-rtc": for MT6358 PMIC
> +       "mediatek,mt6358-rtc","mediatek,mt6366-rtc": for MT6366 PMIC

Does not look like in correct order.

>         "mediatek,mt6397-rtc": for MT6397 PMIC
>  
>  Example:


Best regards,
Krzysztof
Allen-KH Cheng April 28, 2022, 7:57 a.m. UTC | #2
Hi Krzysztof,

On Thu, 2022-04-28 at 09:20 +0200, Krzysztof Kozlowski wrote:
> On 28/04/2022 08:46, Allen-KH Cheng wrote:
> > Add mt6358 and mt6366 compatible in devicetree-binding document for
> > MediaTek PMIC based RTC. mt6358 and mt6366 use same compatible data
> > to store RTC_WRTGR address offset.
> > 
> > mt6366-rtc will use mt6358-rts as fallback.
> > 
> > Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
> > ---
> >  Documentation/devicetree/bindings/rtc/rtc-mt6397.txt | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/rtc/rtc-mt6397.txt
> > b/Documentation/devicetree/bindings/rtc/rtc-mt6397.txt
> > index 55a0c8874c03..5b012d222f5b 100644
> > --- a/Documentation/devicetree/bindings/rtc/rtc-mt6397.txt
> > +++ b/Documentation/devicetree/bindings/rtc/rtc-mt6397.txt
> > @@ -14,6 +14,8 @@ For MediaTek PMIC wrapper bus bindings, see:
> >  Required properties:
> >  - compatible: Should be one of follows
> >         "mediatek,mt6323-rtc": for MT6323 PMIC
> > +       "mediatek,mt6358-rtc": for MT6358 PMIC
> > +       "mediatek,mt6358-rtc","mediatek,mt6366-rtc": for MT6366
> > PMIC
> 
> Does not look like in correct order.
> 
> >         "mediatek,mt6397-rtc": for MT6397 PMIC
> >  
> >  Example:
> 
> 
> Best regards,
> Krzysztof

Thanks for yours reminder.

Our rtc owner didn't notice this.

I will correct that in next version.

Thanks,
Allen
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/rtc/rtc-mt6397.txt b/Documentation/devicetree/bindings/rtc/rtc-mt6397.txt
index 55a0c8874c03..5b012d222f5b 100644
--- a/Documentation/devicetree/bindings/rtc/rtc-mt6397.txt
+++ b/Documentation/devicetree/bindings/rtc/rtc-mt6397.txt
@@ -14,6 +14,8 @@  For MediaTek PMIC wrapper bus bindings, see:
 Required properties:
 - compatible: Should be one of follows
        "mediatek,mt6323-rtc": for MT6323 PMIC
+       "mediatek,mt6358-rtc": for MT6358 PMIC
+       "mediatek,mt6358-rtc","mediatek,mt6366-rtc": for MT6366 PMIC
        "mediatek,mt6397-rtc": for MT6397 PMIC
 
 Example: