| Message ID | 20220517101514.21639-3-angelogioacchino.delregno@collabora.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | dt-bindings: arm: MediaTek: Fix clock bindings | expand |
On 17/05/2022 12:15, AngeloGioacchino Del Regno wrote: > This is a clock-controller binding, so it needs #clock-cells, or > it would be of no use: add that to the list of required properties. > > Fixes: f113a51aa2cf ("dt-bindings: ARM: MediaTek: Add new document bindings of MT8186 clock") > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > --- > .../devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml | 1 + If these are clock controllers and new bindings, why they were added to "arm" directory? arm is only for top-level stuff, not for devices. In the future please put your bindings in respective subsystem matching the hardware. Fallback is soc directory, not arm. Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
Il 17/05/22 16:34, Krzysztof Kozlowski ha scritto: > On 17/05/2022 12:15, AngeloGioacchino Del Regno wrote: >> This is a clock-controller binding, so it needs #clock-cells, or >> it would be of no use: add that to the list of required properties. >> >> Fixes: f113a51aa2cf ("dt-bindings: ARM: MediaTek: Add new document bindings of MT8186 clock") >> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> >> --- >> .../devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml | 1 + > > If these are clock controllers and new bindings, why they were added to > "arm" directory? arm is only for top-level stuff, not for devices. > > In the future please put your bindings in respective subsystem matching > the hardware. Fallback is soc directory, not arm. > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Hello Krzysztof, I agree with you about these bindings belonging to the clock directory. Should I add a patch to this series that moves all of the mtxxxx-clock and mtxxxx-sys-clock yaml files to the clock directory? Regards, Angelo
On 18/05/2022 11:24, AngeloGioacchino Del Regno wrote: > Il 17/05/22 16:34, Krzysztof Kozlowski ha scritto: >> On 17/05/2022 12:15, AngeloGioacchino Del Regno wrote: >>> This is a clock-controller binding, so it needs #clock-cells, or >>> it would be of no use: add that to the list of required properties. >>> >>> Fixes: f113a51aa2cf ("dt-bindings: ARM: MediaTek: Add new document bindings of MT8186 clock") >>> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> >>> --- >>> .../devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml | 1 + >> >> If these are clock controllers and new bindings, why they were added to >> "arm" directory? arm is only for top-level stuff, not for devices. >> >> In the future please put your bindings in respective subsystem matching >> the hardware. Fallback is soc directory, not arm. >> >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> > > Hello Krzysztof, > > I agree with you about these bindings belonging to the clock directory. > Should I add a patch to this series that moves all of the mtxxxx-clock > and mtxxxx-sys-clock yaml files to the clock directory? They should not be added there, but no need to shuffle things around... Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml index 371eace6780b..70d7b393140e 100644 --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml @@ -44,6 +44,7 @@ properties: required: - compatible - reg + - '#clock-cells' additionalProperties: false diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-sys-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-sys-clock.yaml index 0886e2e335bb..48ebd2112789 100644 --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-sys-clock.yaml +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-sys-clock.yaml @@ -42,6 +42,7 @@ properties: required: - compatible - reg + - '#clock-cells' additionalProperties: false
This is a clock-controller binding, so it needs #clock-cells, or it would be of no use: add that to the list of required properties. Fixes: f113a51aa2cf ("dt-bindings: ARM: MediaTek: Add new document bindings of MT8186 clock") Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> --- .../devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml | 1 + .../bindings/arm/mediatek/mediatek,mt8186-sys-clock.yaml | 1 + 2 files changed, 2 insertions(+)