diff mbox series

[v2,2/2] dt-bindings: arm: mtk-clocks: Set #clock-cells as required property

Message ID 20220518093631.25491-3-angelogioacchino.delregno@collabora.com (mailing list archive)
State New, archived
Headers show
Series dt-bindings: arm: MediaTek: Fix clock bindings | expand

Commit Message

AngeloGioacchino Del Regno May 18, 2022, 9:36 a.m. UTC
This is a clock-controller binding, so it needs #clock-cells, or
it would be of no use: add that to the list of required properties.

Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 .../devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml  | 1 +
 .../bindings/arm/mediatek/mediatek,mt8186-sys-clock.yaml         | 1 +
 .../devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml  | 1 +
 .../bindings/arm/mediatek/mediatek,mt8192-sys-clock.yaml         | 1 +
 .../devicetree/bindings/arm/mediatek/mediatek,mt8195-clock.yaml  | 1 +
 .../bindings/arm/mediatek/mediatek,mt8195-sys-clock.yaml         | 1 +
 6 files changed, 6 insertions(+)

Comments

Krzysztof Kozlowski May 18, 2022, 11:46 a.m. UTC | #1
On 18/05/2022 11:36, AngeloGioacchino Del Regno wrote:
> This is a clock-controller binding, so it needs #clock-cells, or
> it would be of no use: add that to the list of required properties.
> 
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

These I considered as somehow fixes so I did not ask to remove the Fixes
tag, so also not squashing. It's fine, though...

Best regards,
Krzysztof
AngeloGioacchino Del Regno May 18, 2022, 11:50 a.m. UTC | #2
Il 18/05/22 13:46, Krzysztof Kozlowski ha scritto:
> On 18/05/2022 11:36, AngeloGioacchino Del Regno wrote:
>> This is a clock-controller binding, so it needs #clock-cells, or
>> it would be of no use: add that to the list of required properties.
>>
>> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> These I considered as somehow fixes so I did not ask to remove the Fixes
> tag, so also not squashing. It's fine, though...
> 

I'm sorry Krzysztof, for some reason I was sure that your comments were applicable
on the entire series...

I'll pay more attention next time, and eventually I'll make one more question
when/if needed. I take your last comment as "leave this series as it is", so
I will not send a v3.

Regards,
Angelo
Rob Herring (Arm) May 20, 2022, 10:19 p.m. UTC | #3
On Wed, May 18, 2022 at 11:36:31AM +0200, AngeloGioacchino Del Regno wrote:
> This is a clock-controller binding, so it needs #clock-cells, or
> it would be of no use: add that to the list of required properties.
> 
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  .../devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml  | 1 +
>  .../bindings/arm/mediatek/mediatek,mt8186-sys-clock.yaml         | 1 +
>  .../devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml  | 1 +
>  .../bindings/arm/mediatek/mediatek,mt8192-sys-clock.yaml         | 1 +
>  .../devicetree/bindings/arm/mediatek/mediatek,mt8195-clock.yaml  | 1 +
>  .../bindings/arm/mediatek/mediatek,mt8195-sys-clock.yaml         | 1 +
>  6 files changed, 6 insertions(+)

Acked-by: Rob Herring <robh@kernel.org>

Wasn't there some discussion about moving these to bindings/clocks/? 
Maybe that was another one, it's all a blur...

Rob
Krzysztof Kozlowski May 21, 2022, 2:05 p.m. UTC | #4
On 21/05/2022 00:19, Rob Herring wrote:
> On Wed, May 18, 2022 at 11:36:31AM +0200, AngeloGioacchino Del Regno wrote:
>> This is a clock-controller binding, so it needs #clock-cells, or
>> it would be of no use: add that to the list of required properties.
>>
>> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> ---
>>  .../devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml  | 1 +
>>  .../bindings/arm/mediatek/mediatek,mt8186-sys-clock.yaml         | 1 +
>>  .../devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml  | 1 +
>>  .../bindings/arm/mediatek/mediatek,mt8192-sys-clock.yaml         | 1 +
>>  .../devicetree/bindings/arm/mediatek/mediatek,mt8195-clock.yaml  | 1 +
>>  .../bindings/arm/mediatek/mediatek,mt8195-sys-clock.yaml         | 1 +
>>  6 files changed, 6 insertions(+)
> 
> Acked-by: Rob Herring <robh@kernel.org>
> 
> Wasn't there some discussion about moving these to bindings/clocks/? 
> Maybe that was another one, it's all a blur...

Yes, there was such idea although I am not sure if this is worth by
itself - messes up with the git history.


Best regards,
Krzysztof
Rob Herring (Arm) May 23, 2022, 2:08 p.m. UTC | #5
On Sat, May 21, 2022 at 04:05:01PM +0200, Krzysztof Kozlowski wrote:
> On 21/05/2022 00:19, Rob Herring wrote:
> > On Wed, May 18, 2022 at 11:36:31AM +0200, AngeloGioacchino Del Regno wrote:
> >> This is a clock-controller binding, so it needs #clock-cells, or
> >> it would be of no use: add that to the list of required properties.
> >>
> >> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> >> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >> ---
> >>  .../devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml  | 1 +
> >>  .../bindings/arm/mediatek/mediatek,mt8186-sys-clock.yaml         | 1 +
> >>  .../devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml  | 1 +
> >>  .../bindings/arm/mediatek/mediatek,mt8192-sys-clock.yaml         | 1 +
> >>  .../devicetree/bindings/arm/mediatek/mediatek,mt8195-clock.yaml  | 1 +
> >>  .../bindings/arm/mediatek/mediatek,mt8195-sys-clock.yaml         | 1 +
> >>  6 files changed, 6 insertions(+)
> > 
> > Acked-by: Rob Herring <robh@kernel.org>
> > 
> > Wasn't there some discussion about moving these to bindings/clocks/? 
> > Maybe that was another one, it's all a blur...
> 
> Yes, there was such idea although I am not sure if this is worth by
> itself - messes up with the git history.

There shouldn't be too much history since converting to schema. For just 
a move git is smart enough to see across moves.

Rob
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml
index 371eace6780b..70d7b393140e 100644
--- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml
+++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml
@@ -44,6 +44,7 @@  properties:
 required:
   - compatible
   - reg
+  - '#clock-cells'
 
 additionalProperties: false
 
diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-sys-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-sys-clock.yaml
index 0886e2e335bb..48ebd2112789 100644
--- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-sys-clock.yaml
+++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-sys-clock.yaml
@@ -42,6 +42,7 @@  properties:
 required:
   - compatible
   - reg
+  - '#clock-cells'
 
 additionalProperties: false
 
diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
index bb410b178f33..b61d7635dfdd 100644
--- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
+++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
@@ -46,6 +46,7 @@  properties:
 required:
   - compatible
   - reg
+  - '#clock-cells'
 
 additionalProperties: false
 
diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-sys-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-sys-clock.yaml
index 27f79175c678..580450e94c02 100644
--- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-sys-clock.yaml
+++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-sys-clock.yaml
@@ -35,6 +35,7 @@  properties:
 required:
   - compatible
   - reg
+  - '#clock-cells'
 
 additionalProperties: false
 
diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8195-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8195-clock.yaml
index 0189aa0e34d4..aabd9f0df2de 100644
--- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8195-clock.yaml
+++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8195-clock.yaml
@@ -60,6 +60,7 @@  properties:
 required:
   - compatible
   - reg
+  - '#clock-cells'
 
 additionalProperties: false
 
diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8195-sys-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8195-sys-clock.yaml
index 95b6bdf99936..e2ba37830d4e 100644
--- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8195-sys-clock.yaml
+++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8195-sys-clock.yaml
@@ -43,6 +43,7 @@  properties:
 required:
   - compatible
   - reg
+  - '#clock-cells'
 
 additionalProperties: false