| Message ID | 20220523085923.1430470-2-wenst@chromium.org (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | clk: mediatek: mt8183: Fix GPU/MFG clock rate changing | expand |
Il 23/05/22 10:59, Chen-Yu Tsai ha scritto: > The actual clock feeding into the Mali GPU on the MT8183 is from the > clock gate in the MFGCFG block, not CLK_TOP_MFGPLL_CK from the TOPCKGEN > block, which itself is simply a pass-through placeholder for the MFGPLL > in the APMIXEDSYS block. > > Fix the hardware description with the correct clock reference. > > Fixes: a8168cebf1bc ("arm64: dts: mt8183: Add node for the Mali GPU") > Signed-off-by: Chen-Yu Tsai <wenst@chromium.org> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > --- > arch/arm64/boot/dts/mediatek/mt8183.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi > index 01e650251928..6ced76a60aab 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi > @@ -1368,7 +1368,7 @@ gpu: gpu@13040000 { > <GIC_SPI 278 IRQ_TYPE_LEVEL_LOW>; > interrupt-names = "job", "mmu", "gpu"; > > - clocks = <&topckgen CLK_TOP_MFGPLL_CK>; > + clocks = <&mfgcfg CLK_MFG_BG3D>; > > power-domains = > <&spm MT8183_POWER_DOMAIN_MFG_CORE0>,
diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi index 01e650251928..6ced76a60aab 100644 --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi @@ -1368,7 +1368,7 @@ gpu: gpu@13040000 { <GIC_SPI 278 IRQ_TYPE_LEVEL_LOW>; interrupt-names = "job", "mmu", "gpu"; - clocks = <&topckgen CLK_TOP_MFGPLL_CK>; + clocks = <&mfgcfg CLK_MFG_BG3D>; power-domains = <&spm MT8183_POWER_DOMAIN_MFG_CORE0>,
The actual clock feeding into the Mali GPU on the MT8183 is from the clock gate in the MFGCFG block, not CLK_TOP_MFGPLL_CK from the TOPCKGEN block, which itself is simply a pass-through placeholder for the MFGPLL in the APMIXEDSYS block. Fix the hardware description with the correct clock reference. Fixes: a8168cebf1bc ("arm64: dts: mt8183: Add node for the Mali GPU") Signed-off-by: Chen-Yu Tsai <wenst@chromium.org> --- arch/arm64/boot/dts/mediatek/mt8183.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)