diff mbox series

[09/34] iio: adc: npcm_adc: explicitly add proper header files

Message ID 20220610084545.547700-10-nuno.sa@analog.com (mailing list archive)
State New, archived
Headers show
Series make iio inkern interface firmware agnostic | expand

Commit Message

Nuno Sa June 10, 2022, 8:45 a.m. UTC 
Do not trust the fact that iio.h includes of.h which in turn includes
all the headers we are relying on.

The ultimate goal is to actually drop of.h from iio.h.

Signed-off-by: Nuno Sá <nuno.sa@analog.com>
---
 drivers/iio/adc/npcm_adc.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Jonathan Cameron June 11, 2022, 2:12 p.m. UTC | #1 
On Fri, 10 Jun 2022 10:45:20 +0200
Nuno Sá <nuno.sa@analog.com> wrote:

> Do not trust the fact that iio.h includes of.h which in turn includes
> all the headers we are relying on.
> 
> The ultimate goal is to actually drop of.h from iio.h.
> 
> Signed-off-by: Nuno Sá <nuno.sa@analog.com>

Applied. It's funny, but I'd always assumed module.h included
mod_devicetable.h (though tried never to rely on it).  Turns
out nope, it doesn't :)

Jonathan

> ---
>  drivers/iio/adc/npcm_adc.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/iio/adc/npcm_adc.c b/drivers/iio/adc/npcm_adc.c
> index f7bc0bb7f112..a242e7993476 100644
> --- a/drivers/iio/adc/npcm_adc.c
> +++ b/drivers/iio/adc/npcm_adc.c
> @@ -8,6 +8,7 @@
>  #include <linux/iio/iio.h>
>  #include <linux/interrupt.h>
>  #include <linux/kernel.h>
> +#include <linux/mod_devicetable.h>
>  #include <linux/module.h>
>  #include <linux/platform_device.h>
>  #include <linux/regmap.h>
diff mbox series

Patch

diff --git a/drivers/iio/adc/npcm_adc.c b/drivers/iio/adc/npcm_adc.c
index f7bc0bb7f112..a242e7993476 100644
--- a/drivers/iio/adc/npcm_adc.c
+++ b/drivers/iio/adc/npcm_adc.c
@@ -8,6 +8,7 @@ 
 #include <linux/iio/iio.h>
 #include <linux/interrupt.h>
 #include <linux/kernel.h>
+#include <linux/mod_devicetable.h>
 #include <linux/module.h>
 #include <linux/platform_device.h>
 #include <linux/regmap.h>