From patchwork Tue Jul 26 14:16:52 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: AngeloGioacchino Del Regno X-Patchwork-Id: 12929351 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AE147C00144 for ; Tue, 26 Jul 2022 14:19:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Y7i2uWAntRA9XTKlVzfQ123td1ll1Furv4oVp9E/It0=; b=Ui22EqEh28wXddWanhTB0tUVYN UhM3fcdnqRHyXU5e70O8ofo0m9t+EnHsV9SlpDXFo0bwa8oCZ4qLmKh2EO0THn8onSW9D6URE+dkH vF8cP7mJcD1UPXXQIwud3t7jJ4ilDPnDcL/TRG+AVkUAVWm6MiFZjIyTjpOWkbjpSt180wszVOT1M c9LOhcNWQ6kJOIXD8VlZr8srPAGatvaT4TxVyxcKIoNHqfkYvjKtyxxzQWWzXK9fniqEPx9U0GwCz niFOLVulp5Q5mzMYXu+pY3UgXmipkBjBGecU4st4cePdan7ZFaccTq38PZl6KJqUqdigmMJrRalSV s2bfnilw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oGLP6-0008Oi-Im; Tue, 26 Jul 2022 14:19:20 +0000 Received: from madras.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e5ab]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oGLNT-0007Vo-Q4; Tue, 26 Jul 2022 14:17:41 +0000 Received: from IcarusMOD.eternityproject.eu (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 0A64D6601B27; Tue, 26 Jul 2022 15:17:36 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1658845056; bh=/YuYtrnNwsD9jkmjIALrbGiIMTfJWaxC43e7WbK4aCY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=G0NRuHC3FwUAZ+21sfLzXLOmEjDlMxL2Iu/IQCIi+nmUxt4Q9ZCyhbrD4Tpd7sTBL N6xojx9ZSaCE1/Dv/yrgueuLKvny9iopLc0Xu7UyF0/CV0U+KussNSJ8deNKXNIbbB AQa0nI0/srRuKBKn/zgjbJZQGUddKHThp0OnMlLiyQF1GgVCPg5J0wfWwDXJ9cXms0 xREkQdKsR1jUTlLxKeLTA+Xbj51rI48UUuLr2/4ltItqppeumz7c8aSohm13zAmrRh /rkuQlGT3vKjpB4KJrim2R3qa5dG6Let3t8ygwkdDh7I9cxxfx929oCNb6c3YOV3t3 dNYx+yLXIk1ZA== From: AngeloGioacchino Del Regno To: matthias.bgg@gmail.com Cc: roger.lu@mediatek.com, khilman@baylibre.com, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, nfraprado@collabora.com, kernel@collabora.com, AngeloGioacchino Del Regno Subject: [PATCH 5/6] soc: mediatek: mtk-svs: Use devm variant for dev_pm_opp_of_add_table() Date: Tue, 26 Jul 2022 16:16:52 +0200 Message-Id: <20220726141653.177948-6-angelogioacchino.delregno@collabora.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220726141653.177948-1-angelogioacchino.delregno@collabora.com> References: <20220726141653.177948-1-angelogioacchino.delregno@collabora.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220726_071739_996746_2374AB2F X-CRM114-Status: GOOD ( 10.99 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org In error cases, this driver never calls dev_pm_opp_of_remove_table(): instead of doing that, simple switch to a devm variant, which will automagically do that for us. Fixes: 681a02e95000 ("soc: mediatek: SVS: introduce MTK SVS engine") Signed-off-by: AngeloGioacchino Del Regno --- drivers/soc/mediatek/mtk-svs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/soc/mediatek/mtk-svs.c b/drivers/soc/mediatek/mtk-svs.c index 80d0bab1a045..25b49d8af59a 100644 --- a/drivers/soc/mediatek/mtk-svs.c +++ b/drivers/soc/mediatek/mtk-svs.c @@ -1626,7 +1626,7 @@ static int svs_bank_resource_setup(struct svs_platform *svsp) dev_set_drvdata(svsb->dev, svsp); - ret = dev_pm_opp_of_add_table(svsb->opp_dev); + ret = devm_pm_opp_of_add_table(svsb->opp_dev); if (ret) { dev_err(svsb->dev, "add opp table fail: %d\n", ret); return ret;