| Message ID | 20220815122503.2768-1-allen-kh.cheng@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | dt-bindings: pinctrl: mt8186: Fix 'reg-names' for pinctrl nodes | expand |
On 15/08/2022 15:25, Allen-KH Cheng wrote: > There are 8 GPIO physical address bases in mt8186, corresponding to the > items of 'reg-names' with the pinctrl driver. but the order of New sentences start with capital letter. > 'reg-names' is not correct. The mt8186 pinctrl driver would get the > wrong address, causing the system to restart when regulator initializes > . we ^^^ Something is missing. Sentence looks unfinished, full stop is in new line, next sentence does not start with capital letter. > fix 'reg-names' for pinctrl nodes and the pinctrl-mt8186 example > in bindings. > > Fixes: 338e953f1bd1 ("dt-bindings: pinctrl: mt8186: add pinctrl file and binding document") > Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com> > Signed-off-by: Guodong Liu <guodong.liu@mediatek.com> > --- Best regards, Krzysztof
Hi Krzysztof, On Tue, 2022-08-16 at 10:14 +0300, Krzysztof Kozlowski wrote: > On 15/08/2022 15:25, Allen-KH Cheng wrote: > > There are 8 GPIO physical address bases in mt8186, corresponding to > > the > > items of 'reg-names' with the pinctrl driver. but the order of > > New sentences start with capital letter. > > > 'reg-names' is not correct. The mt8186 pinctrl driver would get the > > wrong address, causing the system to restart when regulator > > initializes > > . we > > ^^^ Something is missing. Sentence looks unfinished, full stop is in > new > line, next sentence does not start with capital letter. > > Thanks for your kind reminder. I'll update in the next version. Best regards, Allen > > fix 'reg-names' for pinctrl nodes and the pinctrl-mt8186 example > > in bindings. > > > > Fixes: 338e953f1bd1 ("dt-bindings: pinctrl: mt8186: add pinctrl > > file and binding document") > > Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com> > > Signed-off-by: Guodong Liu <guodong.liu@mediatek.com> > > --- > > Best regards, > Krzysztof
diff --git a/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8186.yaml b/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8186.yaml index 1eeb885ce0c6..604445e390a7 100644 --- a/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8186.yaml +++ b/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8186.yaml @@ -41,12 +41,12 @@ properties: Gpio base register names. items: - const: iocfg0 - - const: iocfg_bm - - const: iocfg_bl - - const: iocfg_br + - const: iocfg_lt - const: iocfg_lm + - const: iocfg_lb + - const: iocfg_bl - const: iocfg_rb - - const: iocfg_tl + - const: iocfg_rt - const: eint interrupt-controller: true @@ -232,12 +232,12 @@ examples: <0x10002200 0x0200>, <0x10002400 0x0200>, <0x10002600 0x0200>, - <0x10002A00 0x0200>, + <0x10002a00 0x0200>, <0x10002c00 0x0200>, <0x1000b000 0x1000>; - reg-names = "iocfg0", "iocfg_bm", "iocfg_bl", - "iocfg_br", "iocfg_lm", "iocfg_rb", - "iocfg_tl", "eint"; + reg-names = "iocfg0", "iocfg_lt", "iocfg_lm", + "iocfg_lb", "iocfg_bl", "iocfg_rb", + "iocfg_rt", "eint"; gpio-controller; #gpio-cells = <2>; gpio-ranges = <&pio 0 0 185>;
There are 8 GPIO physical address bases in mt8186, corresponding to the items of 'reg-names' with the pinctrl driver. but the order of 'reg-names' is not correct. The mt8186 pinctrl driver would get the wrong address, causing the system to restart when regulator initializes . we fix 'reg-names' for pinctrl nodes and the pinctrl-mt8186 example in bindings. Fixes: 338e953f1bd1 ("dt-bindings: pinctrl: mt8186: add pinctrl file and binding document") Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com> Signed-off-by: Guodong Liu <guodong.liu@mediatek.com> --- .../bindings/pinctrl/pinctrl-mt8186.yaml | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)