| Message ID | 20220820080758.9829-2-arinc.unal@arinc9.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | completely rework mediatek,mt7530 binding | expand |
On 20/08/2022 11:07, Arınç ÜNAL wrote: > Make trivial changes on the binding. > > - Update title to include MT7531 switch. > - Add me as a maintainer. List maintainers in alphabetical order by first > name. > - Add description to compatible strings. > - Stretch descriptions up to the 80 character limit. > - Remove quotes from $ref: "dsa.yaml#". > > Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com> > Reviewed-by: Rob Herring <robh@kernel.org> > --- > .../bindings/net/dsa/mediatek,mt7530.yaml | 36 ++++++++++++------- > 1 file changed, 24 insertions(+), 12 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml > index 17ab6c69ecc7..edf48e917173 100644 > --- a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml > +++ b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml > @@ -4,12 +4,13 @@ > $id: http://devicetree.org/schemas/net/dsa/mediatek,mt7530.yaml# > $schema: http://devicetree.org/meta-schemas/core.yaml# > > -title: Mediatek MT7530 Ethernet switch > +title: Mediatek MT7530 and MT7531 Ethernet Switches > > maintainers: > - - Sean Wang <sean.wang@mediatek.com> > + - Arınç ÜNAL <arinc.unal@arinc9.com> > - Landen Chao <Landen.Chao@mediatek.com> > - DENG Qingfang <dqfext@gmail.com> > + - Sean Wang <sean.wang@mediatek.com> > > description: | > Port 5 of mt7530 and mt7621 switch is muxed between: > @@ -61,10 +62,21 @@ description: | > > properties: > compatible: > - enum: > - - mediatek,mt7530 > - - mediatek,mt7531 > - - mediatek,mt7621 > + oneOf: > + - description: > + Standalone MT7530 and multi-chip module MT7530 in MT7623AI SoC > + items: You have one item, so don't make it a list. Just const:xxxxx Same in other places. Best regards, Krzysztof
On 23.08.2022 13:40, Krzysztof Kozlowski wrote: > On 20/08/2022 11:07, Arınç ÜNAL wrote: >> Make trivial changes on the binding. >> >> - Update title to include MT7531 switch. >> - Add me as a maintainer. List maintainers in alphabetical order by first >> name. >> - Add description to compatible strings. >> - Stretch descriptions up to the 80 character limit. >> - Remove quotes from $ref: "dsa.yaml#". >> >> Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com> >> Reviewed-by: Rob Herring <robh@kernel.org> >> --- >> .../bindings/net/dsa/mediatek,mt7530.yaml | 36 ++++++++++++------- >> 1 file changed, 24 insertions(+), 12 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml >> index 17ab6c69ecc7..edf48e917173 100644 >> --- a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml >> +++ b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml >> @@ -4,12 +4,13 @@ >> $id: http://devicetree.org/schemas/net/dsa/mediatek,mt7530.yaml# >> $schema: http://devicetree.org/meta-schemas/core.yaml# >> >> -title: Mediatek MT7530 Ethernet switch >> +title: Mediatek MT7530 and MT7531 Ethernet Switches >> >> maintainers: >> - - Sean Wang <sean.wang@mediatek.com> >> + - Arınç ÜNAL <arinc.unal@arinc9.com> >> - Landen Chao <Landen.Chao@mediatek.com> >> - DENG Qingfang <dqfext@gmail.com> >> + - Sean Wang <sean.wang@mediatek.com> >> >> description: | >> Port 5 of mt7530 and mt7621 switch is muxed between: >> @@ -61,10 +62,21 @@ description: | >> >> properties: >> compatible: >> - enum: >> - - mediatek,mt7530 >> - - mediatek,mt7531 >> - - mediatek,mt7621 >> + oneOf: >> + - description: >> + Standalone MT7530 and multi-chip module MT7530 in MT7623AI SoC >> + items: > > You have one item, so don't make it a list. Just const:xxxxx > > Same in other places. Will do. Arınç
diff --git a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml index 17ab6c69ecc7..edf48e917173 100644 --- a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml +++ b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml @@ -4,12 +4,13 @@ $id: http://devicetree.org/schemas/net/dsa/mediatek,mt7530.yaml# $schema: http://devicetree.org/meta-schemas/core.yaml# -title: Mediatek MT7530 Ethernet switch +title: Mediatek MT7530 and MT7531 Ethernet Switches maintainers: - - Sean Wang <sean.wang@mediatek.com> + - Arınç ÜNAL <arinc.unal@arinc9.com> - Landen Chao <Landen.Chao@mediatek.com> - DENG Qingfang <dqfext@gmail.com> + - Sean Wang <sean.wang@mediatek.com> description: | Port 5 of mt7530 and mt7621 switch is muxed between: @@ -61,10 +62,21 @@ description: | properties: compatible: - enum: - - mediatek,mt7530 - - mediatek,mt7531 - - mediatek,mt7621 + oneOf: + - description: + Standalone MT7530 and multi-chip module MT7530 in MT7623AI SoC + items: + - const: mediatek,mt7530 + + - description: + Standalone MT7531 + items: + - const: mediatek,mt7531 + + - description: + Multi-chip module MT7530 in MT7621AT, MT7621DAT and MT7621ST SoCs + items: + - const: mediatek,mt7621 reg: maxItems: 1 @@ -79,7 +91,7 @@ properties: gpio-controller: type: boolean description: - if defined, MT7530's LED controller will run on GPIO mode. + If defined, MT7530's LED controller will run on GPIO mode. "#interrupt-cells": const: 1 @@ -92,8 +104,8 @@ properties: io-supply: description: Phandle to the regulator node necessary for the I/O power. - See Documentation/devicetree/bindings/regulator/mt6323-regulator.txt - for details for the regulator setup on these boards. + See Documentation/devicetree/bindings/regulator/mt6323-regulator.txt for + details for the regulator setup on these boards. mediatek,mcm: type: boolean @@ -110,8 +122,8 @@ properties: resets: description: - Phandle pointing to the system reset controller with line index for - the ethsys. + Phandle pointing to the system reset controller with line index for the + ethsys. maxItems: 1 patternProperties: @@ -148,7 +160,7 @@ required: - reg allOf: - - $ref: "dsa.yaml#" + - $ref: dsa.yaml# - if: required: - mediatek,mcm