| Message ID | 20220830063929.13390-2-zheng-yan.chen@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add gamma lut support for mt8195 | expand |
Il 30/08/22 08:39, zheng-yan.chen ha scritto: > mt8195 uses 10bit-to-12bit gamma-LUT, which is not compatible with > current 9bit-to-10bit gamma-LUT. > > This patch thus add constant compatible for mt8195, which means that > mt8195 should only use specified mt8195 gamma driver data. > > Also, delete related compatible from enum, to ensure that > mt8195 will not accidentally get others' gamma driver data and thus > cause fatal error. > > Fixes: a79257bae9bf ("dt-bindings: display: mediatek: add mt8195 SoC binding for vdosys0") > Signed-off-by: zheng-yan.chen <zheng-yan.chen@mediatek.com> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
On 30/08/2022 09:39, zheng-yan.chen wrote: > mt8195 uses 10bit-to-12bit gamma-LUT, which is not compatible with > current 9bit-to-10bit gamma-LUT. > > This patch thus add constant compatible for mt8195, which means that > mt8195 should only use specified mt8195 gamma driver data. > > Also, delete related compatible from enum, to ensure that > mt8195 will not accidentally get others' gamma driver data and thus > cause fatal error. > > Fixes: a79257bae9bf ("dt-bindings: display: mediatek: add mt8195 SoC binding for vdosys0") > Signed-off-by: zheng-yan.chen <zheng-yan.chen@mediatek.com> > --- > .../devicetree/bindings/display/mediatek/mediatek,gamma.yaml | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.yaml > index a89ea0ea7542..fbd7b9664a78 100644 > --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.yaml > +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.yaml > @@ -25,11 +25,12 @@ properties: > - const: mediatek,mt8173-disp-gamma > - items: > - const: mediatek,mt8183-disp-gamma > + - items: > + - const: mediatek,mt8195-disp-gamma This is one item, so not a list. With all such cases this should be dedicated enum. Best regards, Krzysztof
On Tue, 2022-08-30 at 12:10 +0300, Krzysztof Kozlowski wrote: > On 30/08/2022 09:39, zheng-yan.chen wrote: > > mt8195 uses 10bit-to-12bit gamma-LUT, which is not compatible with > > current 9bit-to-10bit gamma-LUT. > > > > This patch thus add constant compatible for mt8195, which means > > that > > mt8195 should only use specified mt8195 gamma driver data. > > > > Also, delete related compatible from enum, to ensure that > > mt8195 will not accidentally get others' gamma driver data and thus > > cause fatal error. > > > > Fixes: a79257bae9bf ("dt-bindings: display: mediatek: add mt8195 > > SoC binding for vdosys0") > > Signed-off-by: zheng-yan.chen <zheng-yan.chen@mediatek.com> > > --- > > .../devicetree/bindings/display/mediatek/mediatek,gamma.yaml | 3 > > ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git > > a/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma > > .yaml > > b/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma > > .yaml > > index a89ea0ea7542..fbd7b9664a78 100644 > > --- > > a/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma > > .yaml > > +++ > > b/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma > > .yaml > > @@ -25,11 +25,12 @@ properties: > > - const: mediatek,mt8173-disp-gamma > > - items: > > - const: mediatek,mt8183-disp-gamma > > + - items: > > + - const: mediatek,mt8195-disp-gamma > > This is one item, so not a list. With all such cases this should be > dedicated enum. > > Best regards, > Krzysztof Hello Krzysztof, Thanks for the review, I will fix it at the next version. Best Regards, Zheng-Yan Chen.
diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.yaml index a89ea0ea7542..fbd7b9664a78 100644 --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.yaml +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.yaml @@ -25,11 +25,12 @@ properties: - const: mediatek,mt8173-disp-gamma - items: - const: mediatek,mt8183-disp-gamma + - items: + - const: mediatek,mt8195-disp-gamma - items: - enum: - mediatek,mt8186-disp-gamma - mediatek,mt8192-disp-gamma - - mediatek,mt8195-disp-gamma - const: mediatek,mt8183-disp-gamma reg:
mt8195 uses 10bit-to-12bit gamma-LUT, which is not compatible with current 9bit-to-10bit gamma-LUT. This patch thus add constant compatible for mt8195, which means that mt8195 should only use specified mt8195 gamma driver data. Also, delete related compatible from enum, to ensure that mt8195 will not accidentally get others' gamma driver data and thus cause fatal error. Fixes: a79257bae9bf ("dt-bindings: display: mediatek: add mt8195 SoC binding for vdosys0") Signed-off-by: zheng-yan.chen <zheng-yan.chen@mediatek.com> --- .../devicetree/bindings/display/mediatek/mediatek,gamma.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)