| Message ID | 20220830063929.13390-4-zheng-yan.chen@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add gamma lut support for mt8195 | expand |
Il 30/08/22 08:39, zheng-yan.chen ha scritto: > Modify gamma compatible for mt8195. > > Fixes: 16590e634f1d ("arm64: dts: mt8195: Add display node for vdosys0") > Signed-off-by: zheng-yan.chen <zheng-yan.chen@mediatek.com> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
On 30/08/2022 09:39, zheng-yan.chen wrote: > Modify gamma compatible for mt8195. Commit should explain why. "What" we all can easily see. > > Fixes: 16590e634f1d ("arm64: dts: mt8195: Add display node for vdosys0") Your patchset is not bisectable and might cause ABI break. I doubt that it matches the criteria of backports, especially that you did not describe here bug being fixed. Drop the tag and explain reasons for ABI break. > Signed-off-by: zheng-yan.chen <zheng-yan.chen@mediatek.com> > --- > arch/arm64/boot/dts/mediatek/mt8195.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi b/arch/arm64/boot/dts/mediatek/mt8195.dtsi > index a50ebb5d145f..d4110f6fac62 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi > @@ -2022,7 +2022,7 @@ > }; > > gamma0: gamma@1c006000 { > - compatible = "mediatek,mt8195-disp-gamma", "mediatek,mt8183-disp-gamma"; > + compatible = "mediatek,mt8195-disp-gamma"; > reg = <0 0x1c006000 0 0x1000>; > interrupts = <GIC_SPI 642 IRQ_TYPE_LEVEL_HIGH 0>; > power-domains = <&spm MT8195_POWER_DOMAIN_VDOSYS0>; Best regards, Krzysztof
On 30/08/2022 10:49, AngeloGioacchino Del Regno wrote: > Il 30/08/22 08:39, zheng-yan.chen ha scritto: >> Modify gamma compatible for mt8195. >> >> Fixes: 16590e634f1d ("arm64: dts: mt8195: Add display node for vdosys0") >> Signed-off-by: zheng-yan.chen <zheng-yan.chen@mediatek.com> > > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Please also perform review on the commit msg and backport status. Best regards, Krzysztof
On Tue, 2022-08-30 at 12:13 +0300, Krzysztof Kozlowski wrote: > > > On 30/08/2022 09:39, zheng-yan.chen wrote: > > Modify gamma compatible for mt8195. > > Commit should explain why. "What" we all can easily see. > > Fixes: 16590e634f1d ("arm64: dts: mt8195: Add display node for > > vdosys0") > Hello Krzysztof, Thanks for the review, I will edit commit message below: Modify gamma compatible for mt8195. This modification is because of that mt8183 gamma driver data is not compatible with mt8195 gamma. Thus, need to delete mt8183 gamma compatible from mt8195 gamma. > Your patchset is not bisectable and might cause ABI break. I doubt > that > it matches the criteria of backports, especially that you did not > describe here bug being fixed. > > Drop the tag and explain reasons for ABI break. > I will drop the tag and add based-on messages below. Base on [1]: [1] arm64: dts: mt8195: Add display node for vdosys0 - https://patchwork.kernel.org/project/linux-mediatek/patch/20220811025813.21492-21-tinghan.shen@mediatek.com/ Best Regards, Zheng-Yan Chen. > > Signed-off-by: zheng-yan.chen <zheng-yan.chen@mediatek.com> > > --- > > arch/arm64/boot/dts/mediatek/mt8195.dtsi | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi > > b/arch/arm64/boot/dts/mediatek/mt8195.dtsi > > index a50ebb5d145f..d4110f6fac62 100644 > > --- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi > > +++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi > > @@ -2022,7 +2022,7 @@ > > }; > > > > gamma0: gamma@1c006000 { > > - compatible = "mediatek,mt8195-disp-gamma", > > "mediatek,mt8183-disp-gamma"; > > + compatible = "mediatek,mt8195-disp-gamma"; > > reg = <0 0x1c006000 0 0x1000>; > > interrupts = <GIC_SPI 642 IRQ_TYPE_LEVEL_HIGH > > 0>; > > power-domains = <&spm > > MT8195_POWER_DOMAIN_VDOSYS0>; > > > Best regards, > Krzysztof
On Tue, 2022-08-30 at 12:14 +0300, Krzysztof Kozlowski wrote: > On 30/08/2022 10:49, AngeloGioacchino Del Regno wrote: > > Il 30/08/22 08:39, zheng-yan.chen ha scritto: > > > Modify gamma compatible for mt8195. > > > > > > Fixes: 16590e634f1d ("arm64: dts: mt8195: Add display node for > > > vdosys0") > > > Signed-off-by: zheng-yan.chen <zheng-yan.chen@mediatek.com> > > > > Reviewed-by: AngeloGioacchino Del Regno < > > angelogioacchino.delregno@collabora.com> > > Please also perform review on the commit msg and backport status. > > Best regards, > Krzysztof Hello Krzysztof, Thanks for the review, I will fix it at the next version. Best Regards, Zheng-Yan Chen.
On 31/08/2022 05:29, zheng-yan.chen wrote: > On Tue, 2022-08-30 at 12:14 +0300, Krzysztof Kozlowski wrote: >> On 30/08/2022 10:49, AngeloGioacchino Del Regno wrote: >>> Il 30/08/22 08:39, zheng-yan.chen ha scritto: >>>> Modify gamma compatible for mt8195. >>>> >>>> Fixes: 16590e634f1d ("arm64: dts: mt8195: Add display node for >>>> vdosys0") >>>> Signed-off-by: zheng-yan.chen <zheng-yan.chen@mediatek.com> >>> >>> Reviewed-by: AngeloGioacchino Del Regno < >>> angelogioacchino.delregno@collabora.com> >> >> Please also perform review on the commit msg and backport status. >> >> Best regards, >> Krzysztof > Hello Krzysztof, > Thanks for the review, > I will fix it at the next version. This was to AngeloGioacchino... Best regards, Krzysztof
Il 31/08/22 08:04, Krzysztof Kozlowski ha scritto: > On 31/08/2022 05:29, zheng-yan.chen wrote: >> On Tue, 2022-08-30 at 12:14 +0300, Krzysztof Kozlowski wrote: >>> On 30/08/2022 10:49, AngeloGioacchino Del Regno wrote: >>>> Il 30/08/22 08:39, zheng-yan.chen ha scritto: >>>>> Modify gamma compatible for mt8195. >>>>> >>>>> Fixes: 16590e634f1d ("arm64: dts: mt8195: Add display node for >>>>> vdosys0") >>>>> Signed-off-by: zheng-yan.chen <zheng-yan.chen@mediatek.com> >>>> >>>> Reviewed-by: AngeloGioacchino Del Regno < >>>> angelogioacchino.delregno@collabora.com> >>> >>> Please also perform review on the commit msg and backport status. >>> Ack. Cheers, Angelo >>> Best regards, >>> Krzysztof >> Hello Krzysztof, >> Thanks for the review, >> I will fix it at the next version. > > This was to AngeloGioacchino... > > Best regards, > Krzysztof
diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi b/arch/arm64/boot/dts/mediatek/mt8195.dtsi index a50ebb5d145f..d4110f6fac62 100644 --- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi @@ -2022,7 +2022,7 @@ }; gamma0: gamma@1c006000 { - compatible = "mediatek,mt8195-disp-gamma", "mediatek,mt8183-disp-gamma"; + compatible = "mediatek,mt8195-disp-gamma"; reg = <0 0x1c006000 0 0x1000>; interrupts = <GIC_SPI 642 IRQ_TYPE_LEVEL_HIGH 0>; power-domains = <&spm MT8195_POWER_DOMAIN_VDOSYS0>;
Modify gamma compatible for mt8195. Fixes: 16590e634f1d ("arm64: dts: mt8195: Add display node for vdosys0") Signed-off-by: zheng-yan.chen <zheng-yan.chen@mediatek.com> --- arch/arm64/boot/dts/mediatek/mt8195.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)