diff mbox series

[v2] dt-bindings: iommu: mediatek: mt8195: Fix max interrupts

Message ID 20220908141529.1478-1-matthias.bgg@kernel.org (mailing list archive)
State New, archived
Headers show
Series [v2] dt-bindings: iommu: mediatek: mt8195: Fix max interrupts | expand

Commit Message

Matthias Brugger Sept. 8, 2022, 2:15 p.m. UTC 
From: Matthias Brugger <mbrugger@suse.com>

The mt8195-iommu-infra has five banks and one interrupt for each.
Reflect that in the binding.

Signed-off-by: Matthias Brugger <mbrugger@suse.com>

---

Changes in v2:
- keep wide constrains for minItems and maxItems
- delete unrealted required: - interrupts
- use minItems for mediatek,mt8195-iommu-infra case

 .../bindings/iommu/mediatek,iommu.yaml         | 18 +++++++++++++++++-
 1 file changed, 17 insertions(+), 1 deletion(-)

Comments

Krzysztof Kozlowski Sept. 8, 2022, 2:17 p.m. UTC | #1 
On 08/09/2022 16:15, matthias.bgg@kernel.org wrote:
> From: Matthias Brugger <mbrugger@suse.com>
> 
> The mt8195-iommu-infra has five banks and one interrupt for each.
> Reflect that in the binding.
> 
> Signed-off-by: Matthias Brugger <mbrugger@suse.com>


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>


Best regards,
Krzysztof
AngeloGioacchino Del Regno Sept. 9, 2022, 7:49 a.m. UTC | #2 
Il 08/09/22 16:15, matthias.bgg@kernel.org ha scritto:
> From: Matthias Brugger <mbrugger@suse.com>
> 
> The mt8195-iommu-infra has five banks and one interrupt for each.
> Reflect that in the binding.
> 
> Signed-off-by: Matthias Brugger <mbrugger@suse.com>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml b/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml
index fee0241b50988..4461dc027d1c4 100644
--- a/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml
+++ b/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml
@@ -91,7 +91,9 @@  properties:
     maxItems: 1
 
   interrupts:
-    maxItems: 1
+    minItems: 1
+    maxItems: 5
+    description: each bank has one dedicated interrupt
 
   clocks:
     items:
@@ -183,6 +185,17 @@  allOf:
       required:
         - mediatek,infracfg
 
+  - if:
+      properties:
+        compatible:
+          contains:
+            const: mediatek,mt8195-iommu-infra
+
+    then:
+      properties:
+        interrupts:
+          minItems: 5
+
   - if: # The IOMMUs don't have larbs.
       not:
         properties:
@@ -191,6 +204,9 @@  allOf:
               const: mediatek,mt8195-iommu-infra
 
     then:
+      properties:
+        interrupts:
+          maxItems: 1
       required:
         - mediatek,larbs