diff mbox series

[08/10] mips: dts: ralink: mt7621: change mt7530 switch address

Message ID 20220914085451.11723-9-arinc.unal@arinc9.com (mailing list archive)
State New, archived
Headers show
Series dt-bindings and mt7621 devicetree changes | expand

Commit Message

Arınç ÜNAL Sept. 14, 2022, 8:54 a.m. UTC
In the case of muxing phy0 of the MT7530 switch, the switch and the phy
will have the same address on the mdio bus, 0. This causes the ethernet
driver to fail since devices on the mdio bus cannot share an address.

Any address can be used for the switch, therefore, change the switch
address to 0x1f.

Suggested-by: Sungbo Eo <mans0n@gorani.run>
Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>
---
 arch/mips/boot/dts/ralink/mt7621.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Sergio Paracuellos Sept. 15, 2022, 5:09 a.m. UTC | #1
On Wed, Sep 14, 2022 at 10:56 AM Arınç ÜNAL <arinc.unal@arinc9.com> wrote:
>
> In the case of muxing phy0 of the MT7530 switch, the switch and the phy
> will have the same address on the mdio bus, 0. This causes the ethernet
> driver to fail since devices on the mdio bus cannot share an address.
>
> Any address can be used for the switch, therefore, change the switch
> address to 0x1f.
>
> Suggested-by: Sungbo Eo <mans0n@gorani.run>
> Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>
> ---
>  arch/mips/boot/dts/ralink/mt7621.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>

Thanks,
    Sergio Paracuellos
diff mbox series

Patch

diff --git a/arch/mips/boot/dts/ralink/mt7621.dtsi b/arch/mips/boot/dts/ralink/mt7621.dtsi
index 50799bb1cc5d..206078bd2284 100644
--- a/arch/mips/boot/dts/ralink/mt7621.dtsi
+++ b/arch/mips/boot/dts/ralink/mt7621.dtsi
@@ -338,9 +338,9 @@  mdio: mdio-bus {
 			#address-cells = <1>;
 			#size-cells = <0>;
 
-			switch0: switch@0 {
+			switch0: switch@1f {
 				compatible = "mediatek,mt7621";
-				reg = <0>;
+				reg = <0x1f>;
 				mediatek,mcm;
 				resets = <&sysc MT7621_RST_MCM>;
 				reset-names = "mcm";