diff mbox series

[v2,4/4] arm64: dts: mediatek: cherry: Add edptx and dptx support

Message ID 20220915094640.5571-5-rex-bc.chen@mediatek.com (mailing list archive)
State New, archived
Headers show
Series Add dp-intf and dp nodes | expand

Commit Message

Rex-BC Chen (陳柏辰) Sept. 15, 2022, 9:46 a.m. UTC
In cherry projects, we use edptx as the internal display interface
and use dptx as the external display interface. To support this, we
need to add more properties.

- Add pinctrls for edptx and dptx.
- Add ports for edptx and dptx.

The port connections for the internal and external display:
dp-intf0 -> edptx -> panel
dp-intf1 -> dptx

Because it lacks port of panel, so we keep empty remote-endpoint for
port1@edptx.

Signed-off-by: Bo-Chen Chen <rex-bc.chen@mediatek.com>
---
 .../boot/dts/mediatek/mt8195-cherry.dtsi      | 68 +++++++++++++++++++
 1 file changed, 68 insertions(+)

Comments

AngeloGioacchino Del Regno Sept. 15, 2022, 10:27 a.m. UTC | #1
Il 15/09/22 11:46, Bo-Chen Chen ha scritto:
> In cherry projects, we use edptx as the internal display interface
> and use dptx as the external display interface. To support this, we
> need to add more properties.
> 
> - Add pinctrls for edptx and dptx.
> - Add ports for edptx and dptx.
> 
> The port connections for the internal and external display:
> dp-intf0 -> edptx -> panel
> dp-intf1 -> dptx
> 
> Because it lacks port of panel, so we keep empty remote-endpoint for
> port1@edptx.

Better wording:

The eDP TX endpoint is kept empty for now, as the panel addition will come
in a later commit.

> 
> Signed-off-by: Bo-Chen Chen <rex-bc.chen@mediatek.com>

...after which:

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi b/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi
index 303dc32c64dc..560103e29017 100644
--- a/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi
@@ -125,6 +125,7 @@ 
 
 	port {
 		dp_intf0_out: endpoint {
+			remote-endpoint = <&edp_in>;
 		};
 	};
 };
@@ -134,6 +135,59 @@ 
 
 	port {
 		dp_intf1_out: endpoint {
+			remote-endpoint = <&dptx_in>;
+		};
+	};
+};
+
+&edp_tx {
+	status = "okay";
+
+	pinctrl-names = "default";
+	pinctrl-0 = <&edptx_pins_default>;
+
+	ports {
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		port@0 {
+			reg = <0>;
+			edp_in: endpoint {
+				remote-endpoint = <&dp_intf0_out>;
+			};
+		};
+
+		port@1 {
+			reg = <1>;
+			edp_out: endpoint {
+				data-lanes = <0 1 2 3>;
+			};
+		};
+	};
+};
+
+&dp_tx {
+	status = "okay";
+
+	pinctrl-names = "default";
+	pinctrl-0 = <&dptx_pin>;
+
+	ports {
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		port@0 {
+			reg = <0>;
+			dptx_in: endpoint {
+				remote-endpoint = <&dp_intf1_out>;
+			};
+		};
+
+		port@1 {
+			reg = <1>;
+			dptx_out: endpoint {
+				data-lanes = <0 1 2 3>;
+			};
 		};
 	};
 };
@@ -497,6 +551,20 @@ 
 		};
 	};
 
+	edptx_pins_default: edptx-default-pins {
+		pins-cmd-dat {
+			pinmux = <PINMUX_GPIO7__FUNC_EDP_TX_HPD>;
+			bias-pull-up;
+		};
+	};
+
+	dptx_pin: dptx-default-pins {
+		pins-cmd-dat {
+			pinmux = <PINMUX_GPIO18__FUNC_DP_TX_HPD>;
+			bias-pull-up;
+		};
+	};
+
 	i2c0_pins: i2c0-default-pins {
 		pins-bus {
 			pinmux = <PINMUX_GPIO8__FUNC_SDA0>,