| Message ID | 20220919080410.11270-3-jianguo.zhang@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Mediatek ethernet patchs for mt8188 | expand |
On 19/09/2022 10:04, Jianguo Zhang wrote: > Add binding document for the ethernet on mt8188 > > Signed-off-by: Jianguo Zhang <jianguo.zhang@mediatek.com> > --- > Documentation/devicetree/bindings/net/mediatek-dwmac.yaml | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml b/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml > index 61b2fb9e141b..b7d4f956f92e 100644 > --- a/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml > +++ b/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml > @@ -20,6 +20,7 @@ select: > enum: > - mediatek,mt2712-gmac > - mediatek,mt8195-gmac > + - mediatek,mt8188-gmac Won't be needed after comment below. > required: > - compatible > > @@ -36,6 +37,7 @@ properties: > - items: > - enum: > - mediatek,mt8195-gmac > + - mediatek,mt8188-gmac That's not what your driver change is saying. They are the same or compatible according to your patch #1. > - const: snps,dwmac-5.10a Best regards, Krzysztof
On Mon, 19 Sep 2022 16:04:10 +0800, Jianguo Zhang wrote: > Add binding document for the ethernet on mt8188 > > Signed-off-by: Jianguo Zhang <jianguo.zhang@mediatek.com> > --- > Documentation/devicetree/bindings/net/mediatek-dwmac.yaml | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > Running 'make dtbs_check' with the schema in this patch gives the following warnings. Consider if they are expected or the schema is incorrect. These may not be new warnings. Note that it is not yet a requirement to have 0 warnings for dtbs_check. This will change in the future. Full log is available here: https://patchwork.ozlabs.org/patch/ ethernet@1101c000: Unevaluated properties are not allowed ('clk_csr' was unexpected) arch/arm64/boot/dts/mediatek/mt2712-evb.dtb
Dear Krzysztof,
Thanks for your comment.
On Mon, 2022-09-19 at 18:24 +0200, Krzysztof Kozlowski wrote:
> 'clk_csr'
'clk_csr' properity is parsed in driver, but it is not documented in
bingings for now. We will push a patch to describe 'clk_csr' in
snps,dwmac.yaml file in next version patches.
BRS
Jianguo
diff --git a/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml b/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml index 61b2fb9e141b..b7d4f956f92e 100644 --- a/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml +++ b/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml @@ -20,6 +20,7 @@ select: enum: - mediatek,mt2712-gmac - mediatek,mt8195-gmac + - mediatek,mt8188-gmac required: - compatible @@ -36,6 +37,7 @@ properties: - items: - enum: - mediatek,mt8195-gmac + - mediatek,mt8188-gmac - const: snps,dwmac-5.10a clocks: @@ -74,7 +76,7 @@ properties: or will round down. Range 0~31*170. For MT2712 RMII/MII interface, Allowed value need to be a multiple of 550, or will round down. Range 0~31*550. - For MT8195 RGMII/RMII/MII interface, Allowed value need to be a multiple of 290, + For MT8195/MT8188 RGMII/RMII/MII interface, Allowed value need to be a multiple of 290, or will round down. Range 0~31*290. mediatek,rx-delay-ps: @@ -84,7 +86,7 @@ properties: or will round down. Range 0~31*170. For MT2712 RMII/MII interface, Allowed value need to be a multiple of 550, or will round down. Range 0~31*550. - For MT8195 RGMII/RMII/MII interface, Allowed value need to be a multiple + For MT8195/MT8188 RGMII/RMII/MII interface, Allowed value need to be a multiple of 290, or will round down. Range 0~31*290. mediatek,rmii-rxc:
Add binding document for the ethernet on mt8188 Signed-off-by: Jianguo Zhang <jianguo.zhang@mediatek.com> --- Documentation/devicetree/bindings/net/mediatek-dwmac.yaml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)