diff mbox series

[2/5] mt76: Remove unused inline function mt76_wcid_mask_test()

Message ID 20220921090455.752011-3-cuigaosheng1@huawei.com (mailing list archive)
State New, archived
Headers show
Series Remove useless inline functions from net | expand

Commit Message

Gaosheng Cui Sept. 21, 2022, 9:04 a.m. UTC
All uses of mt76_wcid_mask_test() have
been removed since commit 8950a62f19c9 ("mt76: get rid of
mt76_wcid_hw routine"), so remove it.

Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
---
 drivers/net/wireless/mediatek/mt76/util.h | 6 ------
 1 file changed, 6 deletions(-)

Comments

Jakub Kicinski Sept. 21, 2022, 1:11 p.m. UTC | #1
On Wed, 21 Sep 2022 17:04:52 +0800 Gaosheng Cui wrote:
> All uses of mt76_wcid_mask_test() have
> been removed since commit 8950a62f19c9 ("mt76: get rid of
> mt76_wcid_hw routine"), so remove it.

This should go via the wireless tree, please take it out of this series
and send it to linux-wireless separately.
Jeff Johnson Sept. 21, 2022, 3:07 p.m. UTC | #2
On 9/21/2022 6:11 AM, Jakub Kicinski wrote:
> On Wed, 21 Sep 2022 17:04:52 +0800 Gaosheng Cui wrote:
>> All uses of mt76_wcid_mask_test() have
>> been removed since commit 8950a62f19c9 ("mt76: get rid of
>> mt76_wcid_hw routine"), so remove it.
> 
> This should go via the wireless tree, please take it out of this series
> and send it to linux-wireless separately.

And when you do that add wifi: prefix to the subject
Gaosheng Cui Sept. 22, 2022, 8:45 a.m. UTC | #3
> On 9/21/2022 6:11 AM, Jakub Kicinski wrote:
>> On Wed, 21 Sep 2022 17:04:52 +0800 Gaosheng Cui wrote:
>>> All uses of mt76_wcid_mask_test() have
>>> been removed since commit 8950a62f19c9 ("mt76: get rid of
>>> mt76_wcid_hw routine"), so remove it.
>>
>> This should go via the wireless tree, please take it out of this series
>> and send it to linux-wireless separately.
>
> And when you do that add wifi: prefix to the subject
> .

Thanks for taking time to review this patch, I have made a patch v2 and 
submitted it.

link: 
https://lore.kernel.org/netdev/20220922074711.1408385-1-cuigaosheng1@huawei.com/
diff mbox series

Patch

diff --git a/drivers/net/wireless/mediatek/mt76/util.h b/drivers/net/wireless/mediatek/mt76/util.h
index 49c52d781f40..260965dde94c 100644
--- a/drivers/net/wireless/mediatek/mt76/util.h
+++ b/drivers/net/wireless/mediatek/mt76/util.h
@@ -29,12 +29,6 @@  enum {
 
 int mt76_wcid_alloc(u32 *mask, int size);
 
-static inline bool
-mt76_wcid_mask_test(u32 *mask, int idx)
-{
-	return mask[idx / 32] & BIT(idx % 32);
-}
-
 static inline void
 mt76_wcid_mask_set(u32 *mask, int idx)
 {