diff mbox series

dt-bindings: display: mediatek: dpi: Add compatible for MediaTek MT8188

Message ID 20220923014227.6566-1-liangxu.xu@mediatek.com (mailing list archive)
State New, archived
Headers show
Series dt-bindings: display: mediatek: dpi: Add compatible for MediaTek MT8188 | expand

Commit Message

liangxu.xu Sept. 23, 2022, 1:42 a.m. UTC 
From: liangxu xu <liangxu.xu@mediatek.com>

Add dt-binding documentation of dpi for MediaTek MT8188 SoC.

Signed-off-by: liangxu xu <liangxu.xu@mediatek.com>
---
 .../devicetree/bindings/display/mediatek/mediatek,dpi.yaml       | 1 +
 1 file changed, 1 insertion(+)

Comments

Krzysztof Kozlowski Sept. 23, 2022, 11:16 a.m. UTC | #1 
On 23/09/2022 03:42, liangxu.xu@mediatek.com wrote:
> From: liangxu xu <liangxu.xu@mediatek.com>
> 
> Add dt-binding documentation of dpi for MediaTek MT8188 SoC.
> 
> Signed-off-by: liangxu xu <liangxu.xu@mediatek.com>

Where is the DTS? Where are driver changes?

Best regards,
Krzysztof
liangxu.xu Sept. 26, 2022, 12:12 p.m. UTC | #2 
On Mon, 2022-09-26 at 08:26 +0200, Krzysztof Kozlowski wrote:
> On 26/09/2022 04:53, liangxu.xu wrote:
> > On Fri, 2022-09-23 at 13:16 +0200, Krzysztof Kozlowski wrote:
> > > On 23/09/2022 03:42, liangxu.xu@mediatek.com wrote:
> > > > From: liangxu xu <liangxu.xu@mediatek.com>
> > > > 
> > > > Add dt-binding documentation of dpi for MediaTek MT8188 SoC.
> > > > 
> > > > Signed-off-by: liangxu xu <liangxu.xu@mediatek.com>
> > > 
> > > Where is the DTS? Where are driver changes?
> > > 
> > > Best regards,
> > > Krzysztof
> > > 
> > 
> > Hi Krzysztof:
> > 
> > If you want to see the synchronous changes of dts and binding
> > files,
> > then I will attach this binding file changes when sending dts
> > later.
> 
> Keep discussions public. You submit a lot of unused compatibles. I
> want
> users to come with them.
> 
> > 
> > The driver change of mt8188 reuses that of mt8195. The driver link
> > is
> > as follows:
> > 
> > 
https://urldefense.com/v3/__https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/gpu/drm/mediatek/mtk_dpi.c?id=48f4230642ee32a97ddf4be492838ce96089f040__;!!CTRNKA9wMg0ARbw!1Rd4E1huTfB_u1FjLXMIKlqMciGL24xsYInu1vg1z9c026cL0PiITklArLfwrMsi3x4$
> >  
> 
> Driver does not support that compa
> > 
> > Best Regards,
> > LiangXu
> > 
> 
> Best regards,
> Krzysztof


Hi Krzysztof:

Can I modify it to the following form:
properties:
  compatible:
    oneOf:
      - enum:
        - mediatek,mt2701-dpi
        - mediatek,mt7623-dpi
        - mediatek,mt8173-dpi
        - mediatek,mt8183-dpi
        - mediatek,mt8186-dpi
        - mediatek,mt8192-dpi
        - mediatek,mt8195-dp-intf
      - items:
          - enum:
              - mediatek,mt8188-dp-intf
          - const: mediatek,mt8195-dp-intf

This means that mt8188 reuses mt8195, so there is no need to add
compatible to the driver.

Best Regards,
LiangXu
>
Krzysztof Kozlowski Sept. 26, 2022, 12:53 p.m. UTC | #3 
On 26/09/2022 14:12, liangxu.xu wrote:
> 
> Can I modify it to the following form:
> properties:
>   compatible:
>     oneOf:
>       - enum:
>         - mediatek,mt2701-dpi
>         - mediatek,mt7623-dpi
>         - mediatek,mt8173-dpi
>         - mediatek,mt8183-dpi
>         - mediatek,mt8186-dpi
>         - mediatek,mt8192-dpi
>         - mediatek,mt8195-dp-intf
>       - items:
>           - enum:
>               - mediatek,mt8188-dp-intf
>           - const: mediatek,mt8195-dp-intf
> 
> This means that mt8188 reuses mt8195, so there is no need to add
> compatible to the driver.

I am now confused. You send some bindings which do not match DTS and driver?

This has to stop... please post the bindings with the user - DTS and
optionally driver.

Best regards,
Krzysztof
liangxu.xu Sept. 27, 2022, 6:31 a.m. UTC | #4 
On Mon, 2022-09-26 at 14:53 +0200, Krzysztof Kozlowski wrote:
> On 26/09/2022 14:12, liangxu.xu wrote:
> > 
> > Can I modify it to the following form:
> > properties:
> >   compatible:
> >     oneOf:
> >       - enum:
> >         - mediatek,mt2701-dpi
> >         - mediatek,mt7623-dpi
> >         - mediatek,mt8173-dpi
> >         - mediatek,mt8183-dpi
> >         - mediatek,mt8186-dpi
> >         - mediatek,mt8192-dpi
> >         - mediatek,mt8195-dp-intf
> >       - items:
> >           - enum:
> >               - mediatek,mt8188-dp-intf
> >           - const: mediatek,mt8195-dp-intf
> > 
> > This means that mt8188 reuses mt8195, so there is no need to add
> > compatible to the driver.
> 
> I am now confused. You send some bindings which do not match DTS and
> driver?
> 
> This has to stop... please post the bindings with the user - DTS and
> optionally driver.
> 
> Best regards,
> Krzysztof
> 

Hi Krzysztof:

I'm very sorry that my patch made you confused, please ignore this
patch. I will wait for the patch of mt8188 dts to be ready and send it
together. In the later mt8188 dts, I will reuse the compatible of
mt8195.

Best Regards,
LiangXu
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml
index 5bb23e97cf33..d976380801e3 100644
--- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml
+++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml
@@ -23,6 +23,7 @@  properties:
       - mediatek,mt8173-dpi
       - mediatek,mt8183-dpi
       - mediatek,mt8186-dpi
+      - mediatek,mt8188-dp-intf
       - mediatek,mt8192-dpi
       - mediatek,mt8195-dp-intf