| Message ID | 20220923052828.16581-3-jianguo.zhang@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Mediatek ethernet patches for mt8188 | expand |
On 23/09/2022 07:28, Jianguo Zhang wrote: > The clk_csr property is parsed in driver for generating MDC clock > with correct frequency. A warning('clk_csr' was unexpeted) is reported > when runing 'make_dtbs_check' because the clk_csr property > has been not documented in the binding file. Your subject is not accurate anymore. Maybe mention that instead of existing clk_csr, you add a different property. With commit msg fixes: Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
Dear Krzysztof, Thanks for your comment. On Fri, 2022-09-23 at 20:11 +0200, Krzysztof Kozlowski wrote: > On 23/09/2022 07:28, Jianguo Zhang wrote: > > The clk_csr property is parsed in driver for generating MDC clock > > with correct frequency. A warning('clk_csr' was unexpeted) is > > reported > > when runing 'make_dtbs_check' because the clk_csr property > > has been not documented in the binding file. > > Your subject is not accurate anymore. Maybe mention that instead of > existing clk_csr, you add a different property. > > With commit msg fixes: > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > We will fix commit message in next version patches. > Best regards, > Krzysztof > BRS Jianguo
diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml index 491597c02edf..4d5a56661322 100644 --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml @@ -288,6 +288,11 @@ properties: is supported. For example, this is used in case of SGMII and MAC2MAC connection. + snps,clk-csr: + $ref: /schemas/types.yaml#/definitions/uint32 + description: + Frequency division factor for MDC clock. + mdio: $ref: mdio.yaml# unevaluatedProperties: false
The clk_csr property is parsed in driver for generating MDC clock with correct frequency. A warning('clk_csr' was unexpeted) is reported when runing 'make_dtbs_check' because the clk_csr property has been not documented in the binding file. Signed-off-by: Jianguo Zhang <jianguo.zhang@mediatek.com> --- Documentation/devicetree/bindings/net/snps,dwmac.yaml | 5 +++++ 1 file changed, 5 insertions(+)