| Message ID | 20221025072837.16591-3-linux@fw-web.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | rework mtk pcie-gen3 bindings and support mt7986 | expand |
Il 25/10/22 09:28, Frank Wunderlich ha scritto: > From: Frank Wunderlich <frank-w@public-files.de> > > Add compatible string and clock-definition for mt7986. It needs 4 clocks > for PCIe, define them in binding. > > Signed-off-by: Frank Wunderlich <frank-w@public-files.de> > --- > v2: > - squashed patch 2+3 (compatible and clock definition) > --- > .../bindings/pci/mediatek-pcie-gen3.yaml | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml > index 98d3f0f1cd76..57d0e84253e9 100644 > --- a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml > +++ b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml > @@ -48,6 +48,7 @@ properties: > oneOf: > - items: > - enum: > + - mediatek,mt7986-pcie > - mediatek,mt8188-pcie > - mediatek,mt8195-pcie > - const: mediatek,mt8192-pcie > @@ -78,9 +79,11 @@ properties: > - const: mac > > clocks: > + minItems: 4 > maxItems: 6 I'm not sure that this is really correct. If you have a list of items (const or description, doesn't matter), you don't have to specify maxItems, as it is implicitly equal to the number of items. Also, specifying minItems means that you're "setting" one or more items as optional. It looks like you're specifying a specific and definite list of items for both clocks and clock-names... and for all of the supported SoCs, so, I don't think that having {min,max}Items globally specified on clocks, clock-names make any kind of sense. .....but I'd like for someone else to give an opinion on this as well. Krzysztof, please? Cheers, Angelo > > clock-names: > + minItems: 4 > maxItems: 6 > > assigned-clocks: > @@ -161,6 +164,20 @@ allOf: > - const: tl_32k > - const: peri_26m > - const: peri_mem > + - if: > + properties: > + compatible: > + contains: > + enum: > + - mediatek,mt7986-pcie > + then: > + properties: > + clock-names: > + items: > + - const: pl_250m > + - const: tl_26m > + - const: peri_26m > + - const: top_133m > > unevaluatedProperties: false > >
On Tue, Oct 25, 2022 at 01:10:56PM +0200, AngeloGioacchino Del Regno wrote: > Il 25/10/22 09:28, Frank Wunderlich ha scritto: > > From: Frank Wunderlich <frank-w@public-files.de> > > > > Add compatible string and clock-definition for mt7986. It needs 4 clocks > > for PCIe, define them in binding. > > > > Signed-off-by: Frank Wunderlich <frank-w@public-files.de> > > --- > > v2: > > - squashed patch 2+3 (compatible and clock definition) > > --- > > .../bindings/pci/mediatek-pcie-gen3.yaml | 17 +++++++++++++++++ > > 1 file changed, 17 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml > > index 98d3f0f1cd76..57d0e84253e9 100644 > > --- a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml > > +++ b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml > > @@ -48,6 +48,7 @@ properties: > > oneOf: > > - items: > > - enum: > > + - mediatek,mt7986-pcie > > - mediatek,mt8188-pcie > > - mediatek,mt8195-pcie > > - const: mediatek,mt8192-pcie > > @@ -78,9 +79,11 @@ properties: > > - const: mac > > clocks: > > + minItems: 4 > > maxItems: 6 > > I'm not sure that this is really correct. > If you have a list of items (const or description, doesn't matter), you don't have > to specify maxItems, as it is implicitly equal to the number of items. > Also, specifying minItems means that you're "setting" one or more items as > optional. > > It looks like you're specifying a specific and definite list of items for both > clocks and clock-names... and for all of the supported SoCs, so, I don't think > that having {min,max}Items globally specified on clocks, clock-names make any > kind of sense. > > .....but I'd like for someone else to give an opinion on this as well. It does make sense. Globally, we have the full range of possible clocks and then the if/then schemas further restrict it. Rob
On Tue, 25 Oct 2022 09:28:37 +0200, Frank Wunderlich wrote: > From: Frank Wunderlich <frank-w@public-files.de> > > Add compatible string and clock-definition for mt7986. It needs 4 clocks > for PCIe, define them in binding. > > Signed-off-by: Frank Wunderlich <frank-w@public-files.de> > --- > v2: > - squashed patch 2+3 (compatible and clock definition) > --- > .../bindings/pci/mediatek-pcie-gen3.yaml | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > Reviewed-by: Rob Herring <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml index 98d3f0f1cd76..57d0e84253e9 100644 --- a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml +++ b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml @@ -48,6 +48,7 @@ properties: oneOf: - items: - enum: + - mediatek,mt7986-pcie - mediatek,mt8188-pcie - mediatek,mt8195-pcie - const: mediatek,mt8192-pcie @@ -78,9 +79,11 @@ properties: - const: mac clocks: + minItems: 4 maxItems: 6 clock-names: + minItems: 4 maxItems: 6 assigned-clocks: @@ -161,6 +164,20 @@ allOf: - const: tl_32k - const: peri_26m - const: peri_mem + - if: + properties: + compatible: + contains: + enum: + - mediatek,mt7986-pcie + then: + properties: + clock-names: + items: + - const: pl_250m + - const: tl_26m + - const: peri_26m + - const: top_133m unevaluatedProperties: false