diff mbox series

[1/2] ASoC: mediatek: mt8183-da7219: Register to module device table

Message ID 20221104212409.603970-1-nfraprado@collabora.com (mailing list archive)
State New, archived
Headers show
Series [1/2] ASoC: mediatek: mt8183-da7219: Register to module device table | expand

Commit Message

Nícolas F. R. A. Prado Nov. 4, 2022, 9:24 p.m. UTC
Register the compatibles for this module on the module device table so
it can be automatically loaded when a matching device is found on the
system.

Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>

---

 sound/soc/mediatek/mt8183/mt8183-da7219-max98357.c | 1 +
 1 file changed, 1 insertion(+)

Comments

AngeloGioacchino Del Regno Nov. 7, 2022, 9:06 a.m. UTC | #1
Il 04/11/22 22:24, Nícolas F. R. A. Prado ha scritto:
> Register the compatibles for this module on the module device table so
> it can be automatically loaded when a matching device is found on the
> system.
> 
> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
> 

Hello Nícolas,
I agree but.... can you please do the same for 8192, 8195, 8186?

Getting them all in one series would make absolute sense... :-)

in the meanwhile, for this one:

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

> ---
> 
>   sound/soc/mediatek/mt8183/mt8183-da7219-max98357.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/sound/soc/mediatek/mt8183/mt8183-da7219-max98357.c b/sound/soc/mediatek/mt8183/mt8183-da7219-max98357.c
> index 9f22d3939818..0e572fe28c58 100644
> --- a/sound/soc/mediatek/mt8183/mt8183-da7219-max98357.c
> +++ b/sound/soc/mediatek/mt8183/mt8183-da7219-max98357.c
> @@ -842,6 +842,7 @@ static const struct of_device_id mt8183_da7219_max98357_dt_match[] = {
>   	},
>   	{}
>   };
> +MODULE_DEVICE_TABLE(of, mt8183_da7219_max98357_dt_match);
>   #endif
>   
>   static struct platform_driver mt8183_da7219_max98357_driver = {
Nícolas F. R. A. Prado Nov. 7, 2022, 2:19 p.m. UTC | #2
On Mon, Nov 07, 2022 at 10:06:51AM +0100, AngeloGioacchino Del Regno wrote:
> Il 04/11/22 22:24, Nícolas F. R. A. Prado ha scritto:
> > Register the compatibles for this module on the module device table so
> > it can be automatically loaded when a matching device is found on the
> > system.
> > 
> > Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
> > 
> 
> Hello Nícolas,
> I agree but.... can you please do the same for 8192, 8195, 8186?
> 
> Getting them all in one series would make absolute sense... :-)

Yes, I was planning to do that in a following series, to avoid extra churn on
all SoCs in case some change was needed. But perhaps I was being too careful, I
can add them here for v2.

Thanks,
Nícolas
Mark Brown Nov. 10, 2022, 5:55 p.m. UTC | #3
On Fri, 4 Nov 2022 17:24:07 -0400, Nícolas F. R. A. Prado wrote:
> Register the compatibles for this module on the module device table so
> it can be automatically loaded when a matching device is found on the
> system.
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/2] ASoC: mediatek: mt8183-da7219: Register to module device table
      commit: b5e004b0e5b57d14ac7804875878cdfdb31c9288
[2/2] ASoC: mediatek: mt8183-mt6358: Register to module device table
      commit: bc63a806acdcfca201c68c820731d74185118789

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark
diff mbox series

Patch

diff --git a/sound/soc/mediatek/mt8183/mt8183-da7219-max98357.c b/sound/soc/mediatek/mt8183/mt8183-da7219-max98357.c
index 9f22d3939818..0e572fe28c58 100644
--- a/sound/soc/mediatek/mt8183/mt8183-da7219-max98357.c
+++ b/sound/soc/mediatek/mt8183/mt8183-da7219-max98357.c
@@ -842,6 +842,7 @@  static const struct of_device_id mt8183_da7219_max98357_dt_match[] = {
 	},
 	{}
 };
+MODULE_DEVICE_TABLE(of, mt8183_da7219_max98357_dt_match);
 #endif
 
 static struct platform_driver mt8183_da7219_max98357_driver = {