| Message ID | 20230220-display-v1-14-45cbc68e188b@baylibre.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add display support for the MT8365-EVK board. | expand |
On 09/03/2023 15:23, Alexandre Mergnat wrote: > According to the mtk-mutex.c driver and the SoC DTS, the clock isn't > required to work properly for some of MTK SoC. Improve the clock > requirement by adding a condition which is function to the compatible. > > Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com> Applied, thanks. Now I think we can get rid of the no_clk variable in struct mtk_mutex_data, as this should be mandated by the device-tree. Regards, Matthias > --- > .../bindings/soc/mediatek/mediatek,mutex.yaml | 20 +++++++++++++++++++- > 1 file changed, 19 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex.yaml b/Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex.yaml > index 9241e5fc7cff..ca0ca549257d 100644 > --- a/Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex.yaml > +++ b/Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex.yaml > @@ -69,12 +69,30 @@ properties: > 4 arguments defined in this property. Each GCE subsys id is mapping to > a client defined in the header include/dt-bindings/gce/<chip>-gce.h. > > +allOf: > + - if: > + properties: > + compatible: > + contains: > + enum: > + - mediatek,mt2701-disp-mutex > + - mediatek,mt2712-disp-mutex > + - mediatek,mt6795-disp-mutex > + - mediatek,mt8173-disp-mutex > + - mediatek,mt8186-disp-mutex > + - mediatek,mt8186-mdp3-mutex > + - mediatek,mt8192-disp-mutex > + - mediatek,mt8195-disp-mutex > + then: > + required: > + - clocks > + > + > required: > - compatible > - reg > - interrupts > - power-domains > - - clocks > > additionalProperties: false > >
diff --git a/Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex.yaml b/Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex.yaml index 9241e5fc7cff..ca0ca549257d 100644 --- a/Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex.yaml +++ b/Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex.yaml @@ -69,12 +69,30 @@ properties: 4 arguments defined in this property. Each GCE subsys id is mapping to a client defined in the header include/dt-bindings/gce/<chip>-gce.h. +allOf: + - if: + properties: + compatible: + contains: + enum: + - mediatek,mt2701-disp-mutex + - mediatek,mt2712-disp-mutex + - mediatek,mt6795-disp-mutex + - mediatek,mt8173-disp-mutex + - mediatek,mt8186-disp-mutex + - mediatek,mt8186-mdp3-mutex + - mediatek,mt8192-disp-mutex + - mediatek,mt8195-disp-mutex + then: + required: + - clocks + + required: - compatible - reg - interrupts - power-domains - - clocks additionalProperties: false
According to the mtk-mutex.c driver and the SoC DTS, the clock isn't required to work properly for some of MTK SoC. Improve the clock requirement by adding a condition which is function to the compatible. Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com> --- .../bindings/soc/mediatek/mediatek,mutex.yaml | 20 +++++++++++++++++++- 1 file changed, 19 insertions(+), 1 deletion(-)