[v4] dt-bindings: display: mediatek: clean unnecessary item

Commit Message

Alexandre Mergnat March 7, 2023, 10:07 a.m. UTC

The item which have the mediatek,mt8192-disp-ccorr as const compatible
already exist above. Merge all compatibles which have the same fallback
under the same item.

Acked-by: Krzysztof Kozlowski <[e-mail]>
Signed-off-by: Alexandre Mergnat <[e-mail]>
---
Fix MTK color correction binding

The fallback compatible has been duplicated in the 137272ef1b0f commit.

To: Chun-Kuang Hu <[e-mail]>
To: Philipp Zabel <[e-mail]>
To: David Airlie <[e-mail]>
To: Daniel Vetter <[e-mail]>
To: Rob Herring <[e-mail]>
To: Krzysztof Kozlowski <[e-mail]>
To: Matthias Brugger <[e-mail]>
To: AngeloGioacchino Del Regno <[e-mail]>
To: Allen-KH Cheng <[e-mail]>
Cc: Rob Herring <[e-mail]>
Cc: [e-mail]
Cc: [e-mail]
Cc: [e-mail]
Cc: [e-mail]
Cc: [e-mail]
---
Changes in v4:
- Reword commit title and message.
- Link to v3: https://lore.kernel.org/r/[e-mail]

Changes in v3:
- Re-order compatible.
- Link to v2: https://lore.kernel.org/r/[e-mail]

Changes in v2:
- Fix commit title.
- Link to v1: https://lore.kernel.org/r/[e-mail]
---
 .../devicetree/bindings/display/mediatek/mediatek,ccorr.yaml         | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)


---
base-commit: add072536971d7ce891fde3cdbf68c55e7cfa95a
change-id: 20230306-ccorr-binding-fix-718c6d725088

Best regards,

Comments

AngeloGioacchino Del Regno March 7, 2023, 10:17 a.m. UTC | #1

Il 07/03/23 11:07, Alexandre Mergnat ha scritto:
> The item which have the mediatek,mt8192-disp-ccorr as const compatible
> already exist above. Merge all compatibles which have the same fallback
> under the same item.
> 
> Acked-by: Krzysztof Kozlowski <[e-mail]>
> Signed-off-by: Alexandre Mergnat <[e-mail]>

Alexandre, the Acked-by tag from Krzysztof goes *after* your S-o-b :-)

Reviewed-by: AngeloGioacchino Del Regno <[e-mail]>

Alexandre Mergnat March 7, 2023, 10:50 a.m. UTC | #2

Hi Angelo

Le mar. 7 mars 2023 à 11:17, AngeloGioacchino Del Regno
<[e-mail]> a écrit :
>
> Il 07/03/23 11:07, Alexandre Mergnat ha scritto:
> > The item which have the mediatek,mt8192-disp-ccorr as const compatible
> > already exist above. Merge all compatibles which have the same fallback
> > under the same item.
> >
> > Acked-by: Krzysztof Kozlowski <[e-mail]>
> > Signed-off-by: Alexandre Mergnat <[e-mail]>
>
> Alexandre, the Acked-by tag from Krzysztof goes *after* your S-o-b :-)

This is managed by the B4 tools.
Also, I know this is an unsolved topic in the community, but I agree
with people thinking the last trailer must be the guy in charge of the
commit.

AngeloGioacchino Del Regno March 7, 2023, 10:58 a.m. UTC | #3

Il 07/03/23 11:50, Alexandre Mergnat ha scritto:
> Hi Angelo
> 
> Le mar. 7 mars 2023 à 11:17, AngeloGioacchino Del Regno
> <[e-mail]> a écrit :
>>
>> Il 07/03/23 11:07, Alexandre Mergnat ha scritto:
>>> The item which have the mediatek,mt8192-disp-ccorr as const compatible
>>> already exist above. Merge all compatibles which have the same fallback
>>> under the same item.
>>>
>>> Acked-by: Krzysztof Kozlowski <[e-mail]>
>>> Signed-off-by: Alexandre Mergnat <[e-mail]>
>>
>> Alexandre, the Acked-by tag from Krzysztof goes *after* your S-o-b :-)
> 
> This is managed by the B4 tools.
> Also, I know this is an unsolved topic in the community, but I agree
> with people thinking the last trailer must be the guy in charge of the
> commit.

I was told so multiple times, hence my reply.

I personally do not care much where the tags are put, as long as they are
consistently put in a specific order; if I had strong opinions, I wouldn't
have given you a R-b tag preventively... so... whatever! :-)

Angelo

Krzysztof Kozlowski March 7, 2023, 12:50 p.m. UTC | #4

On 07/03/2023 11:17, AngeloGioacchino Del Regno wrote:
> Il 07/03/23 11:07, Alexandre Mergnat ha scritto:
>> The item which have the mediatek,mt8192-disp-ccorr as const compatible
>> already exist above. Merge all compatibles which have the same fallback
>> under the same item.
>>
>> Acked-by: Krzysztof Kozlowski <[e-mail]>
>> Signed-off-by: Alexandre Mergnat <[e-mail]>
> 
> Alexandre, the Acked-by tag from Krzysztof goes *after* your S-o-b :-)

b4 puts them like this and there is even rationale from Konstantin about
it. Anyway, it's not submitters job to correct b4. Our tools should
implement the process, not us (the users), thus if the result is
incorrect, then the tool should be fixed. Not the user.

Best regards,
Krzysztof

Patch

diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.yaml
index b04820c95b22..bda86e6857f5 100644
--- a/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.yaml
+++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.yaml
@@ -27,13 +27,10 @@  properties:
           - const: mediatek,mt8192-disp-ccorr
       - items:
           - enum:
+              - mediatek,mt8186-disp-ccorr
               - mediatek,mt8188-disp-ccorr
               - mediatek,mt8195-disp-ccorr
           - const: mediatek,mt8192-disp-ccorr
-      - items:
-          - enum:
-              - mediatek,mt8186-disp-ccorr
-          - const: mediatek,mt8192-disp-ccorr
 
   reg:
     maxItems: 1