| Message ID | 20230312131318.351173-3-krzysztof.kozlowski@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [01/28] media: cec: ch7322: drop of_match_ptr for ID table | expand |
On 12/03/2023 14:12, Krzysztof Kozlowski wrote: > The driver can match only via the DT table so the table should be always > used and the of_match_ptr does not have any sense (this also allows ACPI > matching via PRP0001, even though it might not be relevant here). This > also fixes !CONFIG_OF error: > > drivers/media/cec/platform/tegra/tegra_cec.c:457:34: error: ‘tegra_cec_of_match’ defined but not used [-Werror=unused-const-variable=] > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Reviewed-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> Thanks! Hans > --- > drivers/media/cec/platform/tegra/tegra_cec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/cec/platform/tegra/tegra_cec.c b/drivers/media/cec/platform/tegra/tegra_cec.c > index 5e907395ca2e..7115636ca748 100644 > --- a/drivers/media/cec/platform/tegra/tegra_cec.c > +++ b/drivers/media/cec/platform/tegra/tegra_cec.c > @@ -464,7 +464,7 @@ static const struct of_device_id tegra_cec_of_match[] = { > static struct platform_driver tegra_cec_driver = { > .driver = { > .name = TEGRA_CEC_NAME, > - .of_match_table = of_match_ptr(tegra_cec_of_match), > + .of_match_table = tegra_cec_of_match, > }, > .probe = tegra_cec_probe, > .remove = tegra_cec_remove,
diff --git a/drivers/media/cec/platform/tegra/tegra_cec.c b/drivers/media/cec/platform/tegra/tegra_cec.c index 5e907395ca2e..7115636ca748 100644 --- a/drivers/media/cec/platform/tegra/tegra_cec.c +++ b/drivers/media/cec/platform/tegra/tegra_cec.c @@ -464,7 +464,7 @@ static const struct of_device_id tegra_cec_of_match[] = { static struct platform_driver tegra_cec_driver = { .driver = { .name = TEGRA_CEC_NAME, - .of_match_table = of_match_ptr(tegra_cec_of_match), + .of_match_table = tegra_cec_of_match, }, .probe = tegra_cec_probe, .remove = tegra_cec_remove,
The driver can match only via the DT table so the table should be always used and the of_match_ptr does not have any sense (this also allows ACPI matching via PRP0001, even though it might not be relevant here). This also fixes !CONFIG_OF error: drivers/media/cec/platform/tegra/tegra_cec.c:457:34: error: ‘tegra_cec_of_match’ defined but not used [-Werror=unused-const-variable=] Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- drivers/media/cec/platform/tegra/tegra_cec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)