diff mbox series

[1/2] dt-bindings: usb: mtk-xhci: add an optional frame count clock

Message ID 20230403060232.25699-1-chunfeng.yun@mediatek.com (mailing list archive)
State New, archived
Headers show
Series [1/2] dt-bindings: usb: mtk-xhci: add an optional frame count clock | expand

Commit Message

Chunfeng Yun (云春峰) April 3, 2023, 6:02 a.m. UTC
Add optional clock 'frmcnt_ck' used on 4nm or advanced process SoC

Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
---
 .../devicetree/bindings/usb/mediatek,mtk-xhci.yaml          | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Comments

Krzysztof Kozlowski April 3, 2023, 7:19 p.m. UTC | #1
On 03/04/2023 08:02, Chunfeng Yun wrote:
> Add optional clock 'frmcnt_ck' used on 4nm or advanced process SoC
> 
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> ---
>  .../devicetree/bindings/usb/mediatek,mtk-xhci.yaml          | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml b/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml
> index c119caa9ad16..ee8167fbc541 100644
> --- a/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml
> +++ b/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml
> @@ -77,6 +77,7 @@ properties:
>        - description: Mcu bus clock for register access
>        - description: DMA bus clock for data transfer
>        - description: controller clock
> +      - description: frame count clock
>  
>    clock-names:
>      minItems: 1
> @@ -86,14 +87,15 @@ properties:
>        - const: mcu_ck
>        - const: dma_ck
>        - const: xhci_ck
> +      - const: frmcnt_ck


Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

>  
>    assigned-clocks:
>      minItems: 1
> -    maxItems: 5
> +    maxItems: 6

But these should be dropped:
https://lore.kernel.org/linux-devicetree/20230403191850.374839-1-krzysztof.kozlowski@linaro.org/T/#t

>  
>    assigned-clock-parents:
>      minItems: 1
> -    maxItems: 5
> +    maxItems: 6
>  
>    phys:
>      description:

Best regards,
Krzysztof
Chunfeng Yun (云春峰) April 7, 2023, 5:34 a.m. UTC | #2
On Mon, 2023-04-03 at 21:19 +0200, Krzysztof Kozlowski wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> On 03/04/2023 08:02, Chunfeng Yun wrote:
> > Add optional clock 'frmcnt_ck' used on 4nm or advanced process SoC
> > 
> > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> > ---
> >  .../devicetree/bindings/usb/mediatek,mtk-xhci.yaml          | 6
> > ++++--
> >  1 file changed, 4 insertions(+), 2 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/usb/mediatek,mtk-
> > xhci.yaml b/Documentation/devicetree/bindings/usb/mediatek,mtk-
> > xhci.yaml
> > index c119caa9ad16..ee8167fbc541 100644
> > --- a/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml
> > +++ b/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml
> > @@ -77,6 +77,7 @@ properties:
> >        - description: Mcu bus clock for register access
> >        - description: DMA bus clock for data transfer
> >        - description: controller clock
> > +      - description: frame count clock
> > 
> >    clock-names:
> >      minItems: 1
> > @@ -86,14 +87,15 @@ properties:
> >        - const: mcu_ck
> >        - const: dma_ck
> >        - const: xhci_ck
> > +      - const: frmcnt_ck
> 
> 
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> > 
> >    assigned-clocks:
> >      minItems: 1
> > -    maxItems: 5
> > +    maxItems: 6
> 
> But these should be dropped:
> 
https://lore.kernel.org/linux-devicetree/20230403191850.374839-1-krzysztof.kozlowski@linaro.org/T/#t
> 
Ok, I'll drop assigned-clocks change, thanks

> > 
> >    assigned-clock-parents:
> >      minItems: 1
> > -    maxItems: 5
> > +    maxItems: 6
> > 
> >    phys:
> >      description:
> 
> Best regards,
> Krzysztof
>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml b/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml
index c119caa9ad16..ee8167fbc541 100644
--- a/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml
+++ b/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml
@@ -77,6 +77,7 @@  properties:
       - description: Mcu bus clock for register access
       - description: DMA bus clock for data transfer
       - description: controller clock
+      - description: frame count clock
 
   clock-names:
     minItems: 1
@@ -86,14 +87,15 @@  properties:
       - const: mcu_ck
       - const: dma_ck
       - const: xhci_ck
+      - const: frmcnt_ck
 
   assigned-clocks:
     minItems: 1
-    maxItems: 5
+    maxItems: 6
 
   assigned-clock-parents:
     minItems: 1
-    maxItems: 5
+    maxItems: 6
 
   phys:
     description: