| Message ID | 20230406080141.22924-5-arinc.unal@arinc9.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/7] dt-bindings: net: dsa: mediatek,mt7530: correct brand name | expand |
On Thu, Apr 06, 2023 at 11:01:39AM +0300, arinc9.unal@gmail.com wrote: > From: Arınç ÜNAL <arinc.unal@arinc9.com> > > The resets and reset-names properties are used only if mediatek,mcm is > used. Set them to false if mediatek,mcm is not used. > > Remove now unnecessary 'reset-names: false' from MT7988. > > Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com> Acked-by: Daniel Golle <daniel@makrotopia.org> > --- > .../devicetree/bindings/net/dsa/mediatek,mt7530.yaml | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml > index 9d99f7303453..3fd953b1453e 100644 > --- a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml > +++ b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml > @@ -282,6 +282,10 @@ allOf: > required: > - resets > - reset-names > + else: > + properties: > + resets: false > + reset-names: false > > - dependencies: > interrupt-controller: [ interrupts ] > @@ -324,7 +328,6 @@ allOf: > properties: > gpio-controller: false > mediatek,mcm: false > - reset-names: false > > unevaluatedProperties: false > > -- > 2.37.2 >
On 06/04/2023 10:01, arinc9.unal@gmail.com wrote: > From: Arınç ÜNAL <arinc.unal@arinc9.com> > > The resets and reset-names properties are used only if mediatek,mcm is > used. Set them to false if mediatek,mcm is not used. > > Remove now unnecessary 'reset-names: false' from MT7988. > > Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com> > --- > .../devicetree/bindings/net/dsa/mediatek,mt7530.yaml | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml > index 9d99f7303453..3fd953b1453e 100644 > --- a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml > +++ b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml > @@ -282,6 +282,10 @@ allOf: > required: > - resets > - reset-names > + else: > + properties: > + resets: false > + reset-names: false > > - dependencies: > interrupt-controller: [ interrupts ] > @@ -324,7 +328,6 @@ allOf: > properties: > gpio-controller: false > mediatek,mcm: false > - reset-names: false I don't see such hunk in linux-next. Best regards, Krzysztof
On 6.04.2023 22:08, Krzysztof Kozlowski wrote: > On 06/04/2023 10:01, arinc9.unal@gmail.com wrote: >> From: Arınç ÜNAL <arinc.unal@arinc9.com> >> >> The resets and reset-names properties are used only if mediatek,mcm is >> used. Set them to false if mediatek,mcm is not used. >> >> Remove now unnecessary 'reset-names: false' from MT7988. >> >> Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com> >> --- >> .../devicetree/bindings/net/dsa/mediatek,mt7530.yaml | 5 ++++- >> 1 file changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml >> index 9d99f7303453..3fd953b1453e 100644 >> --- a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml >> +++ b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml >> @@ -282,6 +282,10 @@ allOf: >> required: >> - resets >> - reset-names >> + else: >> + properties: >> + resets: false >> + reset-names: false >> >> - dependencies: >> interrupt-controller: [ interrupts ] >> @@ -324,7 +328,6 @@ allOf: >> properties: >> gpio-controller: false >> mediatek,mcm: false >> - reset-names: false > > I don't see such hunk in linux-next. This was added very recently so it's only on net-next at the moment. Arınç
On 06/04/2023 21:19, Arınç ÜNAL wrote: > On 6.04.2023 22:08, Krzysztof Kozlowski wrote: >> On 06/04/2023 10:01, arinc9.unal@gmail.com wrote: >>> From: Arınç ÜNAL <arinc.unal@arinc9.com> >>> >>> The resets and reset-names properties are used only if mediatek,mcm is >>> used. Set them to false if mediatek,mcm is not used. >>> >>> Remove now unnecessary 'reset-names: false' from MT7988. >>> >>> Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com> >>> --- >>> .../devicetree/bindings/net/dsa/mediatek,mt7530.yaml | 5 ++++- >>> 1 file changed, 4 insertions(+), 1 deletion(-) >>> >>> diff --git a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml >>> index 9d99f7303453..3fd953b1453e 100644 >>> --- a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml >>> +++ b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml >>> @@ -282,6 +282,10 @@ allOf: >>> required: >>> - resets >>> - reset-names >>> + else: >>> + properties: >>> + resets: false >>> + reset-names: false >>> >>> - dependencies: >>> interrupt-controller: [ interrupts ] >>> @@ -324,7 +328,6 @@ allOf: >>> properties: >>> gpio-controller: false >>> mediatek,mcm: false >>> - reset-names: false >> >> I don't see such hunk in linux-next. > > This was added very recently so it's only on net-next at the moment. OK, I was checking one few days old. Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml index 9d99f7303453..3fd953b1453e 100644 --- a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml +++ b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml @@ -282,6 +282,10 @@ allOf: required: - resets - reset-names + else: + properties: + resets: false + reset-names: false - dependencies: interrupt-controller: [ interrupts ] @@ -324,7 +328,6 @@ allOf: properties: gpio-controller: false mediatek,mcm: false - reset-names: false unevaluatedProperties: false