| Message ID | 20230407115553.1968111-1-trix@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ASoC: mediatek: mt8186: set variable aud_pinctrl to static | expand |
On Fri, 07 Apr 2023 07:55:53 -0400, Tom Rix wrote: > smatch reports > sound/soc/mediatek/mt8186/mt8186-afe-gpio.c:14:16: warning: symbol > 'aud_pinctrl' was not declared. Should it be static? > > This variable is only used in one file so should be static. > > > [...] Applied to broonie/sound.git for-next Thanks! [1/1] ASoC: mediatek: mt8186: set variable aud_pinctrl to static commit: 672029caa5708934817a331f3323bbe48d456c5c All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/sound/soc/mediatek/mt8186/mt8186-afe-gpio.c b/sound/soc/mediatek/mt8186/mt8186-afe-gpio.c index 20b9f5d810ec..f12e91cc4fcf 100644 --- a/sound/soc/mediatek/mt8186/mt8186-afe-gpio.c +++ b/sound/soc/mediatek/mt8186/mt8186-afe-gpio.c @@ -11,7 +11,7 @@ #include "mt8186-afe-common.h" #include "mt8186-afe-gpio.h" -struct pinctrl *aud_pinctrl; +static struct pinctrl *aud_pinctrl; enum mt8186_afe_gpio { MT8186_AFE_GPIO_CLK_MOSI_OFF,
smatch reports sound/soc/mediatek/mt8186/mt8186-afe-gpio.c:14:16: warning: symbol 'aud_pinctrl' was not declared. Should it be static? This variable is only used in one file so should be static. Signed-off-by: Tom Rix <trix@redhat.com> --- sound/soc/mediatek/mt8186/mt8186-afe-gpio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)