| Message ID | 20230531063532.2240038-1-wenst@chromium.org (mailing list archive) |
|---|---|
| State | Mainlined, archived |
| Headers | show |
| Series | soc: mediatek: SVS: Fix MT8192 GPU node name | expand |
Il 31/05/23 08:35, Chen-Yu Tsai ha scritto: > Device tree node names should be generic. The planned device node name > for the GPU, according to the bindings and posted DT changes, is "gpu", > not "mali". > > Fix the GPU node name in the SVS driver to follow. > > Fixes: 0bbb09b2af9d ("soc: mediatek: SVS: add mt8192 SVS GPU driver") > Signed-off-by: Chen-Yu Tsai <wenst@chromium.org> Hahaha, I was about to send the same patch! :D Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > --- > drivers/soc/mediatek/mtk-svs.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/soc/mediatek/mtk-svs.c b/drivers/soc/mediatek/mtk-svs.c > index 81585733c8a9..3a2f97cd5272 100644 > --- a/drivers/soc/mediatek/mtk-svs.c > +++ b/drivers/soc/mediatek/mtk-svs.c > @@ -2061,9 +2061,9 @@ static int svs_mt8192_platform_probe(struct svs_platform *svsp) > svsb = &svsp->banks[idx]; > > if (svsb->type == SVSB_HIGH) > - svsb->opp_dev = svs_add_device_link(svsp, "mali"); > + svsb->opp_dev = svs_add_device_link(svsp, "gpu"); > else if (svsb->type == SVSB_LOW) > - svsb->opp_dev = svs_get_subsys_device(svsp, "mali"); > + svsb->opp_dev = svs_get_subsys_device(svsp, "gpu"); > > if (IS_ERR(svsb->opp_dev)) > return dev_err_probe(svsp->dev, PTR_ERR(svsb->opp_dev),
On 31/05/2023 08:35, Chen-Yu Tsai wrote: > Device tree node names should be generic. The planned device node name > for the GPU, according to the bindings and posted DT changes, is "gpu", > not "mali". > > Fix the GPU node name in the SVS driver to follow. Reviewed-by: Alexandre Mergnat <amergnat@baylibre.com>
diff --git a/drivers/soc/mediatek/mtk-svs.c b/drivers/soc/mediatek/mtk-svs.c index 81585733c8a9..3a2f97cd5272 100644 --- a/drivers/soc/mediatek/mtk-svs.c +++ b/drivers/soc/mediatek/mtk-svs.c @@ -2061,9 +2061,9 @@ static int svs_mt8192_platform_probe(struct svs_platform *svsp) svsb = &svsp->banks[idx]; if (svsb->type == SVSB_HIGH) - svsb->opp_dev = svs_add_device_link(svsp, "mali"); + svsb->opp_dev = svs_add_device_link(svsp, "gpu"); else if (svsb->type == SVSB_LOW) - svsb->opp_dev = svs_get_subsys_device(svsp, "mali"); + svsb->opp_dev = svs_get_subsys_device(svsp, "gpu"); if (IS_ERR(svsb->opp_dev)) return dev_err_probe(svsp->dev, PTR_ERR(svsb->opp_dev),
Device tree node names should be generic. The planned device node name for the GPU, according to the bindings and posted DT changes, is "gpu", not "mali". Fix the GPU node name in the SVS driver to follow. Fixes: 0bbb09b2af9d ("soc: mediatek: SVS: add mt8192 SVS GPU driver") Signed-off-by: Chen-Yu Tsai <wenst@chromium.org> --- drivers/soc/mediatek/mtk-svs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)