| Message ID | 20230707140434.723349-8-ulf.hansson@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | None | expand |
On 07/07/2023 16:04, Ulf Hansson wrote: > Cc: Matthias Brugger <matthias.bgg@gmail.com> > Cc: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > Cc: <linux-mediatek@lists.infradead.org> > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> We are missing a complete commit message here, is that intentional? It would also need a patch against the maintainers file. Apart from that patch looks good. Regards, Matthias > --- > drivers/genpd/Makefile | 1 + > drivers/genpd/mediatek/Makefile | 3 +++ > drivers/{soc => genpd}/mediatek/mt6795-pm-domains.h | 0 > drivers/{soc => genpd}/mediatek/mt8167-pm-domains.h | 0 > drivers/{soc => genpd}/mediatek/mt8173-pm-domains.h | 0 > drivers/{soc => genpd}/mediatek/mt8183-pm-domains.h | 0 > drivers/{soc => genpd}/mediatek/mt8186-pm-domains.h | 0 > drivers/{soc => genpd}/mediatek/mt8188-pm-domains.h | 0 > drivers/{soc => genpd}/mediatek/mt8192-pm-domains.h | 0 > drivers/{soc => genpd}/mediatek/mt8195-pm-domains.h | 0 > drivers/{soc => genpd}/mediatek/mtk-pm-domains.c | 0 > drivers/{soc => genpd}/mediatek/mtk-pm-domains.h | 0 > drivers/{soc => genpd}/mediatek/mtk-scpsys.c | 0 > drivers/soc/mediatek/Makefile | 2 -- > 14 files changed, 4 insertions(+), 2 deletions(-) > create mode 100644 drivers/genpd/mediatek/Makefile > rename drivers/{soc => genpd}/mediatek/mt6795-pm-domains.h (100%) > rename drivers/{soc => genpd}/mediatek/mt8167-pm-domains.h (100%) > rename drivers/{soc => genpd}/mediatek/mt8173-pm-domains.h (100%) > rename drivers/{soc => genpd}/mediatek/mt8183-pm-domains.h (100%) > rename drivers/{soc => genpd}/mediatek/mt8186-pm-domains.h (100%) > rename drivers/{soc => genpd}/mediatek/mt8188-pm-domains.h (100%) > rename drivers/{soc => genpd}/mediatek/mt8192-pm-domains.h (100%) > rename drivers/{soc => genpd}/mediatek/mt8195-pm-domains.h (100%) > rename drivers/{soc => genpd}/mediatek/mtk-pm-domains.c (100%) > rename drivers/{soc => genpd}/mediatek/mtk-pm-domains.h (100%) > rename drivers/{soc => genpd}/mediatek/mtk-scpsys.c (100%) > > diff --git a/drivers/genpd/Makefile b/drivers/genpd/Makefile > index 6b9e9fe907f3..1a0a56925756 100644 > --- a/drivers/genpd/Makefile > +++ b/drivers/genpd/Makefile > @@ -3,3 +3,4 @@ obj-y += actions/ > obj-y += amlogic/ > obj-y += apple/ > obj-y += bcm/ > +obj-y += mediatek/ > diff --git a/drivers/genpd/mediatek/Makefile b/drivers/genpd/mediatek/Makefile > new file mode 100644 > index 000000000000..8cde09e654b3 > --- /dev/null > +++ b/drivers/genpd/mediatek/Makefile > @@ -0,0 +1,3 @@ > +# SPDX-License-Identifier: GPL-2.0-only > +obj-$(CONFIG_MTK_SCPSYS) += mtk-scpsys.o > +obj-$(CONFIG_MTK_SCPSYS_PM_DOMAINS) += mtk-pm-domains.o > diff --git a/drivers/soc/mediatek/mt6795-pm-domains.h b/drivers/genpd/mediatek/mt6795-pm-domains.h > similarity index 100% > rename from drivers/soc/mediatek/mt6795-pm-domains.h > rename to drivers/genpd/mediatek/mt6795-pm-domains.h > diff --git a/drivers/soc/mediatek/mt8167-pm-domains.h b/drivers/genpd/mediatek/mt8167-pm-domains.h > similarity index 100% > rename from drivers/soc/mediatek/mt8167-pm-domains.h > rename to drivers/genpd/mediatek/mt8167-pm-domains.h > diff --git a/drivers/soc/mediatek/mt8173-pm-domains.h b/drivers/genpd/mediatek/mt8173-pm-domains.h > similarity index 100% > rename from drivers/soc/mediatek/mt8173-pm-domains.h > rename to drivers/genpd/mediatek/mt8173-pm-domains.h > diff --git a/drivers/soc/mediatek/mt8183-pm-domains.h b/drivers/genpd/mediatek/mt8183-pm-domains.h > similarity index 100% > rename from drivers/soc/mediatek/mt8183-pm-domains.h > rename to drivers/genpd/mediatek/mt8183-pm-domains.h > diff --git a/drivers/soc/mediatek/mt8186-pm-domains.h b/drivers/genpd/mediatek/mt8186-pm-domains.h > similarity index 100% > rename from drivers/soc/mediatek/mt8186-pm-domains.h > rename to drivers/genpd/mediatek/mt8186-pm-domains.h > diff --git a/drivers/soc/mediatek/mt8188-pm-domains.h b/drivers/genpd/mediatek/mt8188-pm-domains.h > similarity index 100% > rename from drivers/soc/mediatek/mt8188-pm-domains.h > rename to drivers/genpd/mediatek/mt8188-pm-domains.h > diff --git a/drivers/soc/mediatek/mt8192-pm-domains.h b/drivers/genpd/mediatek/mt8192-pm-domains.h > similarity index 100% > rename from drivers/soc/mediatek/mt8192-pm-domains.h > rename to drivers/genpd/mediatek/mt8192-pm-domains.h > diff --git a/drivers/soc/mediatek/mt8195-pm-domains.h b/drivers/genpd/mediatek/mt8195-pm-domains.h > similarity index 100% > rename from drivers/soc/mediatek/mt8195-pm-domains.h > rename to drivers/genpd/mediatek/mt8195-pm-domains.h > diff --git a/drivers/soc/mediatek/mtk-pm-domains.c b/drivers/genpd/mediatek/mtk-pm-domains.c > similarity index 100% > rename from drivers/soc/mediatek/mtk-pm-domains.c > rename to drivers/genpd/mediatek/mtk-pm-domains.c > diff --git a/drivers/soc/mediatek/mtk-pm-domains.h b/drivers/genpd/mediatek/mtk-pm-domains.h > similarity index 100% > rename from drivers/soc/mediatek/mtk-pm-domains.h > rename to drivers/genpd/mediatek/mtk-pm-domains.h > diff --git a/drivers/soc/mediatek/mtk-scpsys.c b/drivers/genpd/mediatek/mtk-scpsys.c > similarity index 100% > rename from drivers/soc/mediatek/mtk-scpsys.c > rename to drivers/genpd/mediatek/mtk-scpsys.c > diff --git a/drivers/soc/mediatek/Makefile b/drivers/soc/mediatek/Makefile > index 8c0ddacbcde8..9d3ce7878c5c 100644 > --- a/drivers/soc/mediatek/Makefile > +++ b/drivers/soc/mediatek/Makefile > @@ -4,8 +4,6 @@ obj-$(CONFIG_MTK_DEVAPC) += mtk-devapc.o > obj-$(CONFIG_MTK_INFRACFG) += mtk-infracfg.o > obj-$(CONFIG_MTK_PMIC_WRAP) += mtk-pmic-wrap.o > obj-$(CONFIG_MTK_REGULATOR_COUPLER) += mtk-regulator-coupler.o > -obj-$(CONFIG_MTK_SCPSYS) += mtk-scpsys.o > -obj-$(CONFIG_MTK_SCPSYS_PM_DOMAINS) += mtk-pm-domains.o > obj-$(CONFIG_MTK_MMSYS) += mtk-mmsys.o > obj-$(CONFIG_MTK_MMSYS) += mtk-mutex.o > obj-$(CONFIG_MTK_SVS) += mtk-svs.o
On Fri, 7 Jul 2023 at 16:45, Matthias Brugger <matthias.bgg@gmail.com> wrote: > > > > On 07/07/2023 16:04, Ulf Hansson wrote: > > Cc: Matthias Brugger <matthias.bgg@gmail.com> > > Cc: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > > Cc: <linux-mediatek@lists.infradead.org> > > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> > > We are missing a complete commit message here, is that intentional? I was lazy and added the motivations behind this in patch 1. I will re-spin and fix this. > It would also need a patch against the maintainers file. You already have this in the Mediatek SoC section. But I can add the genpd directory too, to make it explicit if you prefer that? N: mtk N: mt[2678] K: mediatek > > Apart from that patch looks good. > > Regards, > Matthias Thanks! Kind regards Uffe > > > --- > > drivers/genpd/Makefile | 1 + > > drivers/genpd/mediatek/Makefile | 3 +++ > > drivers/{soc => genpd}/mediatek/mt6795-pm-domains.h | 0 > > drivers/{soc => genpd}/mediatek/mt8167-pm-domains.h | 0 > > drivers/{soc => genpd}/mediatek/mt8173-pm-domains.h | 0 > > drivers/{soc => genpd}/mediatek/mt8183-pm-domains.h | 0 > > drivers/{soc => genpd}/mediatek/mt8186-pm-domains.h | 0 > > drivers/{soc => genpd}/mediatek/mt8188-pm-domains.h | 0 > > drivers/{soc => genpd}/mediatek/mt8192-pm-domains.h | 0 > > drivers/{soc => genpd}/mediatek/mt8195-pm-domains.h | 0 > > drivers/{soc => genpd}/mediatek/mtk-pm-domains.c | 0 > > drivers/{soc => genpd}/mediatek/mtk-pm-domains.h | 0 > > drivers/{soc => genpd}/mediatek/mtk-scpsys.c | 0 > > drivers/soc/mediatek/Makefile | 2 -- > > 14 files changed, 4 insertions(+), 2 deletions(-) > > create mode 100644 drivers/genpd/mediatek/Makefile > > rename drivers/{soc => genpd}/mediatek/mt6795-pm-domains.h (100%) > > rename drivers/{soc => genpd}/mediatek/mt8167-pm-domains.h (100%) > > rename drivers/{soc => genpd}/mediatek/mt8173-pm-domains.h (100%) > > rename drivers/{soc => genpd}/mediatek/mt8183-pm-domains.h (100%) > > rename drivers/{soc => genpd}/mediatek/mt8186-pm-domains.h (100%) > > rename drivers/{soc => genpd}/mediatek/mt8188-pm-domains.h (100%) > > rename drivers/{soc => genpd}/mediatek/mt8192-pm-domains.h (100%) > > rename drivers/{soc => genpd}/mediatek/mt8195-pm-domains.h (100%) > > rename drivers/{soc => genpd}/mediatek/mtk-pm-domains.c (100%) > > rename drivers/{soc => genpd}/mediatek/mtk-pm-domains.h (100%) > > rename drivers/{soc => genpd}/mediatek/mtk-scpsys.c (100%) > > > > diff --git a/drivers/genpd/Makefile b/drivers/genpd/Makefile > > index 6b9e9fe907f3..1a0a56925756 100644 > > --- a/drivers/genpd/Makefile > > +++ b/drivers/genpd/Makefile > > @@ -3,3 +3,4 @@ obj-y += actions/ > > obj-y += amlogic/ > > obj-y += apple/ > > obj-y += bcm/ > > +obj-y += mediatek/ > > diff --git a/drivers/genpd/mediatek/Makefile b/drivers/genpd/mediatek/Makefile > > new file mode 100644 > > index 000000000000..8cde09e654b3 > > --- /dev/null > > +++ b/drivers/genpd/mediatek/Makefile > > @@ -0,0 +1,3 @@ > > +# SPDX-License-Identifier: GPL-2.0-only > > +obj-$(CONFIG_MTK_SCPSYS) += mtk-scpsys.o > > +obj-$(CONFIG_MTK_SCPSYS_PM_DOMAINS) += mtk-pm-domains.o > > diff --git a/drivers/soc/mediatek/mt6795-pm-domains.h b/drivers/genpd/mediatek/mt6795-pm-domains.h > > similarity index 100% > > rename from drivers/soc/mediatek/mt6795-pm-domains.h > > rename to drivers/genpd/mediatek/mt6795-pm-domains.h > > diff --git a/drivers/soc/mediatek/mt8167-pm-domains.h b/drivers/genpd/mediatek/mt8167-pm-domains.h > > similarity index 100% > > rename from drivers/soc/mediatek/mt8167-pm-domains.h > > rename to drivers/genpd/mediatek/mt8167-pm-domains.h > > diff --git a/drivers/soc/mediatek/mt8173-pm-domains.h b/drivers/genpd/mediatek/mt8173-pm-domains.h > > similarity index 100% > > rename from drivers/soc/mediatek/mt8173-pm-domains.h > > rename to drivers/genpd/mediatek/mt8173-pm-domains.h > > diff --git a/drivers/soc/mediatek/mt8183-pm-domains.h b/drivers/genpd/mediatek/mt8183-pm-domains.h > > similarity index 100% > > rename from drivers/soc/mediatek/mt8183-pm-domains.h > > rename to drivers/genpd/mediatek/mt8183-pm-domains.h > > diff --git a/drivers/soc/mediatek/mt8186-pm-domains.h b/drivers/genpd/mediatek/mt8186-pm-domains.h > > similarity index 100% > > rename from drivers/soc/mediatek/mt8186-pm-domains.h > > rename to drivers/genpd/mediatek/mt8186-pm-domains.h > > diff --git a/drivers/soc/mediatek/mt8188-pm-domains.h b/drivers/genpd/mediatek/mt8188-pm-domains.h > > similarity index 100% > > rename from drivers/soc/mediatek/mt8188-pm-domains.h > > rename to drivers/genpd/mediatek/mt8188-pm-domains.h > > diff --git a/drivers/soc/mediatek/mt8192-pm-domains.h b/drivers/genpd/mediatek/mt8192-pm-domains.h > > similarity index 100% > > rename from drivers/soc/mediatek/mt8192-pm-domains.h > > rename to drivers/genpd/mediatek/mt8192-pm-domains.h > > diff --git a/drivers/soc/mediatek/mt8195-pm-domains.h b/drivers/genpd/mediatek/mt8195-pm-domains.h > > similarity index 100% > > rename from drivers/soc/mediatek/mt8195-pm-domains.h > > rename to drivers/genpd/mediatek/mt8195-pm-domains.h > > diff --git a/drivers/soc/mediatek/mtk-pm-domains.c b/drivers/genpd/mediatek/mtk-pm-domains.c > > similarity index 100% > > rename from drivers/soc/mediatek/mtk-pm-domains.c > > rename to drivers/genpd/mediatek/mtk-pm-domains.c > > diff --git a/drivers/soc/mediatek/mtk-pm-domains.h b/drivers/genpd/mediatek/mtk-pm-domains.h > > similarity index 100% > > rename from drivers/soc/mediatek/mtk-pm-domains.h > > rename to drivers/genpd/mediatek/mtk-pm-domains.h > > diff --git a/drivers/soc/mediatek/mtk-scpsys.c b/drivers/genpd/mediatek/mtk-scpsys.c > > similarity index 100% > > rename from drivers/soc/mediatek/mtk-scpsys.c > > rename to drivers/genpd/mediatek/mtk-scpsys.c > > diff --git a/drivers/soc/mediatek/Makefile b/drivers/soc/mediatek/Makefile > > index 8c0ddacbcde8..9d3ce7878c5c 100644 > > --- a/drivers/soc/mediatek/Makefile > > +++ b/drivers/soc/mediatek/Makefile > > @@ -4,8 +4,6 @@ obj-$(CONFIG_MTK_DEVAPC) += mtk-devapc.o > > obj-$(CONFIG_MTK_INFRACFG) += mtk-infracfg.o > > obj-$(CONFIG_MTK_PMIC_WRAP) += mtk-pmic-wrap.o > > obj-$(CONFIG_MTK_REGULATOR_COUPLER) += mtk-regulator-coupler.o > > -obj-$(CONFIG_MTK_SCPSYS) += mtk-scpsys.o > > -obj-$(CONFIG_MTK_SCPSYS_PM_DOMAINS) += mtk-pm-domains.o > > obj-$(CONFIG_MTK_MMSYS) += mtk-mmsys.o > > obj-$(CONFIG_MTK_MMSYS) += mtk-mutex.o > > obj-$(CONFIG_MTK_SVS) += mtk-svs.o
diff --git a/drivers/genpd/Makefile b/drivers/genpd/Makefile index 6b9e9fe907f3..1a0a56925756 100644 --- a/drivers/genpd/Makefile +++ b/drivers/genpd/Makefile @@ -3,3 +3,4 @@ obj-y += actions/ obj-y += amlogic/ obj-y += apple/ obj-y += bcm/ +obj-y += mediatek/ diff --git a/drivers/genpd/mediatek/Makefile b/drivers/genpd/mediatek/Makefile new file mode 100644 index 000000000000..8cde09e654b3 --- /dev/null +++ b/drivers/genpd/mediatek/Makefile @@ -0,0 +1,3 @@ +# SPDX-License-Identifier: GPL-2.0-only +obj-$(CONFIG_MTK_SCPSYS) += mtk-scpsys.o +obj-$(CONFIG_MTK_SCPSYS_PM_DOMAINS) += mtk-pm-domains.o diff --git a/drivers/soc/mediatek/mt6795-pm-domains.h b/drivers/genpd/mediatek/mt6795-pm-domains.h similarity index 100% rename from drivers/soc/mediatek/mt6795-pm-domains.h rename to drivers/genpd/mediatek/mt6795-pm-domains.h diff --git a/drivers/soc/mediatek/mt8167-pm-domains.h b/drivers/genpd/mediatek/mt8167-pm-domains.h similarity index 100% rename from drivers/soc/mediatek/mt8167-pm-domains.h rename to drivers/genpd/mediatek/mt8167-pm-domains.h diff --git a/drivers/soc/mediatek/mt8173-pm-domains.h b/drivers/genpd/mediatek/mt8173-pm-domains.h similarity index 100% rename from drivers/soc/mediatek/mt8173-pm-domains.h rename to drivers/genpd/mediatek/mt8173-pm-domains.h diff --git a/drivers/soc/mediatek/mt8183-pm-domains.h b/drivers/genpd/mediatek/mt8183-pm-domains.h similarity index 100% rename from drivers/soc/mediatek/mt8183-pm-domains.h rename to drivers/genpd/mediatek/mt8183-pm-domains.h diff --git a/drivers/soc/mediatek/mt8186-pm-domains.h b/drivers/genpd/mediatek/mt8186-pm-domains.h similarity index 100% rename from drivers/soc/mediatek/mt8186-pm-domains.h rename to drivers/genpd/mediatek/mt8186-pm-domains.h diff --git a/drivers/soc/mediatek/mt8188-pm-domains.h b/drivers/genpd/mediatek/mt8188-pm-domains.h similarity index 100% rename from drivers/soc/mediatek/mt8188-pm-domains.h rename to drivers/genpd/mediatek/mt8188-pm-domains.h diff --git a/drivers/soc/mediatek/mt8192-pm-domains.h b/drivers/genpd/mediatek/mt8192-pm-domains.h similarity index 100% rename from drivers/soc/mediatek/mt8192-pm-domains.h rename to drivers/genpd/mediatek/mt8192-pm-domains.h diff --git a/drivers/soc/mediatek/mt8195-pm-domains.h b/drivers/genpd/mediatek/mt8195-pm-domains.h similarity index 100% rename from drivers/soc/mediatek/mt8195-pm-domains.h rename to drivers/genpd/mediatek/mt8195-pm-domains.h diff --git a/drivers/soc/mediatek/mtk-pm-domains.c b/drivers/genpd/mediatek/mtk-pm-domains.c similarity index 100% rename from drivers/soc/mediatek/mtk-pm-domains.c rename to drivers/genpd/mediatek/mtk-pm-domains.c diff --git a/drivers/soc/mediatek/mtk-pm-domains.h b/drivers/genpd/mediatek/mtk-pm-domains.h similarity index 100% rename from drivers/soc/mediatek/mtk-pm-domains.h rename to drivers/genpd/mediatek/mtk-pm-domains.h diff --git a/drivers/soc/mediatek/mtk-scpsys.c b/drivers/genpd/mediatek/mtk-scpsys.c similarity index 100% rename from drivers/soc/mediatek/mtk-scpsys.c rename to drivers/genpd/mediatek/mtk-scpsys.c diff --git a/drivers/soc/mediatek/Makefile b/drivers/soc/mediatek/Makefile index 8c0ddacbcde8..9d3ce7878c5c 100644 --- a/drivers/soc/mediatek/Makefile +++ b/drivers/soc/mediatek/Makefile @@ -4,8 +4,6 @@ obj-$(CONFIG_MTK_DEVAPC) += mtk-devapc.o obj-$(CONFIG_MTK_INFRACFG) += mtk-infracfg.o obj-$(CONFIG_MTK_PMIC_WRAP) += mtk-pmic-wrap.o obj-$(CONFIG_MTK_REGULATOR_COUPLER) += mtk-regulator-coupler.o -obj-$(CONFIG_MTK_SCPSYS) += mtk-scpsys.o -obj-$(CONFIG_MTK_SCPSYS_PM_DOMAINS) += mtk-pm-domains.o obj-$(CONFIG_MTK_MMSYS) += mtk-mmsys.o obj-$(CONFIG_MTK_MMSYS) += mtk-mutex.o obj-$(CONFIG_MTK_SVS) += mtk-svs.o
Cc: Matthias Brugger <matthias.bgg@gmail.com> Cc: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Cc: <linux-mediatek@lists.infradead.org> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> --- drivers/genpd/Makefile | 1 + drivers/genpd/mediatek/Makefile | 3 +++ drivers/{soc => genpd}/mediatek/mt6795-pm-domains.h | 0 drivers/{soc => genpd}/mediatek/mt8167-pm-domains.h | 0 drivers/{soc => genpd}/mediatek/mt8173-pm-domains.h | 0 drivers/{soc => genpd}/mediatek/mt8183-pm-domains.h | 0 drivers/{soc => genpd}/mediatek/mt8186-pm-domains.h | 0 drivers/{soc => genpd}/mediatek/mt8188-pm-domains.h | 0 drivers/{soc => genpd}/mediatek/mt8192-pm-domains.h | 0 drivers/{soc => genpd}/mediatek/mt8195-pm-domains.h | 0 drivers/{soc => genpd}/mediatek/mtk-pm-domains.c | 0 drivers/{soc => genpd}/mediatek/mtk-pm-domains.h | 0 drivers/{soc => genpd}/mediatek/mtk-scpsys.c | 0 drivers/soc/mediatek/Makefile | 2 -- 14 files changed, 4 insertions(+), 2 deletions(-) create mode 100644 drivers/genpd/mediatek/Makefile rename drivers/{soc => genpd}/mediatek/mt6795-pm-domains.h (100%) rename drivers/{soc => genpd}/mediatek/mt8167-pm-domains.h (100%) rename drivers/{soc => genpd}/mediatek/mt8173-pm-domains.h (100%) rename drivers/{soc => genpd}/mediatek/mt8183-pm-domains.h (100%) rename drivers/{soc => genpd}/mediatek/mt8186-pm-domains.h (100%) rename drivers/{soc => genpd}/mediatek/mt8188-pm-domains.h (100%) rename drivers/{soc => genpd}/mediatek/mt8192-pm-domains.h (100%) rename drivers/{soc => genpd}/mediatek/mt8195-pm-domains.h (100%) rename drivers/{soc => genpd}/mediatek/mtk-pm-domains.c (100%) rename drivers/{soc => genpd}/mediatek/mtk-pm-domains.h (100%) rename drivers/{soc => genpd}/mediatek/mtk-scpsys.c (100%)