| Message ID | 20230810063300.20151-2-krzysztof.kozlowski@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2,01/11] ASoC: dt-bindings: Add common sound card properties | expand |
On 10/08/2023 09:20, Rob Herring wrote: > > On Thu, 10 Aug 2023 08:32:50 +0200, Krzysztof Kozlowski wrote: >> The mediatek,mt8188-mt6359 Linux sound machine driver requires the >> "model" property, so binding was incomplete. Reference the common sound >> card properties to fix that which also allows to remove duplicated >> property definitions. Leave the relevant parts of "audio-routing" >> description. >> >> Reviewed-by: Rob Herring <robh@kernel.org> >> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> --- >> .../bindings/sound/mediatek,mt8188-mt6359.yaml | 17 +++++++---------- >> 1 file changed, 7 insertions(+), 10 deletions(-) >> > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > I think the bot responds like this if the patch could not be applied. Probably we can ignore it. Best regards, Krzysztof
On Thu, Aug 10, 2023 at 1:47 AM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 10/08/2023 09:20, Rob Herring wrote: > > > > On Thu, 10 Aug 2023 08:32:50 +0200, Krzysztof Kozlowski wrote: > >> The mediatek,mt8188-mt6359 Linux sound machine driver requires the > >> "model" property, so binding was incomplete. Reference the common sound > >> card properties to fix that which also allows to remove duplicated > >> property definitions. Leave the relevant parts of "audio-routing" > >> description. > >> > >> Reviewed-by: Rob Herring <robh@kernel.org> > >> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > >> --- > >> .../bindings/sound/mediatek,mt8188-mt6359.yaml | 17 +++++++---------- > >> 1 file changed, 7 insertions(+), 10 deletions(-) > >> > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > > > yamllint warnings/errors: > > > > dtschema/dtc warnings/errors: > > > > I think the bot responds like this if the patch could not be applied. > Probably we can ignore it. It's because I converted dtschema to use pyproject.toml (the newest and 3rd way to do python packaging). I started getting deprecation warnings on debian testing due to using setup.py. Converting breaks on ubuntu 22.04. Seems to be this bug[1]. The CI job should now be fixed by installing the latest pip version. Rob [1] https://bugs.launchpad.net/ubuntu/+source/python-pip/+bug/2018288
On Fri, Aug 11, 2023 at 01:57:51AM +0000, Trevor Wu (吳文良) wrote: > On Thu, 2023-08-10 at 08:32 +0200, Krzysztof Kozlowski wrote: > > The mediatek,mt8188-mt6359 Linux sound machine driver requires the > > "model" property, so binding was incomplete. Reference the common sound > > card properties to fix that which also allows to remove duplicated > > property definitions. Leave the relevant parts of "audio-routing" > > description. > > > Reviewed-by: Rob Herring <robh@kernel.org<mailto:robh@kernel.org>> Something's really wrecked the formatting of this mail...
diff --git a/Documentation/devicetree/bindings/sound/mediatek,mt8188-mt6359.yaml b/Documentation/devicetree/bindings/sound/mediatek,mt8188-mt6359.yaml index 05e532b5d50a..43b3b67bdf3b 100644 --- a/Documentation/devicetree/bindings/sound/mediatek,mt8188-mt6359.yaml +++ b/Documentation/devicetree/bindings/sound/mediatek,mt8188-mt6359.yaml @@ -9,23 +9,19 @@ title: MediaTek MT8188 ASoC sound card maintainers: - Trevor Wu <trevor.wu@mediatek.com> +allOf: + - $ref: sound-card-common.yaml# + properties: compatible: enum: - mediatek,mt8188-mt6359-evb - mediatek,mt8188-nau8825 - model: - $ref: /schemas/types.yaml#/definitions/string - description: User specified audio sound card name - audio-routing: - $ref: /schemas/types.yaml#/definitions/non-unique-string-array description: - A list of the connections between audio components. Each entry is a - sink/source pair of strings. Valid names could be the input or output - widgets of audio components, power supplies, MicBias of codec and the - software switch. + Valid names could be the input or output widgets of audio components, + power supplies, MicBias of codec and the software switch. mediatek,platform: $ref: /schemas/types.yaml#/definitions/phandle @@ -86,7 +82,7 @@ patternProperties: required: - link-name -additionalProperties: false +unevaluatedProperties: false required: - compatible @@ -96,6 +92,7 @@ examples: - | sound { compatible = "mediatek,mt8188-mt6359-evb"; + model = "MT6359-EVB"; mediatek,platform = <&afe>; pinctrl-names = "default"; pinctrl-0 = <&aud_pins_default>;