| Message ID | 20230823151332.28811-14-shawn.sung@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Support IGT in display driver | expand |
Il 23/08/23 17:13, Hsiao Chien Sung ha scritto: > Fix an issue that plane coordinate was not saved when > calling async update. > > Signed-off-by: Hsiao Chien Sung <shawn.sung@mediatek.com> From what I understand, this is a fix for an issue that was present before your newly introduced code. This means that you want to add a Fixes tag, and that you should also send this commit separately from the IGT series. Please do that. Thanks, Angelo > --- > drivers/gpu/drm/mediatek/mtk_drm_plane.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_plane.c b/drivers/gpu/drm/mediatek/mtk_drm_plane.c > index ca22d02375d5..dc19827f6927 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_plane.c > +++ b/drivers/gpu/drm/mediatek/mtk_drm_plane.c > @@ -210,6 +210,8 @@ static void mtk_plane_atomic_async_update(struct drm_plane *plane, > plane->state->src_y = new_state->src_y; > plane->state->src_h = new_state->src_h; > plane->state->src_w = new_state->src_w; > + plane->state->dst.x1 = new_state->dst.x1; > + plane->state->dst.y1 = new_state->dst.y1; > swap(plane->state->fb, new_state->fb); > > mtk_plane_update_new_state(new_state, new_plane_state);
Hi Angelo, On Thu, 2023-09-07 at 14:33 +0200, AngeloGioacchino Del Regno wrote: > Il 23/08/23 17:13, Hsiao Chien Sung ha scritto: > > Fix an issue that plane coordinate was not saved when > > calling async update. > > > > Signed-off-by: Hsiao Chien Sung <shawn.sung@mediatek.com> > > From what I understand, this is a fix for an issue that was present > before > your newly introduced code. > > This means that you want to add a Fixes tag, and that you should also > send > this commit separately from the IGT series. Please do that. Got it, will add a fix tag in the next version. But since without this patch, IGT will fail at some test cases, could we still send them in the same series so IGT can pass out-of-the-box? Thanks, Hsiao Chien Sung
Il 11/09/23 15:45, Shawn Sung (宋孝謙) ha scritto: > Hi Angelo, > > On Thu, 2023-09-07 at 14:33 +0200, AngeloGioacchino Del Regno wrote: >> Il 23/08/23 17:13, Hsiao Chien Sung ha scritto: >>> Fix an issue that plane coordinate was not saved when >>> calling async update. >>> >>> Signed-off-by: Hsiao Chien Sung <shawn.sung@mediatek.com> >> >> From what I understand, this is a fix for an issue that was present >> before >> your newly introduced code. >> >> This means that you want to add a Fixes tag, and that you should also >> send >> this commit separately from the IGT series. Please do that. > > Got it, will add a fix tag in the next version. But since without this > patch, IGT will fail at some test cases, could we still send them in > the same series so IGT can pass out-of-the-box? > Fixes are applied before new features, so if you send this patch outside of the IGT series, this will most likely be applied *before* that series. When the IGT series will be applied, this patch will already be present, so, please send this one separately. Regards, Angelo
Hi Angelo, On Thu, 2023-09-14 at 15:18 +0200, AngeloGioacchino Del Regno wrote: > Il 11/09/23 15:45, Shawn Sung (宋孝謙) ha scritto: > > Hi Angelo, > > > > On Thu, 2023-09-07 at 14:33 +0200, AngeloGioacchino Del Regno > > wrote: > > > Il 23/08/23 17:13, Hsiao Chien Sung ha scritto: > > > > Fix an issue that plane coordinate was not saved when > > > > calling async update. > > > > > > > > Signed-off-by: Hsiao Chien Sung <shawn.sung@mediatek.com> > > > > > > From what I understand, this is a fix for an issue that was > > > present > > > before > > > your newly introduced code. > > > > > > This means that you want to add a Fixes tag, and that you should > > > also > > > send > > > this commit separately from the IGT series. Please do that. > > > > Got it, will add a fix tag in the next version. But since without > > this > > patch, IGT will fail at some test cases, could we still send them > > in > > the same series so IGT can pass out-of-the-box? > > > > Fixes are applied before new features, so if you send this patch > outside > of the IGT series, this will most likely be applied *before* that > series. > > When the IGT series will be applied, this patch will already be > present, > so, please send this one separately. Got it. Had sent two fixes that are found during IGT test separately. Thanks, Hsiao Chien Sung
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_plane.c b/drivers/gpu/drm/mediatek/mtk_drm_plane.c index ca22d02375d5..dc19827f6927 100644 --- a/drivers/gpu/drm/mediatek/mtk_drm_plane.c +++ b/drivers/gpu/drm/mediatek/mtk_drm_plane.c @@ -210,6 +210,8 @@ static void mtk_plane_atomic_async_update(struct drm_plane *plane, plane->state->src_y = new_state->src_y; plane->state->src_h = new_state->src_h; plane->state->src_w = new_state->src_w; + plane->state->dst.x1 = new_state->dst.x1; + plane->state->dst.y1 = new_state->dst.y1; swap(plane->state->fb, new_state->fb); mtk_plane_update_new_state(new_state, new_plane_state);
Fix an issue that plane coordinate was not saved when calling async update. Signed-off-by: Hsiao Chien Sung <shawn.sung@mediatek.com> --- drivers/gpu/drm/mediatek/mtk_drm_plane.c | 2 ++ 1 file changed, 2 insertions(+)