| Message ID | 20231012193737.7251-2-laurent.pinchart@ideasonboard.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | media: i2c: Add driver for THine THP7312 ISP | expand |
On 12/10/2023 21:37, Laurent Pinchart wrote: Thanks for the changes > + > + port: > + $ref: /schemas/graph.yaml#/$defs/port-base > + additionalProperties: false > + > + properties: > + endpoint: > + $ref: /schemas/media/video-interfaces.yaml# > + unevaluatedProperties: false > + > + properties: > + data-lanes: > + description: > + This property is for lane reordering between the THP7312 and the > + SoC. The sensor supports either two-lane, or four-lane operation. > + If this property is omitted four-lane operation is assumed. For > + two-lane operation the property must be set to <1 2>. > + minItems: 2 > + maxItems: 4 > + items: > + maximum: 4 > + > + sensors: > + type: object > + description: List of connected sensors I don't understand why do you list sensors here. From the binding description I understood these are external sensors, which usually sit on I2C bus. > + > + properties: > + "#address-cells": > + const: 1 > + > + "#size-cells": > + const: 0 > + > + patternProperties: > + "^sensor@[01]": > + type: object > + description: > + Sensors connected to the first and second input, with one node per > + sensor. > + > + properties: > + thine,model: > + $ref: /schemas/types.yaml#/definitions/string > + description: > + Model of the connected sensors. Must be a valid compatible string. Then why this isn't compatible? > + > + reg: > + maxItems: 1 > + description: THP7312 input port number > + > + data-lanes: > + $ref: /schemas/media/video-interfaces.yaml#/properties/data-lanes > + items: > + maxItems: 4 > + description: > + This property is for lane reordering between the THP7312 and the imaging > + sensor that it is connected to. > + > + patternProperties: > + ".*-supply": > + description: Power supplies for the sensor > + > + required: > + - reg > + - data-lanes > + > + additionalProperties: false > + > + required: > + - "#address-cells" > + - "#size-cells" > + > + additionalProperties: false > + > +required: > + - compatible > + - reg > + - reset-gpios > + - clocks > + - vddcore-supply > + - vhtermrx-supply > + - vddtx-supply > + - vddhost-supply > + - vddcmos-supply > + - vddgpio-0-supply > + - vddgpio-1-supply > + - sensors > + - port > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/gpio/gpio.h> > + > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + camera@61 { > + compatible = "thine,thp7312"; > + reg = <0x61>; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&cam1_pins_default>; > + > + reset-gpios = <&pio 119 GPIO_ACTIVE_LOW>; > + clocks = <&camera61_clk>; > + > + vddcore-supply = <&vsys_v4p2>; > + vhtermrx-supply = <&vsys_v4p2>; > + vddtx-supply = <&vsys_v4p2>; > + vddhost-supply = <&vsys_v4p2>; > + vddcmos-supply = <&vsys_v4p2>; > + vddgpio-0-supply = <&vsys_v4p2>; > + vddgpio-1-supply = <&vsys_v4p2>; > + > + orientation = <0>; > + rotation = <0>; > + > + sensors { > + #address-cells = <1>; > + #size-cells = <0>; > + > + sensor@0 { > + thine,model = "sony,imx258"; > + reg = <0>; > + > + data-lanes = <4 1 3 2>; > + > + dovdd-supply = <&vsys_v4p2>; > + avdd-supply = <&vsys_v4p2>; > + dvdd-supply = <&vsys_v4p2>; > + }; > + }; > + > + port { > + thp7312_2_endpoint: endpoint { > + remote-endpoint = <&mipi_thp7312_2>; > + data-lanes = <4 2 1 3>; > + }; > + }; > + }; > + }; Best regards, Krzysztof
Hi Krzysztof, On Thu, Oct 12, 2023 at 09:57:38PM +0200, Krzysztof Kozlowski wrote: > On 12/10/2023 21:37, Laurent Pinchart wrote: > > Thanks for the changes You're welcome. Sorry again for missing some of your review comments on v1. > > + > > + port: > > + $ref: /schemas/graph.yaml#/$defs/port-base > > + additionalProperties: false > > + > > + properties: > > + endpoint: > > + $ref: /schemas/media/video-interfaces.yaml# > > + unevaluatedProperties: false > > + > > + properties: > > + data-lanes: > > + description: > > + This property is for lane reordering between the THP7312 and the > > + SoC. The sensor supports either two-lane, or four-lane operation. > > + If this property is omitted four-lane operation is assumed. For > > + two-lane operation the property must be set to <1 2>. > > + minItems: 2 > > + maxItems: 4 > > + items: > > + maximum: 4 > > + > > + sensors: > > + type: object > > + description: List of connected sensors > > I don't understand why do you list sensors here. From the binding > description I understood these are external sensors, which usually sit > on I2C bus. Good question :-) The sensors connected to the THP7312 input are controlled over I2C by the THP7312 itself. The host operating system doesn't have access to that I2C bus. The sensors are listed here because their power supplies need to be controlled by the host operating system. > > + > > + properties: > > + "#address-cells": > > + const: 1 > > + > > + "#size-cells": > > + const: 0 > > + > > + patternProperties: > > + "^sensor@[01]": > > + type: object > > + description: > > + Sensors connected to the first and second input, with one node per > > + sensor. > > + > > + properties: > > + thine,model: > > + $ref: /schemas/types.yaml#/definitions/string > > + description: > > + Model of the connected sensors. Must be a valid compatible string. > > Then why this isn't compatible? We picked a vendor-specific property to avoid implying that the sensor nodes will result in devices being created by the host operating system. I don't mind using "compatible" instead, but as far as I understand, a compatible string implies that corresponding device DT bindings should exist, and that won't be the case here necessarily. > > + > > + reg: > > + maxItems: 1 > > + description: THP7312 input port number > > + > > + data-lanes: > > + $ref: /schemas/media/video-interfaces.yaml#/properties/data-lanes > > + items: > > + maxItems: 4 > > + description: > > + This property is for lane reordering between the THP7312 and the imaging > > + sensor that it is connected to. > > + > > + patternProperties: > > + ".*-supply": > > + description: Power supplies for the sensor > > + > > + required: > > + - reg > > + - data-lanes > > + > > + additionalProperties: false > > + > > + required: > > + - "#address-cells" > > + - "#size-cells" > > + > > + additionalProperties: false > > + > > +required: > > + - compatible > > + - reg > > + - reset-gpios > > + - clocks > > + - vddcore-supply > > + - vhtermrx-supply > > + - vddtx-supply > > + - vddhost-supply > > + - vddcmos-supply > > + - vddgpio-0-supply > > + - vddgpio-1-supply > > + - sensors > > + - port > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + #include <dt-bindings/gpio/gpio.h> > > + > > + i2c { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + camera@61 { > > + compatible = "thine,thp7312"; > > + reg = <0x61>; > > + > > + pinctrl-names = "default"; > > + pinctrl-0 = <&cam1_pins_default>; > > + > > + reset-gpios = <&pio 119 GPIO_ACTIVE_LOW>; > > + clocks = <&camera61_clk>; > > + > > + vddcore-supply = <&vsys_v4p2>; > > + vhtermrx-supply = <&vsys_v4p2>; > > + vddtx-supply = <&vsys_v4p2>; > > + vddhost-supply = <&vsys_v4p2>; > > + vddcmos-supply = <&vsys_v4p2>; > > + vddgpio-0-supply = <&vsys_v4p2>; > > + vddgpio-1-supply = <&vsys_v4p2>; > > + > > + orientation = <0>; > > + rotation = <0>; > > + > > + sensors { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + sensor@0 { > > + thine,model = "sony,imx258"; > > + reg = <0>; > > + > > + data-lanes = <4 1 3 2>; > > + > > + dovdd-supply = <&vsys_v4p2>; > > + avdd-supply = <&vsys_v4p2>; > > + dvdd-supply = <&vsys_v4p2>; > > + }; > > + }; > > + > > + port { > > + thp7312_2_endpoint: endpoint { > > + remote-endpoint = <&mipi_thp7312_2>; > > + data-lanes = <4 2 1 3>; > > + }; > > + }; > > + }; > > + };
On 15/10/2023 14:39, Laurent Pinchart wrote: >>> + properties: >>> + data-lanes: >>> + description: >>> + This property is for lane reordering between the THP7312 and the >>> + SoC. The sensor supports either two-lane, or four-lane operation. >>> + If this property is omitted four-lane operation is assumed. For >>> + two-lane operation the property must be set to <1 2>. >>> + minItems: 2 >>> + maxItems: 4 >>> + items: >>> + maximum: 4 >>> + >>> + sensors: >>> + type: object >>> + description: List of connected sensors >> >> I don't understand why do you list sensors here. From the binding >> description I understood these are external sensors, which usually sit >> on I2C bus. > > Good question :-) > > The sensors connected to the THP7312 input are controlled over I2C by > the THP7312 itself. The host operating system doesn't have access to > that I2C bus. The sensors are listed here because their power supplies > need to be controlled by the host operating system. OK > >>> + >>> + properties: >>> + "#address-cells": >>> + const: 1 >>> + >>> + "#size-cells": >>> + const: 0 >>> + >>> + patternProperties: >>> + "^sensor@[01]": >>> + type: object >>> + description: >>> + Sensors connected to the first and second input, with one node per >>> + sensor. >>> + >>> + properties: >>> + thine,model: >>> + $ref: /schemas/types.yaml#/definitions/string >>> + description: >>> + Model of the connected sensors. Must be a valid compatible string. >> >> Then why this isn't compatible? > > We picked a vendor-specific property to avoid implying that the sensor > nodes will result in devices being created by the host operating system. > I don't mind using "compatible" instead, but as far as I understand, a > compatible string implies that corresponding device DT bindings should > exist, and that won't be the case here necessarily. OK, looks sensible to me. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/media/i2c/thine,thp7312.yaml b/Documentation/devicetree/bindings/media/i2c/thine,thp7312.yaml new file mode 100644 index 000000000000..0758d8d44826 --- /dev/null +++ b/Documentation/devicetree/bindings/media/i2c/thine,thp7312.yaml @@ -0,0 +1,226 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +# Copyright (c) 2023 Ideas on Board +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/media/i2c/thine,thp7312.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: THine THP7312 + +maintainers: + - Paul Elder <paul.elder@@ideasonboard.com> + +description: + The THP7312 is a standalone ISP controlled over i2c, and is capable of + various image processing and correction functions, including 3A control. It + can be connected to CMOS image sensors from various vendors, supporting both + MIPI CSI-2 and parallel interfaces. It can also output on either MIPI CSI-2 + or parallel. The hardware is capable of transmitting and receiving MIPI + interlaved data strams with data types or multiple virtual channel + identifiers. + +allOf: + - $ref: ../video-interface-devices.yaml# + +properties: + compatible: + const: thine,thp7312 + + reg: + maxItems: 1 + + clocks: + maxItems: 1 + description: CLKI clock input + + thine,boot-mode: + $ref: /schemas/types.yaml#/definitions/uint32 + minimum: 0 + maximum: 1 + default: 1 + description: + Boot mode of the THP7312, reflecting the value of the BOOT[0] pin strap. + 0 is for the SPI/2-wire slave boot, 1 is for the SPI master boot (from + external flash ROM). + + reset-gpios: + maxItems: 1 + description: + Reference to the GPIO connected to the RESET_N pin, if any. + Must be released (set high) after all supplies are applied. + + vddcore-supply: + description: + 1.2V supply for core, PLL, MIPI rx and MIPI tx. + + vhtermrx-supply: + description: + Supply for input (RX). 1.8V for MIPI, or 1.8/2.8/3.3V for parallel. + + vddtx-supply: + description: + Supply for output (TX). 1.8V for MIPI, or 1.8/2.8/3.3V for parallel. + + vddhost-supply: + description: + Supply for host interface. 1.8V, 2.8V, or 3.3V. + + vddcmos-supply: + description: + Supply for sensor interface. 1.8V, 2.8V, or 3.3V. + + vddgpio-0-supply: + description: + Supply for GPIO_0. 1.8V, 2.8V, or 3.3V. + + vddgpio-1-supply: + description: + Supply for GPIO_1. 1.8V, 2.8V, or 3.3V. + + orientation: true + rotation: true + + port: + $ref: /schemas/graph.yaml#/$defs/port-base + additionalProperties: false + + properties: + endpoint: + $ref: /schemas/media/video-interfaces.yaml# + unevaluatedProperties: false + + properties: + data-lanes: + description: + This property is for lane reordering between the THP7312 and the + SoC. The sensor supports either two-lane, or four-lane operation. + If this property is omitted four-lane operation is assumed. For + two-lane operation the property must be set to <1 2>. + minItems: 2 + maxItems: 4 + items: + maximum: 4 + + sensors: + type: object + description: List of connected sensors + + properties: + "#address-cells": + const: 1 + + "#size-cells": + const: 0 + + patternProperties: + "^sensor@[01]": + type: object + description: + Sensors connected to the first and second input, with one node per + sensor. + + properties: + thine,model: + $ref: /schemas/types.yaml#/definitions/string + description: + Model of the connected sensors. Must be a valid compatible string. + + reg: + maxItems: 1 + description: THP7312 input port number + + data-lanes: + $ref: /schemas/media/video-interfaces.yaml#/properties/data-lanes + items: + maxItems: 4 + description: + This property is for lane reordering between the THP7312 and the imaging + sensor that it is connected to. + + patternProperties: + ".*-supply": + description: Power supplies for the sensor + + required: + - reg + - data-lanes + + additionalProperties: false + + required: + - "#address-cells" + - "#size-cells" + + additionalProperties: false + +required: + - compatible + - reg + - reset-gpios + - clocks + - vddcore-supply + - vhtermrx-supply + - vddtx-supply + - vddhost-supply + - vddcmos-supply + - vddgpio-0-supply + - vddgpio-1-supply + - sensors + - port + +additionalProperties: false + +examples: + - | + #include <dt-bindings/gpio/gpio.h> + + i2c { + #address-cells = <1>; + #size-cells = <0>; + + camera@61 { + compatible = "thine,thp7312"; + reg = <0x61>; + + pinctrl-names = "default"; + pinctrl-0 = <&cam1_pins_default>; + + reset-gpios = <&pio 119 GPIO_ACTIVE_LOW>; + clocks = <&camera61_clk>; + + vddcore-supply = <&vsys_v4p2>; + vhtermrx-supply = <&vsys_v4p2>; + vddtx-supply = <&vsys_v4p2>; + vddhost-supply = <&vsys_v4p2>; + vddcmos-supply = <&vsys_v4p2>; + vddgpio-0-supply = <&vsys_v4p2>; + vddgpio-1-supply = <&vsys_v4p2>; + + orientation = <0>; + rotation = <0>; + + sensors { + #address-cells = <1>; + #size-cells = <0>; + + sensor@0 { + thine,model = "sony,imx258"; + reg = <0>; + + data-lanes = <4 1 3 2>; + + dovdd-supply = <&vsys_v4p2>; + avdd-supply = <&vsys_v4p2>; + dvdd-supply = <&vsys_v4p2>; + }; + }; + + port { + thp7312_2_endpoint: endpoint { + remote-endpoint = <&mipi_thp7312_2>; + data-lanes = <4 2 1 3>; + }; + }; + }; + }; +... diff --git a/MAINTAINERS b/MAINTAINERS index 83a0c7f3826b..e7d0a4e47a4d 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -21447,6 +21447,13 @@ S: Maintained F: Documentation/ABI/testing/sysfs-class-firmware-attributes F: drivers/platform/x86/think-lmi.? +THP7312 ISP DRIVER +M: Paul Elder <paul.elder@ideasonboard.com> +L: linux-media@vger.kernel.org +S: Maintained +T: git git://linuxtv.org/media_tree.git +F: Documentation/devicetree/bindings/media/i2c/thine,thp7312.yaml + THUNDERBOLT DMA TRAFFIC TEST DRIVER M: Isaac Hazan <isaac.hazan@intel.com> L: linux-usb@vger.kernel.org