diff mbox series

[v2,3/3] ASoC: mediatek: mt8188-mt6359: Limit RT5682s to only supports dual channels

Message ID 20231108012617.3973539-4-zhourui@huaqin.corp-partner.google.com (mailing list archive)
State New
Headers show
Series add es8326 dt-bindings and es8326 support | expand

Commit Message

Rui Zhou Nov. 8, 2023, 1:26 a.m. UTC 
Limit RT5682s to only support dual channels, not four channels.

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Signed-off-by: Rui Zhou <zhourui@huaqin.corp-partner.google.com>
---
 sound/soc/mediatek/mt8188/mt8188-mt6359.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Trevor Wu (吳文良) Nov. 8, 2023, 5:12 a.m. UTC | #1 
On Wed, 2023-11-08 at 09:26 +0800, Rui Zhou wrote:
>  Limit RT5682s to only support dual channels, not four channels.

Hi Rui,

The title is still confusing, maybe update the title based on Angelo's
suggestion in v1[1]?
In addition, please modify the commit description to mention support
for stereo MAX98390 specifically for the mt8188-rt5682s board. Now, it
reads like you are adding the dual RT5682s support.

[1]https://patchwork.kernel.org/comment/25584066/

Thanks,
Trevor

> Reviewed-by: AngeloGioacchino Del Regno <
> angelogioacchino.delregno@collabora.com>
> Signed-off-by: Rui Zhou <zhourui@huaqin.corp-partner.google.com>
> ---
>  sound/soc/mediatek/mt8188/mt8188-mt6359.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/mediatek/mt8188/mt8188-mt6359.c
> b/sound/soc/mediatek/mt8188/mt8188-mt6359.c
> index e994faa3556b..917640939621 100644
> --- a/sound/soc/mediatek/mt8188/mt8188-mt6359.c
> +++ b/sound/soc/mediatek/mt8188/mt8188-mt6359.c
> @@ -1549,7 +1549,7 @@ static struct mt8188_card_data
> mt8188_nau8825_card = {
>  
>  static struct mt8188_card_data mt8188_rt5682s_card = {
>  	.name = "mt8188_rt5682s",
> -	.quirk = RT5682S_HS_PRESENT,
> +	.quirk = RT5682S_HS_PRESENT | MAX98390_TWO_AMP,
>  };
>  
>  static struct mt8188_card_data mt8188_es8326_card = {
> -- 
> 2.25.1
>
AngeloGioacchino Del Regno Nov. 8, 2023, 9:50 a.m. UTC | #2 
Il 08/11/23 06:12, Trevor Wu (吳文良) ha scritto:
> On Wed, 2023-11-08 at 09:26 +0800, Rui Zhou wrote:
>>   Limit RT5682s to only support dual channels, not four channels.
> 
> Hi Rui,
> 
> The title is still confusing, maybe update the title based on Angelo's
> suggestion in v1[1]?
> In addition, please modify the commit description to mention support
> for stereo MAX98390 specifically for the mt8188-rt5682s board. Now, it
> reads like you are adding the dual RT5682s support.
> 
> [1]https://patchwork.kernel.org/comment/25584066/
> 

Actually, there's another alternative, if you like it more:

ASoC: mediatek: mt8188-mt6359: Limit mt8188_rt5682s from quad to dual amp

Cheers,
Angelo

> Thanks,
> Trevor
> 
>> Reviewed-by: AngeloGioacchino Del Regno <
>> angelogioacchino.delregno@collabora.com>
>> Signed-off-by: Rui Zhou <zhourui@huaqin.corp-partner.google.com>
>> ---
>>   sound/soc/mediatek/mt8188/mt8188-mt6359.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/sound/soc/mediatek/mt8188/mt8188-mt6359.c
>> b/sound/soc/mediatek/mt8188/mt8188-mt6359.c
>> index e994faa3556b..917640939621 100644
>> --- a/sound/soc/mediatek/mt8188/mt8188-mt6359.c
>> +++ b/sound/soc/mediatek/mt8188/mt8188-mt6359.c
>> @@ -1549,7 +1549,7 @@ static struct mt8188_card_data
>> mt8188_nau8825_card = {
>>   
>>   static struct mt8188_card_data mt8188_rt5682s_card = {
>>   	.name = "mt8188_rt5682s",
>> -	.quirk = RT5682S_HS_PRESENT,
>> +	.quirk = RT5682S_HS_PRESENT | MAX98390_TWO_AMP,
>>   };
>>   
>>   static struct mt8188_card_data mt8188_es8326_card = {
>> -- 
>> 2.25.1
>>
diff mbox series

Patch

diff --git a/sound/soc/mediatek/mt8188/mt8188-mt6359.c b/sound/soc/mediatek/mt8188/mt8188-mt6359.c
index e994faa3556b..917640939621 100644
--- a/sound/soc/mediatek/mt8188/mt8188-mt6359.c
+++ b/sound/soc/mediatek/mt8188/mt8188-mt6359.c
@@ -1549,7 +1549,7 @@  static struct mt8188_card_data mt8188_nau8825_card = {
 
 static struct mt8188_card_data mt8188_rt5682s_card = {
 	.name = "mt8188_rt5682s",
-	.quirk = RT5682S_HS_PRESENT,
+	.quirk = RT5682S_HS_PRESENT | MAX98390_TWO_AMP,
 };
 
 static struct mt8188_card_data mt8188_es8326_card = {