diff mbox series

[v2] arm64: dts: mt8173: Add G2Touch touchscreen node

Message ID 20231115043511.2670477-1-treapking@chromium.org (mailing list archive)
State New
Headers show
Series [v2] arm64: dts: mt8173: Add G2Touch touchscreen node | expand

Commit Message

Pin-yen Lin Nov. 15, 2023, 4:35 a.m. UTC 
Lenovo Ideapad C330 Chromebook (MTK) uses G2Touch touchscreen as a
second source component.

Signed-off-by: Pin-yen Lin <treapking@chromium.org>
Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
---

Changes in v2:
- Remove the label for the node

 arch/arm64/boot/dts/mediatek/mt8173-elm-hana.dtsi | 8 ++++++++
 1 file changed, 8 insertions(+)

Comments

Chen-Yu Tsai Nov. 15, 2023, 6:08 a.m. UTC | #1 
On Wed, Nov 15, 2023 at 12:35 PM Pin-yen Lin <treapking@chromium.org> wrote:
>
> Lenovo Ideapad C330 Chromebook (MTK) uses G2Touch touchscreen as a
> second source component.
>
> Signed-off-by: Pin-yen Lin <treapking@chromium.org>
> Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>

I assume this patch will get merged relatively soon. I can base my DT
probing work on top of it, instead of having roughly the same patch
in my series.

> ---
>
> Changes in v2:
> - Remove the label for the node
>
>  arch/arm64/boot/dts/mediatek/mt8173-elm-hana.dtsi | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm-hana.dtsi b/arch/arm64/boot/dts/mediatek/mt8173-elm-hana.dtsi
> index bdcd35cecad9..8836ac3c4233 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8173-elm-hana.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8173-elm-hana.dtsi
> @@ -29,6 +29,14 @@ touchscreen3: touchscreen@20 {
>                 interrupt-parent = <&pio>;
>                 interrupts = <88 IRQ_TYPE_LEVEL_LOW>;
>         };
> +
> +       touchscreen@40 {
> +               compatible = "hid-over-i2c";
> +               reg = <0x40>;
> +               hid-descr-addr = <0x0001>;
> +               interrupt-parent = <&pio>;
> +               interrupts = <88 IRQ_TYPE_LEVEL_LOW>;

I assume Angelo might ask you to use interrupts-extended instead, but
I'd argue it's better to be consistent throughout the file.

> +       };
>  };
>
>  &i2c4 {
> --
> 2.43.0.rc0.421.g78406f8d94-goog
>
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm-hana.dtsi b/arch/arm64/boot/dts/mediatek/mt8173-elm-hana.dtsi
index bdcd35cecad9..8836ac3c4233 100644
--- a/arch/arm64/boot/dts/mediatek/mt8173-elm-hana.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8173-elm-hana.dtsi
@@ -29,6 +29,14 @@  touchscreen3: touchscreen@20 {
 		interrupt-parent = <&pio>;
 		interrupts = <88 IRQ_TYPE_LEVEL_LOW>;
 	};
+
+	touchscreen@40 {
+		compatible = "hid-over-i2c";
+		reg = <0x40>;
+		hid-descr-addr = <0x0001>;
+		interrupt-parent = <&pio>;
+		interrupts = <88 IRQ_TYPE_LEVEL_LOW>;
+	};
 };
 
 &i2c4 {