| Message ID | 20231116093512.4180240-5-zhourui@huaqin.corp-partner.google.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | add es8326 dt-bindings, commonize headset codec API, es8326 support and Enable dual amp for rt5682s | expand |
On Thu, 2023-11-16 at 17:35 +0800, Rui Zhou wrote: > > Enable support for dual MAX98390 amplifiers on the mt8188-rt5682s > board. > > Reviewed-by: AngeloGioacchino Del Regno < > angelogioacchino.delregno@collabora.com> > Signed-off-by: Rui Zhou <zhourui@huaqin.corp-partner.google.com> Reviewed-by: Trevor Wu <trevor.wu@mediatek.com> Thanks, Trevor
On Mon, Dec 04, 2023 at 02:16:39PM +0800, Rui Zhou wrote: > Hi Mark, > Please help review this patch, thank you very much! Please don't send content free pings and please allow a reasonable time for review. People get busy, go on holiday, attend conferences and so on so unless there is some reason for urgency (like critical bug fixes) please allow at least a couple of weeks for review. If there have been review comments then people may be waiting for those to be addressed. Sending content free pings adds to the mail volume (if they are seen at all) which is often the problem and since they can't be reviewed directly if something has gone wrong you'll have to resend the patches anyway, so sending again is generally a better approach though there are some other maintainers who like them - if in doubt look at how patches for the subsystem are normally handled.
diff --git a/sound/soc/mediatek/mt8188/mt8188-mt6359.c b/sound/soc/mediatek/mt8188/mt8188-mt6359.c index 96c39f4e4b70..be450292f351 100644 --- a/sound/soc/mediatek/mt8188/mt8188-mt6359.c +++ b/sound/soc/mediatek/mt8188/mt8188-mt6359.c @@ -1443,7 +1443,7 @@ static struct mt8188_card_data mt8188_nau8825_card = { static struct mt8188_card_data mt8188_rt5682s_card = { .name = "mt8188_rt5682s", - .quirk = RT5682S_HS_PRESENT, + .quirk = RT5682S_HS_PRESENT | MAX98390_TWO_AMP, }; static struct mt8188_card_data mt8188_es8326_card = {