| Message ID | 20231212100657.3115089-1-shitao@kylinos.cn (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | usb: mtu3: fix comment typo | expand |
On Tue, Dec 12, 2023 at 06:06:57PM +0800, shitao wrote: > Fix comment typo in mtu3_qmu.c file. > "empty" is misspelled as "emtpy". > > Reported-by: k2ci <kernel-bot@kylinos.cn> > Signed-off-by: shitao <shitao@kylinos.cn> > --- > drivers/usb/mtu3/mtu3_qmu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/mtu3/mtu3_qmu.c b/drivers/usb/mtu3/mtu3_qmu.c > index 3d77408e3133..03f26589b056 100644 > --- a/drivers/usb/mtu3/mtu3_qmu.c > +++ b/drivers/usb/mtu3/mtu3_qmu.c > @@ -221,7 +221,7 @@ static struct qmu_gpd *advance_deq_gpd(struct mtu3_gpd_ring *ring) > return ring->dequeue; > } > > -/* check if a ring is emtpy */ > +/* check if a ring is empty */ > static bool gpd_ring_empty(struct mtu3_gpd_ring *ring) > { > struct qmu_gpd *enq = ring->enqueue; > -- > 2.34.1 > > Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - This looks like a new version of a previously submitted patch, but you did not list below the --- line any changes from the previous version. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/process/submitting-patches.rst for what needs to be done here to properly describe this. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot
On Tue, Dec 12, 2023 at 07:09:59PM +0800, shitao wrote: > Reported-by: k2ci <kernel-bot@kylinos.cn> > Signed-off-by: shitao <shitao@kylinos.cn> > --- > Hi, > according to your suggestion, I have split it into two patches and added some simple instructions. > This is about fixing the misspelling of "empty" in the mtu3_qmu.c file. > thanks. > drivers/usb/mtu3/mtu3_qmu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/mtu3/mtu3_qmu.c b/drivers/usb/mtu3/mtu3_qmu.c > index 3d77408e3133..03f26589b056 100644 > --- a/drivers/usb/mtu3/mtu3_qmu.c > +++ b/drivers/usb/mtu3/mtu3_qmu.c > @@ -221,7 +221,7 @@ static struct qmu_gpd *advance_deq_gpd(struct mtu3_gpd_ring *ring) > return ring->dequeue; > } > > -/* check if a ring is emtpy */ > +/* check if a ring is empty */ > static bool gpd_ring_empty(struct mtu3_gpd_ring *ring) > { > struct qmu_gpd *enq = ring->enqueue; > -- > 2.34.1 > I would strongly suggest that you practice kernel patches in the drivers/staging/ portion of the kernel, as that is where people learn how to do this properly, and not bother other subsystems or developers. Please start there and learn the basics, and then you can move to other portions of the kernel as you will not be making simple mistakes like you are here (hint, you forgot to version your patch, AND you forgot a changelog...) thanks, greg k-h
diff --git a/drivers/usb/mtu3/mtu3_qmu.c b/drivers/usb/mtu3/mtu3_qmu.c index 3d77408e3133..03f26589b056 100644 --- a/drivers/usb/mtu3/mtu3_qmu.c +++ b/drivers/usb/mtu3/mtu3_qmu.c @@ -221,7 +221,7 @@ static struct qmu_gpd *advance_deq_gpd(struct mtu3_gpd_ring *ring) return ring->dequeue; } -/* check if a ring is emtpy */ +/* check if a ring is empty */ static bool gpd_ring_empty(struct mtu3_gpd_ring *ring) { struct qmu_gpd *enq = ring->enqueue;
Fix comment typo in mtu3_qmu.c file. "empty" is misspelled as "emtpy". Reported-by: k2ci <kernel-bot@kylinos.cn> Signed-off-by: shitao <shitao@kylinos.cn> --- drivers/usb/mtu3/mtu3_qmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)