| Message ID | 20231218083604.7327-3-jason-jh.lin@mediatek.com (mailing list archive) |
|---|---|
| State | New |
| Delegated to: | Matthias Brugger |
| Headers | show |
| Series | Add mediatek,gce-events definition to mediatek,gce-mailbox bindings | expand |
On 18/12/2023 09:36, Jason-JH.Lin wrote: > Change the description of mediatek,gce-events property to reference > mediatek,gce-mailbox.yaml. > > Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com> > --- > .../devicetree/bindings/media/mediatek,mdp3-rdma.yaml | 5 +---- > .../devicetree/bindings/media/mediatek,mdp3-rsz.yaml | 5 +---- > .../devicetree/bindings/media/mediatek,mdp3-wrot.yaml | 5 +---- > 3 files changed, 3 insertions(+), 12 deletions(-) > > diff --git a/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml b/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml > index 7032c7e15039..adb3df4731f6 100644 > --- a/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml > +++ b/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml > @@ -40,10 +40,7 @@ properties: > > mediatek,gce-events: > description: > - The event id which is mapping to the specific hardware event signal > - to gce. The event id is defined in the gce header > - include/dt-bindings/gce/<chip>-gce.h of each chips. > - $ref: /schemas/types.yaml#/definitions/uint32-array > + Reference to Documentation/devicetree/bindings/mailbox/mediatek,gce-mailbox.yaml. There is no reference here. You allow now any type. This does not make any sense. Best regards, Krzysztof
Hi Thanks for the reviews. On Wed, 2023-12-20 at 08:06 +0100, Krzysztof Kozlowski wrote: > > External email : Please do not click links or open attachments until > you have verified the sender or the content. > On 18/12/2023 09:36, Jason-JH.Lin wrote: > > Change the description of mediatek,gce-events property to reference > > mediatek,gce-mailbox.yaml. > > > > Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com> > > --- > > .../devicetree/bindings/media/mediatek,mdp3-rdma.yaml | 5 > +---- > > .../devicetree/bindings/media/mediatek,mdp3-rsz.yaml | 5 > +---- > > .../devicetree/bindings/media/mediatek,mdp3-wrot.yaml | 5 > +---- > > 3 files changed, 3 insertions(+), 12 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/media/mediatek,mdp3- > rdma.yaml b/Documentation/devicetree/bindings/media/mediatek,mdp3- > rdma.yaml > > index 7032c7e15039..adb3df4731f6 100644 > > --- a/Documentation/devicetree/bindings/media/mediatek,mdp3- > rdma.yaml > > +++ b/Documentation/devicetree/bindings/media/mediatek,mdp3- > rdma.yaml > > @@ -40,10 +40,7 @@ properties: > > > > mediatek,gce-events: > > description: > > - The event id which is mapping to the specific hardware event > signal > > - to gce. The event id is defined in the gce header > > - include/dt-bindings/gce/<chip>-gce.h of each chips. > > - $ref: /schemas/types.yaml#/definitions/uint32-array > > + Reference to > Documentation/devicetree/bindings/mailbox/mediatek,gce-mailbox.yaml. > > There is no reference here. You allow now any type. This does not > make > any sense. Since this property for the GCE HW are MediaTek specific, I will try to refer to nvidia,tegra210-quad-peripheral-props.yaml and send a series for creating a mediatek,gce-props.yaml to list all these properties related to GCE. And change all these properties in mailbox consumers to reference mediatek,gce-props.yaml. allOf: - $ref: mediatek,gce-props.yaml Regards, Jason-JH.Lin > > Best regards, > Krzysztof >
diff --git a/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml b/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml index 7032c7e15039..adb3df4731f6 100644 --- a/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml +++ b/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml @@ -40,10 +40,7 @@ properties: mediatek,gce-events: description: - The event id which is mapping to the specific hardware event signal - to gce. The event id is defined in the gce header - include/dt-bindings/gce/<chip>-gce.h of each chips. - $ref: /schemas/types.yaml#/definitions/uint32-array + Reference to Documentation/devicetree/bindings/mailbox/mediatek,gce-mailbox.yaml. power-domains: maxItems: 1 diff --git a/Documentation/devicetree/bindings/media/mediatek,mdp3-rsz.yaml b/Documentation/devicetree/bindings/media/mediatek,mdp3-rsz.yaml index 78f9de6192ef..ddf66e3d5ad7 100644 --- a/Documentation/devicetree/bindings/media/mediatek,mdp3-rsz.yaml +++ b/Documentation/devicetree/bindings/media/mediatek,mdp3-rsz.yaml @@ -36,10 +36,7 @@ properties: mediatek,gce-events: description: - The event id which is mapping to the specific hardware event signal - to gce. The event id is defined in the gce header - include/dt-bindings/gce/<chip>-gce.h of each chips. - $ref: /schemas/types.yaml#/definitions/uint32-array + Reference to Documentation/devicetree/bindings/mailbox/mediatek,gce-mailbox.yaml. clocks: minItems: 1 diff --git a/Documentation/devicetree/bindings/media/mediatek,mdp3-wrot.yaml b/Documentation/devicetree/bindings/media/mediatek,mdp3-wrot.yaml index 0baa77198fa2..ca37b45e24b4 100644 --- a/Documentation/devicetree/bindings/media/mediatek,mdp3-wrot.yaml +++ b/Documentation/devicetree/bindings/media/mediatek,mdp3-wrot.yaml @@ -36,10 +36,7 @@ properties: mediatek,gce-events: description: - The event id which is mapping to the specific hardware event signal - to gce. The event id is defined in the gce header - include/dt-bindings/gce/<chip>-gce.h of each chips. - $ref: /schemas/types.yaml#/definitions/uint32-array + Reference to Documentation/devicetree/bindings/mailbox/mediatek,gce-mailbox.yaml. power-domains: maxItems: 1
Change the description of mediatek,gce-events property to reference mediatek,gce-mailbox.yaml. Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com> --- .../devicetree/bindings/media/mediatek,mdp3-rdma.yaml | 5 +---- .../devicetree/bindings/media/mediatek,mdp3-rsz.yaml | 5 +---- .../devicetree/bindings/media/mediatek,mdp3-wrot.yaml | 5 +---- 3 files changed, 3 insertions(+), 12 deletions(-)