| Message ID | 20231220025842.7082-3-chunfeng.yun@mediatek.com (mailing list archive) |
|---|---|
| State | New |
| Delegated to: | Matthias Brugger |
| Headers | show |
| Series | [v3,1/3] dt-bindings: usb: mtk-xhci: add a property for Gen1 isoc-in transfer issue | expand |
Il 20/12/23 03:58, Chunfeng Yun ha scritto: > Add the quirk property "rx-fifo-depth" to work around Gen1 isoc-in > transfer issue which send out unexpected ACK even after device > already finished the burst transfer with a short patcket, specially > for a 4K camera device. > > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> > --- > v3: change value according to binding > v2: use 'rx-fifo-depth' property > --- > arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi b/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi > index dd5b89b73190..58593348b810 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi > @@ -1185,6 +1185,7 @@ > Can you please place rx-fifo-depth before power supplies? after which, Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Thanks, Angelo > vusb33-supply = <&mt6359_vusb_ldo_reg>; > vbus-supply = <&usb_vbus>; > + rx-fifo-depth = <3>; > }; > > &xhci1 { > @@ -1192,6 +1193,7 @@ > > vusb33-supply = <&mt6359_vusb_ldo_reg>; > vbus-supply = <&usb_vbus>; > + rx-fifo-depth = <3>; > }; > > &xhci2 {
On Wed, 2023-12-20 at 11:30 +0100, AngeloGioacchino Del Regno wrote: > Il 20/12/23 03:58, Chunfeng Yun ha scritto: > > Add the quirk property "rx-fifo-depth" to work around Gen1 isoc-in > > transfer issue which send out unexpected ACK even after device > > already finished the burst transfer with a short patcket, specially > > for a 4K camera device. > > > > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> > > --- > > v3: change value according to binding > > v2: use 'rx-fifo-depth' property > > --- > > arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi > > b/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi > > index dd5b89b73190..58593348b810 100644 > > --- a/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi > > +++ b/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi > > @@ -1185,6 +1185,7 @@ > > > > Can you please place rx-fifo-depth before power supplies? Ok, thanks > > after which, > > Reviewed-by: AngeloGioacchino Del Regno < > angelogioacchino.delregno@collabora.com> > > Thanks, > Angelo > > > vusb33-supply = <&mt6359_vusb_ldo_reg>; > > vbus-supply = <&usb_vbus>; > > + rx-fifo-depth = <3>; > > }; > > > > &xhci1 { > > @@ -1192,6 +1193,7 @@ > > > > vusb33-supply = <&mt6359_vusb_ldo_reg>; > > vbus-supply = <&usb_vbus>; > > + rx-fifo-depth = <3>; > > }; > > > > &xhci2 { > >
diff --git a/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi b/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi index dd5b89b73190..58593348b810 100644 --- a/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi @@ -1185,6 +1185,7 @@ vusb33-supply = <&mt6359_vusb_ldo_reg>; vbus-supply = <&usb_vbus>; + rx-fifo-depth = <3>; }; &xhci1 { @@ -1192,6 +1193,7 @@ vusb33-supply = <&mt6359_vusb_ldo_reg>; vbus-supply = <&usb_vbus>; + rx-fifo-depth = <3>; }; &xhci2 {
Add the quirk property "rx-fifo-depth" to work around Gen1 isoc-in transfer issue which send out unexpected ACK even after device already finished the burst transfer with a short patcket, specially for a 4K camera device. Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> --- v3: change value according to binding v2: use 'rx-fifo-depth' property --- arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi | 2 ++ 1 file changed, 2 insertions(+)