| Message ID | 20240111195335.871096-1-nfraprado@collabora.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | arm64: dts: mt8183: juniper: Remove CrosEC base detection node | expand |
On Fri, Jan 12, 2024 at 3:55 AM Nícolas F. R. A. Prado <nfraprado@collabora.com> wrote: > > The cbas node is used to describe base detection functionality in the > ChromeOS EC, which is used for units that have a detachable keyboard and > thus rely on this functionality to switch between tablet and laptop > mode. > > The juniper-sku16 machine is a convertible, meaning the keyboard can be > flipped but not detached. The detection for the keyboard getting > flipped is handled by the driver bound to the keyboard-controller > node in the EC. We could do this for the whole jacuzzi family, which are all clamshell or convertibles. ChenYu > Since there is no base detection in this machine, and the device backed > by this node fails to probe and goes unused, delete the node from the > DT. > > Fixes: 4fa8492d1e5b ("arm64: dts: mt8183: add cbas node under cros_ec") > Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> > > --- > > .../boot/dts/mediatek/mt8183-kukui-jacuzzi-juniper-sku16.dts | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-juniper-sku16.dts b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-juniper-sku16.dts > index 8ac6bf5b17f9..8096ca215258 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-juniper-sku16.dts > +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-juniper-sku16.dts > @@ -13,3 +13,6 @@ / { > compatible = "google,juniper-sku16", "google,juniper", "mediatek,mt8183"; > }; > > +&cros_ec { > + /delete-node/ cbas; > +}; > -- > 2.43.0 > >
On Fri, Jan 12, 2024 at 03:10:12PM +0800, Chen-Yu Tsai wrote: > On Fri, Jan 12, 2024 at 3:55 AM Nícolas F. R. A. Prado > <nfraprado@collabora.com> wrote: > > > > The cbas node is used to describe base detection functionality in the > > ChromeOS EC, which is used for units that have a detachable keyboard and > > thus rely on this functionality to switch between tablet and laptop > > mode. > > > > The juniper-sku16 machine is a convertible, meaning the keyboard can be > > flipped but not detached. The detection for the keyboard getting > > flipped is handled by the driver bound to the keyboard-controller > > node in the EC. > > We could do this for the whole jacuzzi family, which are all clamshell > or convertibles. Ah that's great info, thanks! I suspected so but since this unit was the only one that I could actually test the change on, I decided to stick to it. I'll send a v2 removing the node at the jacuzzi dtsi level then. Thanks, Nícolas
diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-juniper-sku16.dts b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-juniper-sku16.dts index 8ac6bf5b17f9..8096ca215258 100644 --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-juniper-sku16.dts +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-juniper-sku16.dts @@ -13,3 +13,6 @@ / { compatible = "google,juniper-sku16", "google,juniper", "mediatek,mt8183"; }; +&cros_ec { + /delete-node/ cbas; +};
The cbas node is used to describe base detection functionality in the ChromeOS EC, which is used for units that have a detachable keyboard and thus rely on this functionality to switch between tablet and laptop mode. The juniper-sku16 machine is a convertible, meaning the keyboard can be flipped but not detached. The detection for the keyboard getting flipped is handled by the driver bound to the keyboard-controller node in the EC. Since there is no base detection in this machine, and the device backed by this node fails to probe and goes unused, delete the node from the DT. Fixes: 4fa8492d1e5b ("arm64: dts: mt8183: add cbas node under cros_ec") Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> --- .../boot/dts/mediatek/mt8183-kukui-jacuzzi-juniper-sku16.dts | 3 +++ 1 file changed, 3 insertions(+)