| Message ID | 20240229-gce-client-reg-log-dbg-v2-1-4975077173d0@collabora.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [v2] soc: mediatek: cmdq: Don't log an error when gce-client-reg is not found | expand |
Il 29/02/24 20:51, Nícolas F. R. A. Prado ha scritto: > Most of the callers to this function do not require CMDQ support, it is > optional, so the missing property shouldn't cause an error message. > However, it could result on degraded performance, so the fact that it's > missing should still be alerted. Furthermore, the callers that do > require CMDQ support already log at the error level when an error is > returned. > > Change the log message in this helper to be printed at the warning level > instead. > > Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> Ok, this is good now. Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > --- > Changes in v2: > - Changed from debug to warning level > - Tweaked commit message to mention performance penalty of not having > GCE > - Link to v1: https://lore.kernel.org/r/20240226-gce-client-reg-log-dbg-v1-1-f0fff97c30c7@collabora.com > --- > drivers/soc/mediatek/mtk-cmdq-helper.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c b/drivers/soc/mediatek/mtk-cmdq-helper.c > index b0cd071c4719..943e9055dd1f 100644 > --- a/drivers/soc/mediatek/mtk-cmdq-helper.c > +++ b/drivers/soc/mediatek/mtk-cmdq-helper.c > @@ -55,7 +55,7 @@ int cmdq_dev_get_client_reg(struct device *dev, > "mediatek,gce-client-reg", > 3, idx, &spec); > if (err < 0) { > - dev_err(dev, > + dev_warn(dev, > "error %d can't parse gce-client-reg property (%d)", > err, idx); > > > --- > base-commit: 41913bcddc83b131649ee8ff0d9ff29e01731398 > change-id: 20240226-gce-client-reg-log-dbg-5ae9637a08ed > > Best regards,
On Thu, 29 Feb 2024 14:51:08 -0500, Nícolas F. R. A. Prado wrote: > Most of the callers to this function do not require CMDQ support, it is > optional, so the missing property shouldn't cause an error message. > However, it could result on degraded performance, so the fact that it's > missing should still be alerted. Furthermore, the callers that do > require CMDQ support already log at the error level when an error is > returned. > > [...] Applied to v6.9-next/soc, thanks! [1/1] soc: mediatek: cmdq: Don't log an error when gce-client-reg is not found commit: ef964918d42b9d9cf534754f82ccdaa402783ecd Cheers, Angelo
diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c b/drivers/soc/mediatek/mtk-cmdq-helper.c index b0cd071c4719..943e9055dd1f 100644 --- a/drivers/soc/mediatek/mtk-cmdq-helper.c +++ b/drivers/soc/mediatek/mtk-cmdq-helper.c @@ -55,7 +55,7 @@ int cmdq_dev_get_client_reg(struct device *dev, "mediatek,gce-client-reg", 3, idx, &spec); if (err < 0) { - dev_err(dev, + dev_warn(dev, "error %d can't parse gce-client-reg property (%d)", err, idx);
Most of the callers to this function do not require CMDQ support, it is optional, so the missing property shouldn't cause an error message. However, it could result on degraded performance, so the fact that it's missing should still be alerted. Furthermore, the callers that do require CMDQ support already log at the error level when an error is returned. Change the log message in this helper to be printed at the warning level instead. Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> --- Changes in v2: - Changed from debug to warning level - Tweaked commit message to mention performance penalty of not having GCE - Link to v1: https://lore.kernel.org/r/20240226-gce-client-reg-log-dbg-v1-1-f0fff97c30c7@collabora.com --- drivers/soc/mediatek/mtk-cmdq-helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- base-commit: 41913bcddc83b131649ee8ff0d9ff29e01731398 change-id: 20240226-gce-client-reg-log-dbg-5ae9637a08ed Best regards,