diff mbox series

[v6,11/14] drm/mediatek: Support "None" alpha blending in Mixer

Message ID 20240322052829.9893-12-shawn.sung@mediatek.com (mailing list archive)
State New
Headers show
Series Support IGT in display driver | expand

Commit Message

Shawn Sung March 22, 2024, 5:28 a.m. UTC 
From: Hsiao Chien Sung <shawn.sung@mediatek.com>

Support "None" blend mode on MediaTek's chips.

Please refer to the description of the commit
"drm/mediatek: Support alpha blending in display driver"
for more information.

Signed-off-by: Hsiao Chien Sung <shawn.sung@mediatek.com>
---
 drivers/gpu/drm/mediatek/mtk_ethdr.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

CK Hu (胡俊光) March 25, 2024, 2:03 a.m. UTC | #1 
Hi, Shawn:

On Fri, 2024-03-22 at 13:28 +0800, Shawn Sung wrote:
> From: Hsiao Chien Sung <shawn.sung@mediatek.com>
> 
> Support "None" blend mode on MediaTek's chips.
> 
> Please refer to the description of the commit
> "drm/mediatek: Support alpha blending in display driver"
> for more information.

But I would like you to describe the information in this patch instead
of referring to another patch. This patch could describe more detail,
and the integration patch could describe more brief.

Regards,
CK

> 
> Signed-off-by: Hsiao Chien Sung <shawn.sung@mediatek.com>
> ---
>  drivers/gpu/drm/mediatek/mtk_ethdr.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/mediatek/mtk_ethdr.c
> b/drivers/gpu/drm/mediatek/mtk_ethdr.c
> index 4b12ca285e84b..951e3e82a6a1a 100644
> --- a/drivers/gpu/drm/mediatek/mtk_ethdr.c
> +++ b/drivers/gpu/drm/mediatek/mtk_ethdr.c
> @@ -178,7 +178,8 @@ void mtk_ethdr_layer_config(struct device *dev,
> unsigned int idx,
>  	if (state->base.pixel_blend_mode != DRM_MODE_BLEND_COVERAGE)
>  		mix_con |= PREMULTI_SOURCE;
>  
> -	if (state->base.fb && !state->base.fb->format->has_alpha) {
> +	if (state->base.pixel_blend_mode == DRM_MODE_BLEND_PIXEL_NONE
> ||
> +	    (state->base.fb && !state->base.fb->format->has_alpha)) {
>  		/*
>  		 * Mixer doesn't support CONST_BLD mode,
>  		 * use a trick to make the output equivalent
Shawn Sung March 28, 2024, 2:56 a.m. UTC | #2 
Hi CK,

On Mon, 2024-03-25 at 02:03 +0000, CK Hu (胡俊光) wrote:
> Hi, Shawn:
> 
> On Fri, 2024-03-22 at 13:28 +0800, Shawn Sung wrote:
> > From: Hsiao Chien Sung <shawn.sung@mediatek.com>
> > 
> > Support "None" blend mode on MediaTek's chips.
> > 
> > Please refer to the description of the commit
> > "drm/mediatek: Support alpha blending in display driver"
> > for more information.
> 
> But I would like you to describe the information in this patch
> instead
> of referring to another patch. This patch could describe more detail,
> and the integration patch could describe more brief.
> 

Got it. Will try to add more information to all the related patches.

Thanks,
Shawn
diff mbox series

Patch

diff --git a/drivers/gpu/drm/mediatek/mtk_ethdr.c b/drivers/gpu/drm/mediatek/mtk_ethdr.c
index 4b12ca285e84b..951e3e82a6a1a 100644
--- a/drivers/gpu/drm/mediatek/mtk_ethdr.c
+++ b/drivers/gpu/drm/mediatek/mtk_ethdr.c
@@ -178,7 +178,8 @@  void mtk_ethdr_layer_config(struct device *dev, unsigned int idx,
 	if (state->base.pixel_blend_mode != DRM_MODE_BLEND_COVERAGE)
 		mix_con |= PREMULTI_SOURCE;
 
-	if (state->base.fb && !state->base.fb->format->has_alpha) {
+	if (state->base.pixel_blend_mode == DRM_MODE_BLEND_PIXEL_NONE ||
+	    (state->base.fb && !state->base.fb->format->has_alpha)) {
 		/*
 		 * Mixer doesn't support CONST_BLD mode,
 		 * use a trick to make the output equivalent