| Message ID | 20240322092845.381313-2-angelogioacchino.delregno@collabora.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Support MediaTek MT8188 Media Data Path 3 (MDP3) | expand |
On Fri, Mar 22, 2024 at 10:28:42AM +0100, AngeloGioacchino Del Regno wrote: > Add compatible for MT8188 VPP mutex. > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> You should at least mention the difference between this any anything else. Acked-by: Conor Dooley <conor.dooley@microchip.com> Thanks, Conor. > --- > .../devicetree/bindings/soc/mediatek/mediatek,mutex.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex.yaml b/Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex.yaml > index ba2014a8725c..a10326a9683d 100644 > --- a/Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex.yaml > +++ b/Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex.yaml > @@ -33,6 +33,7 @@ properties: > - mediatek,mt8186-disp-mutex > - mediatek,mt8186-mdp3-mutex > - mediatek,mt8188-disp-mutex > + - mediatek,mt8188-vpp-mutex > - mediatek,mt8192-disp-mutex > - mediatek,mt8195-disp-mutex > - mediatek,mt8195-vpp-mutex > -- > 2.44.0 >
Il 22/03/24 18:42, Conor Dooley ha scritto: > On Fri, Mar 22, 2024 at 10:28:42AM +0100, AngeloGioacchino Del Regno wrote: >> Add compatible for MT8188 VPP mutex. >> >> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > > You should at least mention the difference between this any anything > else. > Acked-by: Conor Dooley <conor.dooley@microchip.com> It's exactly always the same difference for MuteX blocks: different bits to activate mute for some IP ... but yeah, you're right, I'll shoot a word about this in the commit description on v2 (waiting a bit before doing that anyway). Thank you! Cheers, Angelo > > Thanks, > Conor. > >> --- >> .../devicetree/bindings/soc/mediatek/mediatek,mutex.yaml | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex.yaml b/Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex.yaml >> index ba2014a8725c..a10326a9683d 100644 >> --- a/Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex.yaml >> +++ b/Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex.yaml >> @@ -33,6 +33,7 @@ properties: >> - mediatek,mt8186-disp-mutex >> - mediatek,mt8186-mdp3-mutex >> - mediatek,mt8188-disp-mutex >> + - mediatek,mt8188-vpp-mutex >> - mediatek,mt8192-disp-mutex >> - mediatek,mt8195-disp-mutex >> - mediatek,mt8195-vpp-mutex >> -- >> 2.44.0 >>
On Mon, Mar 25, 2024 at 09:23:58AM +0100, AngeloGioacchino Del Regno wrote: > Il 22/03/24 18:42, Conor Dooley ha scritto: > > On Fri, Mar 22, 2024 at 10:28:42AM +0100, AngeloGioacchino Del Regno wrote: > > > Add compatible for MT8188 VPP mutex. > > > > > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > > > > You should at least mention the difference between this any anything > > else. > > Acked-by: Conor Dooley <conor.dooley@microchip.com> > > It's exactly always the same difference for MuteX blocks: different bits to > activate mute for some IP ... but yeah, you're right, I'll shoot a word about > this in the commit description on v2 (waiting a bit before doing that anyway). Yah, I'm just pointing it out because it goes from an immediate ack to having check the binding in-tree to see that this is an enum (although that's due to the shitty looking diff that you can't avoid) and check the driver patch to see that this is in fact a difference before acking. I wouldn't bother sending a v2 if this was the only thing, seems like a waste of your effort.
diff --git a/Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex.yaml b/Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex.yaml index ba2014a8725c..a10326a9683d 100644 --- a/Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex.yaml +++ b/Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex.yaml @@ -33,6 +33,7 @@ properties: - mediatek,mt8186-disp-mutex - mediatek,mt8186-mdp3-mutex - mediatek,mt8188-disp-mutex + - mediatek,mt8188-vpp-mutex - mediatek,mt8192-disp-mutex - mediatek,mt8195-disp-mutex - mediatek,mt8195-vpp-mutex
Add compatible for MT8188 VPP mutex. Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> --- .../devicetree/bindings/soc/mediatek/mediatek,mutex.yaml | 1 + 1 file changed, 1 insertion(+)