| Message ID | 20240412084128.24452-1-hao.qin@mediatek.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Bluetooth: btusb: mediatek: Add usb reset for firmware setup failure | expand |
Hi, On Fri, Apr 12, 2024 at 4:43 AM Hao Qin <hao.qin@mediatek.com> wrote: > > Add usb reset to recover BT device from a firmware setup failure, > it will restore the device to its original state and attempt setup > firmware again. > > Signed-off-by: Hao Qin <hao.qin@mediatek.com> > --- > drivers/bluetooth/btusb.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c > index 4c0cc13adb47..c5aab361795e 100644 > --- a/drivers/bluetooth/btusb.c > +++ b/drivers/bluetooth/btusb.c > @@ -3160,6 +3160,9 @@ static int btusb_mtk_setup(struct hci_dev *hdev) > btusb_mtk_hci_wmt_sync); > if (err < 0) { > bt_dev_err(hdev, "Failed to set up firmware (%d)", err); > + btusb_stop_traffic(data); > + usb_kill_anchored_urbs(&data->tx_anchor); > + usb_queue_reset_device(data->intf); What if this was already caused by a reset? Wouldn't that create a loop resetting the device over and over again? > return err; > } > > -- > 2.18.0 >
diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c index 4c0cc13adb47..c5aab361795e 100644 --- a/drivers/bluetooth/btusb.c +++ b/drivers/bluetooth/btusb.c @@ -3160,6 +3160,9 @@ static int btusb_mtk_setup(struct hci_dev *hdev) btusb_mtk_hci_wmt_sync); if (err < 0) { bt_dev_err(hdev, "Failed to set up firmware (%d)", err); + btusb_stop_traffic(data); + usb_kill_anchored_urbs(&data->tx_anchor); + usb_queue_reset_device(data->intf); return err; }
Add usb reset to recover BT device from a firmware setup failure, it will restore the device to its original state and attempt setup firmware again. Signed-off-by: Hao Qin <hao.qin@mediatek.com> --- drivers/bluetooth/btusb.c | 3 +++ 1 file changed, 3 insertions(+)