| Message ID | 20240426102949.23057-3-zoie.lin@mediatek.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | misc: eeprom: at24: add optional dovdd-supply | expand |
On 26/04/2024 12:29, zoie.lin wrote: > From: Zoie Lin <zoie.lin@mediatek.com> > > Update EEPROM bindings to include Atmel AT24C64 > > Signed-off-by: Zoie Lin <zoie.lin@mediatek.com> > --- > Documentation/devicetree/bindings/eeprom/at24.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/eeprom/at24.yaml b/Documentation/devicetree/bindings/eeprom/at24.yaml > index 1812ef31d5f1..8befd09963be 100644 > --- a/Documentation/devicetree/bindings/eeprom/at24.yaml > +++ b/Documentation/devicetree/bindings/eeprom/at24.yaml > @@ -131,6 +131,8 @@ properties: > - items: > - const: giantec,gt24c32a > - const: atmel,24c32 > + - items: > + - const: atmel,24c64 It is already there as part of pattern. Did you look at it? Best regards, Krzysztof
On Fri, 26 Apr 2024 18:29:48 +0800, zoie.lin wrote: > From: Zoie Lin <zoie.lin@mediatek.com> > > Update EEPROM bindings to include Atmel AT24C64 > > Signed-off-by: Zoie Lin <zoie.lin@mediatek.com> > --- > Documentation/devicetree/bindings/eeprom/at24.yaml | 2 ++ > 1 file changed, 2 insertions(+) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/misc/idt,89hpesx.example.dtb: idt@74: eeprom@50:compatible: More than one condition true in oneOf schema: {'oneOf': [{'allOf': [{'items': [{'pattern': '^(atmel|catalyst|microchip|nxp|ramtron|renesas|rohm|st),(24(c|cs|lc|mac)[0-9]+|spd)$'}, {'pattern': '^atmel,(24(c|cs|mac)[0-9]+|spd)$'}], 'maxItems': 2, 'minItems': 1, 'type': 'array'}, {'oneOf': [{'items': {'pattern': 'c00$'}, 'type': 'array'}, {'items': {'pattern': 'c01$'}, 'type': 'array'}, {'items': {'pattern': 'cs01$'}, 'type': 'array'}, {'items': {'pattern': 'c02$'}, 'type': 'array'}, {'items': {'pattern': 'cs02$'}, 'type': 'array'}, {'items': {'pattern': 'mac402$'}, 'type': 'array'}, {'items': {'pattern': 'mac602$'}, 'type': 'array'}, {'items': {'pattern': 'c04$'}, 'type': 'array'}, {'items': {'pattern': 'cs04$'}, 'type': 'array'}, {'items': {'pattern': 'c08$'}, 'type': 'array'}, {'items': {'pattern': 'cs08$'}, 'type': 'array'}, {'items': {'pattern': 'c16$'}, 'type': 'array'}, {'items': {'pattern': 'cs16$'}, 'type': 'array'}, {'items': {'pattern': 'c32$'}, 'type': 'array'}, {'items': {'pattern': 'c32d-wl$'}, 'type': 'array'}, {'items': {'pattern': 'cs32$'}, 'type': 'array'}, {'items': {'pattern': 'c64$'}, 'type': 'array'}, {'items': {'pattern': 'c64d-wl$'}, 'type': 'array'}, {'items': {'pattern': 'cs64$'}, 'type': 'array'}, {'items': {'pattern': 'c128$'}, 'type': 'array'}, {'items': {'pattern': 'cs128$'}, 'type': 'array'}, {'items': {'pattern': 'c256$'}, 'type': 'array'}, {'items': {'pattern': 'cs256$'}, 'type': 'array'}, {'items': {'pattern': 'c512$'}, 'type': 'array'}, {'items': {'pattern': 'cs512$'}, 'type': 'array'}, {'items': {'pattern': 'c1024$'}, 'type': 'array'}, {'items': {'pattern': 'cs1024$'}, 'type': 'array'}, {'items': {'pattern': 'c1025$'}, 'type': 'array'}, {'items': {'pattern': 'cs1025$'}, 'type': 'array'}, {'items': {'pattern': 'c2048$'}, 'type': 'array'}, {'items': {'pattern': 'cs2048$'}, 'type': 'array'}, {'items': {'pattern': 'spd$'}, 'type': 'array'}]}]}, {'items': [{'const': 'belling,bl24c16a'}, {'const': 'atmel,24c16'}], 'maxItems': 2, 'minItems': 2, 'type': 'array'}, {'items': [{'enum': ['rohm,br24g01', 'rohm,br24t01']}, {'const': 'atmel,24c01'}], 'maxItems': 2, 'minItems': 2, 'type': 'array'}, {'items': [{'enum': ['nxp,se97b', 'renesas,r1ex24002']}, {'const': 'atmel,24c02'}], 'maxItems': 2, 'minItems': 2, 'type': 'array'}, {'items': [{'enum': ['onnn,cat24c04', 'onnn,cat24c05', 'rohm,br24g04']}, {'const': 'atmel,24c04'}], 'maxItems': 2, 'minItems': 2, 'type': 'array'}, {'items': [{'const': 'renesas,r1ex24016'}, {'const': 'atmel,24c16'}], 'maxItems': 2, 'minItems': 2, 'type': 'array'}, {'items': [{'const': 'giantec,gt24c32a'}, {'const': 'atmel,24c32'}], 'maxItems': 2, 'minItems': 2, 'type': 'array'}, {'items': [{'const': 'atmel,24c64'}], 'maxItems': 1, 'minItems': 1, 'type': 'array'}, {'items': [{'enum': ['renesas,r1ex24128', 'samsung,s524ad0xd1']}, {'const': 'atmel,24c128'}], 'maxItems': 2, 'minItems': 2, 'type': 'array'}]} from schema $id: http://devicetree.org/schemas/misc/idt,89hpesx.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/misc/idt,89hpesx.example.dtb: idt@74: eeprom@50: Unevaluated properties are not allowed ('compatible' was unexpected) from schema $id: http://devicetree.org/schemas/misc/idt,89hpesx.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/misc/idt,89hpesx.example.dtb: eeprom@50: compatible: More than one condition true in oneOf schema: {'oneOf': [{'allOf': [{'items': [{'pattern': '^(atmel|catalyst|microchip|nxp|ramtron|renesas|rohm|st),(24(c|cs|lc|mac)[0-9]+|spd)$'}, {'pattern': '^atmel,(24(c|cs|mac)[0-9]+|spd)$'}], 'maxItems': 2, 'minItems': 1, 'type': 'array'}, {'oneOf': [{'items': {'pattern': 'c00$'}, 'type': 'array'}, {'items': {'pattern': 'c01$'}, 'type': 'array'}, {'items': {'pattern': 'cs01$'}, 'type': 'array'}, {'items': {'pattern': 'c02$'}, 'type': 'array'}, {'items': {'pattern': 'cs02$'}, 'type': 'array'}, {'items': {'pattern': 'mac402$'}, 'type': 'array'}, {'items': {'pattern': 'mac602$'}, 'type': 'array'}, {'items': {'pattern': 'c04$'}, 'type': 'array'}, {'items': {'pattern': 'cs04$'}, 'type': 'array'}, {'items': {'pattern': 'c08$'}, 'type': 'array'}, {'items': {'pattern': 'cs08$'}, 'type': 'array'}, {'items': {'pattern': 'c16$'}, 'type': 'array'}, {'items': {'pattern': 'cs16$'}, 'type': 'array'}, {'items': {'pattern': 'c32$'}, 'type': 'array'}, {'items': {'pattern': 'c32d-wl$'}, 'type': 'array'}, {'items': {'pattern': 'cs32$'}, 'type': 'array'}, {'items': {'pattern': 'c64$'}, 'type': 'array'}, {'items': {'pattern': 'c64d-wl$'}, 'type': 'array'}, {'items': {'pattern': 'cs64$'}, 'type': 'array'}, {'items': {'pattern': 'c128$'}, 'type': 'array'}, {'items': {'pattern': 'cs128$'}, 'type': 'array'}, {'items': {'pattern': 'c256$'}, 'type': 'array'}, {'items': {'pattern': 'cs256$'}, 'type': 'array'}, {'items': {'pattern': 'c512$'}, 'type': 'array'}, {'items': {'pattern': 'cs512$'}, 'type': 'array'}, {'items': {'pattern': 'c1024$'}, 'type': 'array'}, {'items': {'pattern': 'cs1024$'}, 'type': 'array'}, {'items': {'pattern': 'c1025$'}, 'type': 'array'}, {'items': {'pattern': 'cs1025$'}, 'type': 'array'}, {'items': {'pattern': 'c2048$'}, 'type': 'array'}, {'items': {'pattern': 'cs2048$'}, 'type': 'array'}, {'items': {'pattern': 'spd$'}, 'type': 'array'}]}]}, {'items': [{'const': 'belling,bl24c16a'}, {'const': 'atmel,24c16'}], 'maxItems': 2, 'minItems': 2, 'type': 'array'}, {'items': [{'enum': ['rohm,br24g01', 'rohm,br24t01']}, {'const': 'atmel,24c01'}], 'maxItems': 2, 'minItems': 2, 'type': 'array'}, {'items': [{'enum': ['nxp,se97b', 'renesas,r1ex24002']}, {'const': 'atmel,24c02'}], 'maxItems': 2, 'minItems': 2, 'type': 'array'}, {'items': [{'enum': ['onnn,cat24c04', 'onnn,cat24c05', 'rohm,br24g04']}, {'const': 'atmel,24c04'}], 'maxItems': 2, 'minItems': 2, 'type': 'array'}, {'items': [{'const': 'renesas,r1ex24016'}, {'const': 'atmel,24c16'}], 'maxItems': 2, 'minItems': 2, 'type': 'array'}, {'items': [{'const': 'giantec,gt24c32a'}, {'const': 'atmel,24c32'}], 'maxItems': 2, 'minItems': 2, 'type': 'array'}, {'items': [{'const': 'atmel,24c64'}], 'maxItems': 1, 'minItems': 1, 'type': 'array'}, {'items': [{'enum': ['renesas,r1ex24128', 'samsung,s524ad0xd1']}, {'const': 'atmel,24c128'}], 'maxItems': 2, 'minItems': 2, 'type': 'array'}]} from schema $id: http://devicetree.org/schemas/eeprom/at24.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/misc/idt,89hpesx.example.dtb: eeprom@50: Unevaluated properties are not allowed ('compatible' was unexpected) from schema $id: http://devicetree.org/schemas/eeprom/at24.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/nvmem/layouts/onie,tlv-layout.example.dtb: eeprom@56: compatible: More than one condition true in oneOf schema: {'oneOf': [{'allOf': [{'items': [{'pattern': '^(atmel|catalyst|microchip|nxp|ramtron|renesas|rohm|st),(24(c|cs|lc|mac)[0-9]+|spd)$'}, {'pattern': '^atmel,(24(c|cs|mac)[0-9]+|spd)$'}], 'maxItems': 2, 'minItems': 1, 'type': 'array'}, {'oneOf': [{'items': {'pattern': 'c00$'}, 'type': 'array'}, {'items': {'pattern': 'c01$'}, 'type': 'array'}, {'items': {'pattern': 'cs01$'}, 'type': 'array'}, {'items': {'pattern': 'c02$'}, 'type': 'array'}, {'items': {'pattern': 'cs02$'}, 'type': 'array'}, {'items': {'pattern': 'mac402$'}, 'type': 'array'}, {'items': {'pattern': 'mac602$'}, 'type': 'array'}, {'items': {'pattern': 'c04$'}, 'type': 'array'}, {'items': {'pattern': 'cs04$'}, 'type': 'array'}, {'items': {'pattern': 'c08$'}, 'type': 'array'}, {'items': {'pattern': 'cs08$'}, 'type': 'array'}, {'items': {'pattern': 'c16$'}, 'type': 'array'}, {'items': {'pattern': 'cs16$'}, 'type': 'array'}, {'items': {'pattern': 'c32$'}, 'type': 'array'}, {'items': {'pattern': 'c32d-wl$'}, 'type': 'array'}, {'items': {'pattern': 'cs32$'}, 'type': 'array'}, {'items': {'pattern': 'c64$'}, 'type': 'array'}, {'items': {'pattern': 'c64d-wl$'}, 'type': 'array'}, {'items': {'pattern': 'cs64$'}, 'type': 'array'}, {'items': {'pattern': 'c128$'}, 'type': 'array'}, {'items': {'pattern': 'cs128$'}, 'type': 'array'}, {'items': {'pattern': 'c256$'}, 'type': 'array'}, {'items': {'pattern': 'cs256$'}, 'type': 'array'}, {'items': {'pattern': 'c512$'}, 'type': 'array'}, {'items': {'pattern': 'cs512$'}, 'type': 'array'}, {'items': {'pattern': 'c1024$'}, 'type': 'array'}, {'items': {'pattern': 'cs1024$'}, 'type': 'array'}, {'items': {'pattern': 'c1025$'}, 'type': 'array'}, {'items': {'pattern': 'cs1025$'}, 'type': 'array'}, {'items': {'pattern': 'c2048$'}, 'type': 'array'}, {'items': {'pattern': 'cs2048$'}, 'type': 'array'}, {'items': {'pattern': 'spd$'}, 'type': 'array'}]}]}, {'items': [{'const': 'belling,bl24c16a'}, {'const': 'atmel,24c16'}], 'maxItems': 2, 'minItems': 2, 'type': 'array'}, {'items': [{'enum': ['rohm,br24g01', 'rohm,br24t01']}, {'const': 'atmel,24c01'}], 'maxItems': 2, 'minItems': 2, 'type': 'array'}, {'items': [{'enum': ['nxp,se97b', 'renesas,r1ex24002']}, {'const': 'atmel,24c02'}], 'maxItems': 2, 'minItems': 2, 'type': 'array'}, {'items': [{'enum': ['onnn,cat24c04', 'onnn,cat24c05', 'rohm,br24g04']}, {'const': 'atmel,24c04'}], 'maxItems': 2, 'minItems': 2, 'type': 'array'}, {'items': [{'const': 'renesas,r1ex24016'}, {'const': 'atmel,24c16'}], 'maxItems': 2, 'minItems': 2, 'type': 'array'}, {'items': [{'const': 'giantec,gt24c32a'}, {'const': 'atmel,24c32'}], 'maxItems': 2, 'minItems': 2, 'type': 'array'}, {'items': [{'const': 'atmel,24c64'}], 'maxItems': 1, 'minItems': 1, 'type': 'array'}, {'items': [{'enum': ['renesas,r1ex24128', 'samsung,s524ad0xd1']}, {'const': 'atmel,24c128'}], 'maxItems': 2, 'minItems': 2, 'type': 'array'}]} from schema $id: http://devicetree.org/schemas/eeprom/at24.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/nvmem/layouts/onie,tlv-layout.example.dtb: eeprom@56: Unevaluated properties are not allowed ('compatible' was unexpected) from schema $id: http://devicetree.org/schemas/eeprom/at24.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240426102949.23057-3-zoie.lin@mediatek.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
diff --git a/Documentation/devicetree/bindings/eeprom/at24.yaml b/Documentation/devicetree/bindings/eeprom/at24.yaml index 1812ef31d5f1..8befd09963be 100644 --- a/Documentation/devicetree/bindings/eeprom/at24.yaml +++ b/Documentation/devicetree/bindings/eeprom/at24.yaml @@ -131,6 +131,8 @@ properties: - items: - const: giantec,gt24c32a - const: atmel,24c32 + - items: + - const: atmel,24c64 - items: - enum: - renesas,r1ex24128