From patchwork Mon Jul 8 19:43:15 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= X-Patchwork-Id: 13726999 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 80DCEC3271E for ; Mon, 8 Jul 2024 19:43:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:Message-Id: Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=9kMghRIqWvTT0TKoXDD9S9RO/o0DiZ4L6h+hSKTaIT0=; b=UkmZevRBBSf3zuR/WzXFnhgXLs yr+srwQtqF+xesnn5JTJvODWD6vO9uNtSwe8+cbsj5XqeU20gqRSgjpjP/Pzw71DoWDnRbRwi+rul 1wyGWBFXUrhsbzDSUIB6QzMvWRvBc+t7u+eHggZCjc5aSY1qxu0CtEgLg3NpfzRsmiM8lSvQXhHUe PQ7J1C7OnYU7XRvMyuakvAYnqNUOt07aLj2/4fkcyvhwypOOIgBzb4zN6eyAfzpxuQ9Kukc3v+MHh 96aJpBrjGXgd7LwKaq2MnN+hocTvbvMKdqhF0GBaUJ0VOKyWRdGX8zy7wpMKWpLoDLj+ko4uwS4Ch v5VrrDgA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sQuH6-00000004roP-0Mbe; Mon, 08 Jul 2024 19:43:48 +0000 Received: from madrid.collaboradmins.com ([2a00:1098:ed:100::25]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sQuGo-00000004rjL-1KYa; Mon, 08 Jul 2024 19:43:33 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1720467808; bh=+rPOdVxxZZGW2sv/TAxO/m4SPgVBlYvpsQEukQOBf7E=; h=From:Date:Subject:To:Cc:From; b=Xr5Dcd4Q9woGLlxWKghbEDLCUucBe6HkFTW13hjInOqEXYSPQID1w3spxYVHVQZY6 8Vzpz/2FXvdH4XOz5Cv62/GWI4S+qgRoOYeOlI90p9pOpT/YBIebapDxBSNooFUu+c WUuUKdZDV5Psg4nF4iOF2uxnn3DTIv/KRUuL1fLT/+58WsPgoCYreT3XPMDf8naxIz 3VR5g6GYTexpMkm6Ql4LrCpAiBDiUYH+KHMyyl2qNma+kK/J+0lrk6zU5Ytx7hBi3I 324rPqrBT194S79dlij6If5rf6lu9lhkfrhg5EATKbZfX+kYTR0qicsRtjtLus+Arj x2CY9AYZBLTjw== Received: from [192.168.1.242] (zone.collabora.co.uk [167.235.23.81]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by madrid.collaboradmins.com (Postfix) with ESMTPSA id ED87A378042B; Mon, 8 Jul 2024 19:43:26 +0000 (UTC) From: =?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= Date: Mon, 08 Jul 2024 15:43:15 -0400 Subject: [PATCH v2] nvmem: mtk-efuse: Only register socinfo device if needed cells are there MIME-Version: 1.0 Message-Id: <20240708-mtk-socinfo-no-data-probe-err-v2-1-7ae252acbcc2@collabora.com> X-B4-Tracking: v=1; b=H4sIAFNBjGYC/43NSw6CQBBF0a2QGlsGGgjEkfswDPorFaGLVBOiI ezdlhU4PG9w3w7JC/kEt2IH8Rsl4pihLgXYUcenR3LZoErVlF3Z47y+MLGlGBgjo9OrxkXYePQ i6Lq27eumdrZXkBuL+EDvs/8YskdKK8vnvNuq3/pveauwwmCUtq7WTWfC3fI0acOir5ZnGI7j+ AIAesF7zgAAAA== To: Srinivas Kandagatla , Matthias Brugger , AngeloGioacchino Del Regno , Chen-Yu Tsai Cc: kernel@collabora.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, =?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= X-Mailer: b4 0.14.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240708_124330_659453_51D07D14 X-CRM114-Status: GOOD ( 15.30 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Not every efuse region has cells storing SoC information. Only register an socinfo device if the required cells are present. This prevents the pointless process of creating an socinfo device, probing it with the socinfo driver only to ultimately error out like so mtk-socinfo mtk-socinfo.0.auto: error -ENOENT: Failed to get socinfo data mtk-socinfo mtk-socinfo.0.auto: probe with driver mtk-socinfo failed with error -2 This issue is observed on the mt8183-kukui-jacuzzi-juniper-sku16 platform, which has two efuse regions, but only one of them contains the SoC data. Signed-off-by: Nícolas F. R. A. Prado --- Changes in v2: - Added missing include for of.h - Link to v1: https://lore.kernel.org/r/20240708-mtk-socinfo-no-data-probe-err-v1-1-fb2acd3a47bf@collabora.com --- drivers/nvmem/mtk-efuse.c | 18 ++++++++++++++---- 1 file changed, 14 insertions(+), 4 deletions(-) --- base-commit: 0b58e108042b0ed28a71cd7edf5175999955b233 change-id: 20240708-mtk-socinfo-no-data-probe-err-d7558343dc82 Best regards, diff --git a/drivers/nvmem/mtk-efuse.c b/drivers/nvmem/mtk-efuse.c index 9caf04667341..74def409bc20 100644 --- a/drivers/nvmem/mtk-efuse.c +++ b/drivers/nvmem/mtk-efuse.c @@ -11,6 +11,7 @@ #include #include #include +#include struct mtk_efuse_pdata { bool uses_post_processing; @@ -60,6 +61,8 @@ static void mtk_efuse_fixup_dt_cell_info(struct nvmem_device *nvmem, cell->read_post_process = mtk_efuse_gpu_speedbin_pp; } +static const char socinfo_data_first_name[] = "socinfo-data1"; + static int mtk_efuse_probe(struct platform_device *pdev) { struct device *dev = &pdev->dev; @@ -69,6 +72,7 @@ static int mtk_efuse_probe(struct platform_device *pdev) struct mtk_efuse_priv *priv; const struct mtk_efuse_pdata *pdata; struct platform_device *socinfo; + struct device_node *np; priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); if (!priv) @@ -92,10 +96,16 @@ static int mtk_efuse_probe(struct platform_device *pdev) if (IS_ERR(nvmem)) return PTR_ERR(nvmem); - socinfo = platform_device_register_data(&pdev->dev, "mtk-socinfo", - PLATFORM_DEVID_AUTO, NULL, 0); - if (IS_ERR(socinfo)) - dev_info(dev, "MediaTek SoC Information will be unavailable\n"); + np = of_get_child_by_name(pdev->dev.of_node, socinfo_data_first_name); + if (np) { + of_node_put(np); + socinfo = platform_device_register_data(&pdev->dev, "mtk-socinfo", + PLATFORM_DEVID_AUTO, NULL, 0); + if (IS_ERR(socinfo)) + dev_info(dev, "MediaTek SoC Information will be unavailable\n"); + } else { + dev_info(dev, "Efuse region does not contain SoC information - skipping socinfo driver setup\n"); + } platform_set_drvdata(pdev, socinfo); return 0;