diff mbox series

[v2,3/7] dt-bindings: rtc: mt6397: merge to MFD mediatek,mt6397 DT schema

Message ID 20240830110732.30080-3-macpaul.lin@mediatek.com (mailing list archive)
State New
Headers show
Series [v2,1/7] regulator: dt-bindings: mt6323: Convert to DT schema | expand

Commit Message

Macpaul Lin Aug. 30, 2024, 11:07 a.m. UTC
Convert rtc-mt6397.txt be compatible with the DT schema.
Since this is a simple RTC device node, merge it into parent
mediatek,mt6397.yaml. Subsequently, remove rtc-mt6397.txt with a
separate patch.

Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
---
 .../devicetree/bindings/rtc/rtc-mt6397.txt    | 31 -------------------
 1 file changed, 31 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/rtc/rtc-mt6397.txt

Changes for v1 and v2:
 - This is the first version of converting rtc-mt6397.txt.
   This is because converting rtc-mt6397 together
   with mfd/mediatek,mt6397.yaml, so we've create a patch set
   instead of submitting single patch for each subdevice.
 - This patch has been made base on linux-next/master git repo.

Comments

Rob Herring (Arm) Aug. 30, 2024, 3:34 p.m. UTC | #1
On Fri, Aug 30, 2024 at 07:07:28PM +0800, Macpaul Lin wrote:
> Convert rtc-mt6397.txt be compatible with the DT schema.
> Since this is a simple RTC device node, merge it into parent
> mediatek,mt6397.yaml. Subsequently, remove rtc-mt6397.txt with a
> separate patch.

This doesn't match what the patch does. You can just squash this into 
the MFD patch where you add the schema.

> 
> Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
> ---
>  .../devicetree/bindings/rtc/rtc-mt6397.txt    | 31 -------------------
>  1 file changed, 31 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/rtc/rtc-mt6397.txt
Macpaul Lin Sept. 13, 2024, 4:29 p.m. UTC | #2
On 8/30/24 23:34, Rob Herring wrote:
> 	
> 
> External email : Please do not click links or open attachments until you 
> have verified the sender or the content.
> 
> On Fri, Aug 30, 2024 at 07:07:28PM +0800, Macpaul Lin wrote:
>> Convert rtc-mt6397.txt be compatible with the DT schema.
>> Since this is a simple RTC device node, merge it into parent
>> mediatek,mt6397.yaml. Subsequently, remove rtc-mt6397.txt with a
>> separate patch.
> 
> This doesn't match what the patch does. You can just squash this into
> the MFD patch where you add the schema.
> 

[snip]

Will squash the other patches for removing text format files in to the 
MFD patch in next (v3) version. Thanks!

Regards,
Macpaul Lin
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/rtc/rtc-mt6397.txt b/Documentation/devicetree/bindings/rtc/rtc-mt6397.txt
deleted file mode 100644
index 7212076..0000000
--- a/Documentation/devicetree/bindings/rtc/rtc-mt6397.txt
+++ /dev/null
@@ -1,31 +0,0 @@ 
-Device-Tree bindings for MediaTek PMIC based RTC
-
-MediaTek PMIC based RTC is an independent function of MediaTek PMIC that works
-as a type of multi-function device (MFD). The RTC can be configured and set up
-with PMIC wrapper bus which is a common resource shared with the other
-functions found on the same PMIC.
-
-For MediaTek PMIC MFD bindings, see:
-../mfd/mt6397.txt
-
-For MediaTek PMIC wrapper bus bindings, see:
-../soc/mediatek/pwrap.txt
-
-Required properties:
-- compatible: Should be one of follows
-       "mediatek,mt6323-rtc": for MT6323 PMIC
-       "mediatek,mt6358-rtc": for MT6358 PMIC
-       "mediatek,mt6366-rtc", "mediatek,mt6358-rtc": for MT6366 PMIC
-       "mediatek,mt6397-rtc": for MT6397 PMIC
-
-Example:
-
-       pmic {
-               compatible = "mediatek,mt6323";
-
-               ...
-
-               rtc {
-                       compatible = "mediatek,mt6323-rtc";
-               };
-       };