| Message ID | 20240930083854.7267-5-macpaul.lin@mediatek.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [v4,1/5] arm64: dts: mt8195: Fix dtbs_check error for infracfg_ao node | expand |
On Mon, Sep 30, 2024 at 04:38:54PM +0800, Macpaul Lin wrote: > The MediaTek DPI module is typically associated with one of the > following multimedia power domains: > - POWER_DOMAIN_DISPLAY > - POWER_DOMAIN_VDOSYS > - POWER_DOMAIN_MM > The specific power domain used varies depending on the SoC design. > > These power domains are shared by multiple devices within the SoC. > In most cases, these power domains are enabled by other devices. > As a result, the DPI module of legacy SoCs often functions correctly > even without explicit configuration. > > It is recommended to explicitly add the appropriate power domain > property to the DPI node in the device tree. Hence drop the > compatible checking for specific SoCs. > > Fixes: 5474d49b2f79 ("dt-bindings: display: mediatek: dpi: Add power domains") > Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com> > Signed-off-by: Jitao Shi <jitao.shi@mediatek.com> > Signed-off-by: Pablo Sun <pablo.sun@mediatek.com> > --- > .../display/mediatek/mediatek,dpi.yaml | 24 ++++++++----------- > 1 file changed, 10 insertions(+), 14 deletions(-) You missed Krzysztof's R-by tag.
On 10/2/24 09:51, Rob Herring wrote: > > > External email : Please do not click links or open attachments until you > have verified the sender or the content. > > On Mon, Sep 30, 2024 at 04:38:54PM +0800, Macpaul Lin wrote: >> The MediaTek DPI module is typically associated with one of the >> following multimedia power domains: >> - POWER_DOMAIN_DISPLAY >> - POWER_DOMAIN_VDOSYS >> - POWER_DOMAIN_MM >> The specific power domain used varies depending on the SoC design. >> >> These power domains are shared by multiple devices within the SoC. >> In most cases, these power domains are enabled by other devices. >> As a result, the DPI module of legacy SoCs often functions correctly >> even without explicit configuration. >> >> It is recommended to explicitly add the appropriate power domain >> property to the DPI node in the device tree. Hence drop the >> compatible checking for specific SoCs. >> >> Fixes: 5474d49b2f79 ("dt-bindings: display: mediatek: dpi: Add power domains") >> Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com> >> Signed-off-by: Jitao Shi <jitao.shi@mediatek.com> >> Signed-off-by: Pablo Sun <pablo.sun@mediatek.com> >> --- >> .../display/mediatek/mediatek,dpi.yaml | 24 ++++++++----------- >> 1 file changed, 10 insertions(+), 14 deletions(-) > > You missed Krzysztof's R-by tag. > Oh, I just missed that reply for v3 in the mailbox and thought it still need to be reviewed. I just found Krzysztof's R-by tag in the mailbox right now. I'll send an update for this patch set. Thanks for the reminder. Regards, Macpaul Lin
On Wed, Oct 02, 2024 at 11:09:07AM +0800, Macpaul Lin wrote: > > > On 10/2/24 09:51, Rob Herring wrote: > > > > > > External email : Please do not click links or open attachments until you > > have verified the sender or the content. > > > > On Mon, Sep 30, 2024 at 04:38:54PM +0800, Macpaul Lin wrote: > > > The MediaTek DPI module is typically associated with one of the > > > following multimedia power domains: > > > - POWER_DOMAIN_DISPLAY > > > - POWER_DOMAIN_VDOSYS > > > - POWER_DOMAIN_MM > > > The specific power domain used varies depending on the SoC design. > > > > > > These power domains are shared by multiple devices within the SoC. > > > In most cases, these power domains are enabled by other devices. > > > As a result, the DPI module of legacy SoCs often functions correctly > > > even without explicit configuration. > > > > > > It is recommended to explicitly add the appropriate power domain > > > property to the DPI node in the device tree. Hence drop the > > > compatible checking for specific SoCs. > > > > > > Fixes: 5474d49b2f79 ("dt-bindings: display: mediatek: dpi: Add power domains") > > > Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com> > > > Signed-off-by: Jitao Shi <jitao.shi@mediatek.com> > > > Signed-off-by: Pablo Sun <pablo.sun@mediatek.com> > > > --- > > > .../display/mediatek/mediatek,dpi.yaml | 24 ++++++++----------- > > > 1 file changed, 10 insertions(+), 14 deletions(-) > > > > You missed Krzysztof's R-by tag. > > > > Oh, I just missed that reply for v3 in the mailbox > and thought it still need to be reviewed. > I just found Krzysztof's R-by tag in the mailbox right now. > > I'll send an update for this patch set. > Thanks for the reminder. Plaese, instead just start using b4... Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml index 3a82aec9021c..497c0eb4ed0b 100644 --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml @@ -63,6 +63,16 @@ properties: - const: sleep power-domains: + description: | + The MediaTek DPI module is typically associated with one of the + following multimedia power domains: + POWER_DOMAIN_DISPLAY + POWER_DOMAIN_VDOSYS + POWER_DOMAIN_MM + The specific power domain used varies depending on the SoC design. + + It is recommended to explicitly add the appropriate power domain + property to the DPI node in the device tree. maxItems: 1 port: @@ -79,20 +89,6 @@ required: - clock-names - port -allOf: - - if: - not: - properties: - compatible: - contains: - enum: - - mediatek,mt6795-dpi - - mediatek,mt8173-dpi - - mediatek,mt8186-dpi - then: - properties: - power-domains: false - additionalProperties: false examples:
The MediaTek DPI module is typically associated with one of the following multimedia power domains: - POWER_DOMAIN_DISPLAY - POWER_DOMAIN_VDOSYS - POWER_DOMAIN_MM The specific power domain used varies depending on the SoC design. These power domains are shared by multiple devices within the SoC. In most cases, these power domains are enabled by other devices. As a result, the DPI module of legacy SoCs often functions correctly even without explicit configuration. It is recommended to explicitly add the appropriate power domain property to the DPI node in the device tree. Hence drop the compatible checking for specific SoCs. Fixes: 5474d49b2f79 ("dt-bindings: display: mediatek: dpi: Add power domains") Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com> Signed-off-by: Jitao Shi <jitao.shi@mediatek.com> Signed-off-by: Pablo Sun <pablo.sun@mediatek.com> --- .../display/mediatek/mediatek,dpi.yaml | 24 ++++++++----------- 1 file changed, 10 insertions(+), 14 deletions(-) Changes for v2: - Because of the corresponding dts fix has been reviewed with a Reviewed-by: tag. [1] https://lore.kernel.org/all/20240925080515.16377-1-macpaul.lin@mediatek.com/ We still need this change to fix the 2 dtbs_check errors. So keeps no change here. Changes for v3: - The origin patch is [2] https://lore.kernel.org/all/20240926111449.9245-2-macpaul.lin@mediatek.com/ - Thanks for Conor's reminding, after MediaTek's internal discussion, This patch v3 is the replacement of [2] v2. Because the DPI module should has a explicit configuration with power domain. - Drop Acked-by: tag since v3 is nearly a new patch for different approach. Changes for v4: - No change. Please help to review it again.