diff mbox series

[v1] dt-bindings: spi: add compatibles for mt7988

Message ID 20241006102740.17948-1-linux@fw-web.de (mailing list archive)
State New
Headers show
Series [v1] dt-bindings: spi: add compatibles for mt7988 | expand

Commit Message

Frank Wunderlich Oct. 6, 2024, 10:27 a.m. UTC 
From: Frank Wunderlich <frank-w@public-files.de>

MT7988 has 2 different spi controllers. Add mediatek,ipm-spi-single
and mediatek,ipm-spi-quad compatibles.

Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
---
 Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml | 2 ++
 1 file changed, 2 insertions(+)

Comments

Krzysztof Kozlowski Oct. 6, 2024, 12:48 p.m. UTC | #1 
On Sun, Oct 06, 2024 at 12:27:39PM +0200, Frank Wunderlich wrote:
> From: Frank Wunderlich <frank-w@public-files.de>
> 
> MT7988 has 2 different spi controllers. Add mediatek,ipm-spi-single
> and mediatek,ipm-spi-quad compatibles.

Why generic compatibles?

These are supposed to be SoC-specific.

Best regards,
Krzysztof
Frank Wunderlich Oct. 6, 2024, 3:11 p.m. UTC | #2 
Hi

> Gesendet: Sonntag, 06. Oktober 2024 um 14:48 Uhr
> Von: "Krzysztof Kozlowski" <krzk@kernel.org>
> Betreff: Re: [PATCH v1] dt-bindings: spi: add compatibles for mt7988
>
> On Sun, Oct 06, 2024 at 12:27:39PM +0200, Frank Wunderlich wrote:
> > From: Frank Wunderlich <frank-w@public-files.de>
> >
> > MT7988 has 2 different spi controllers. Add mediatek,ipm-spi-single
> > and mediatek,ipm-spi-quad compatibles.
>
> Why generic compatibles?
>
> These are supposed to be SoC-specific.

currently i used the compatibles used in SDK, but got info now, that there is some more discussion needed with mtk.

> Best regards,
> Krzysztof
>
>
Matthias Brugger Oct. 7, 2024, 2:16 p.m. UTC | #3 
On 06/10/2024 17:11, Frank Wunderlich wrote:
> Hi
> 
>> Gesendet: Sonntag, 06. Oktober 2024 um 14:48 Uhr
>> Von: "Krzysztof Kozlowski" <krzk@kernel.org>
>> Betreff: Re: [PATCH v1] dt-bindings: spi: add compatibles for mt7988
>>
>> On Sun, Oct 06, 2024 at 12:27:39PM +0200, Frank Wunderlich wrote:
>>> From: Frank Wunderlich <frank-w@public-files.de>
>>>
>>> MT7988 has 2 different spi controllers. Add mediatek,ipm-spi-single
>>> and mediatek,ipm-spi-quad compatibles.
>>
>> Why generic compatibles?
>>
>> These are supposed to be SoC-specific.
> 
> currently i used the compatibles used in SDK, but got info now, that there is some more discussion needed with mtk.
> 

Ok, but please don't introduce generic compatibles. We prever SoC specific ones 
with a fall-back (to a different SoC specific one).

Regards,
Matthias
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml b/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml
index e1f5bfa4433c..3c707e5de5fb 100644
--- a/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml
+++ b/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml
@@ -33,6 +33,8 @@  properties:
           - const: mediatek,mt6765-spi
       - items:
           - enum:
+              - mediatek,ipm-spi-quad
+              - mediatek,ipm-spi-single
               - mediatek,mt7981-spi-ipm
               - mediatek,mt7986-spi-ipm
               - mediatek,mt8188-spi-ipm